From: Zhang Rui <rui.zhang@intel.com>
To: Igor Murzov <e-mail@date.by>
Cc: linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Stefan Wilkens <stefanwilkens@gmail.com>,
Sergey V <sftp.mtuci@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI video: Ignore errors after _DOD evaluation.
Date: Tue, 23 Oct 2012 18:40:12 +0800 [thread overview]
Message-ID: <1350988812.1859.3.camel@rui.sh.intel.com> (raw)
In-Reply-To: <1350088885-13918-1-git-send-email-e-mail@date.by>
On 六, 2012-10-13 at 04:41 +0400, Igor Murzov wrote:
> There are systems where video module known to work fine regardless
> of broken _DOD and ignoring returned value here doesn't cause
> any issues later. This should fix brightness controls on some laptops.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47861
>
> Signed-off-by: Igor Murzov <e-mail@date.by>
> Reviewed-by: Sergey V <sftp.mtuci@gmail.com>
applied to my next branch.
thanks,
rui
> ---
> Previous discussion of the issue:
> http://thread.gmane.org/gmane.linux.acpi.devel/56345
>
> drivers/acpi/video.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index f94d4c8..0230cb6 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -1345,12 +1345,15 @@ static int
> acpi_video_bus_get_devices(struct acpi_video_bus *video,
> struct acpi_device *device)
> {
> - int status;
> + int status = 0;
> struct acpi_device *dev;
>
> - status = acpi_video_device_enumerate(video);
> - if (status)
> - return status;
> + /*
> + * There are systems where video module known to work fine regardless
> + * of broken _DOD and ignoring returned value here doesn't cause
> + * any issues later.
> + */
> + acpi_video_device_enumerate(video);
>
> list_for_each_entry(dev, &device->children, node) {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Zhang Rui <rui.zhang@intel.com>
To: Igor Murzov <e-mail@date.by>
Cc: linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Stefan Wilkens <stefanwilkens@gmail.com>,
Sergey V <sftp.mtuci@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI video: Ignore errors after _DOD evaluation.
Date: Tue, 23 Oct 2012 18:40:12 +0800 [thread overview]
Message-ID: <1350988812.1859.3.camel@rui.sh.intel.com> (raw)
In-Reply-To: <1350088885-13918-1-git-send-email-e-mail@date.by>
On 六, 2012-10-13 at 04:41 +0400, Igor Murzov wrote:
> There are systems where video module known to work fine regardless
> of broken _DOD and ignoring returned value here doesn't cause
> any issues later. This should fix brightness controls on some laptops.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47861
>
> Signed-off-by: Igor Murzov <e-mail@date.by>
> Reviewed-by: Sergey V <sftp.mtuci@gmail.com>
applied to my next branch.
thanks,
rui
> ---
> Previous discussion of the issue:
> http://thread.gmane.org/gmane.linux.acpi.devel/56345
>
> drivers/acpi/video.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index f94d4c8..0230cb6 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -1345,12 +1345,15 @@ static int
> acpi_video_bus_get_devices(struct acpi_video_bus *video,
> struct acpi_device *device)
> {
> - int status;
> + int status = 0;
> struct acpi_device *dev;
>
> - status = acpi_video_device_enumerate(video);
> - if (status)
> - return status;
> + /*
> + * There are systems where video module known to work fine regardless
> + * of broken _DOD and ignoring returned value here doesn't cause
> + * any issues later.
> + */
> + acpi_video_device_enumerate(video);
>
> list_for_each_entry(dev, &device->children, node) {
>
next prev parent reply other threads:[~2012-10-23 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 0:41 [PATCH] ACPI video: Ignore errors after _DOD evaluation Igor Murzov
2012-10-23 10:40 ` Zhang Rui [this message]
2012-10-23 10:40 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350988812.1859.3.camel@rui.sh.intel.com \
--to=rui.zhang@intel.com \
--cc=e-mail@date.by \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sftp.mtuci@gmail.com \
--cc=stefanwilkens@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.