All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: mhocko-AlSwsSmVLrQ@public.gmane.org,
	glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org
Subject: [PATCHSET cgroup/for-3.8] cgroup: allow ->post_create() to fail
Date: Mon, 12 Nov 2012 19:01:27 -0800	[thread overview]
Message-ID: <1352775704-9023-1-git-send-email-tj@kernel.org> (raw)

Hello,

This became a rather large patchset mostly because there are a lot of
weirdities and subtle breakages in create/destroy/load/unload paths.
The goal of the patchset is allowing ->post_create() to fail and
renaming ->create/post_create/pre_destroy/destroy() to
->css_alloc/css_online/css_offline/css_free().

This patchset contains the following seventeen patches.

 0001-cgroup-remove-incorrect-dget-dput-pair-in-cgroup_cre.patch
 0002-cgroup-initialize-cgrp-allcg_node-in-init_cgroup_hou.patch
 0003-cgroup-open-code-cgroup_create_dir.patch
 0004-cgroup-create-directory-before-linking-while-creatin.patch
 0005-cgroup-cgroup-dentry-isn-t-a-RCU-pointer.patch
 0006-cgroup-remove-duplicate-RCU-free-on-struct-cgroup.patch
 0007-cgroup-make-CSS_-flags-bit-masks-instead-of-bit-posi.patch
 0008-cgroup-trivial-cleanup-for-cgroup_init-load_subsys.patch
 0009-cgroup-lock-cgroup_mutex-in-cgroup_init_subsys.patch
 0010-cgroup-fix-harmless-bugs-in-cgroup_load_subsys-fail-.patch
 0011-cgroup-separate-out-cgroup_destroy_locked.patch
 0012-cgroup-introduce-CSS_ONLINE-flag-and-on-offline_css-.patch
 0013-cgroup-simplify-cgroup_load_subsys-failure-path.patch
 0014-cgroup-use-mutex_trylock-when-grabbing-i_mutex-of-a-.patch
 0015-cgroup-update-cgroup_create-failure-path.patch
 0016-cgroup-allow-post_create-to-fail.patch
 0017-cgroup-rename-create-post_create-pre_destroy-destroy.patch

0001 is a bugfix.  Tagged for -stable.  I don't I'll push it through
for-3.7-fixes tho.  This has been broken forever and nobody reported
anything yet.

0002-0011 are various fixes and cleanups to prepare for the following
changes.  Each should be self-explanatory.

0012-0015 are preparation patches more directly related to allowing
failure of ->post_create().

0016 allows ->post_create() to fail.

0017 renames ops and updates documentation.

This patchst is on top of cgroup/for-3.8 and available on the
following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-cgroup-online-may-fail

and contains the following changes.

 Documentation/cgroups/cgroups.txt |   49 +++---
 block/blk-cgroup.c                |   14 -
 include/linux/cgroup.h            |   47 +++---
 kernel/cgroup.c                   |  288 +++++++++++++++++++++-----------------
 kernel/cgroup_freezer.c           |   22 +-
 kernel/cpuset.c                   |   10 -
 kernel/events/core.c              |    8 -
 kernel/sched/core.c               |   16 +-
 mm/hugetlb_cgroup.c               |   14 -
 mm/memcontrol.c                   |   12 -
 net/core/netprio_cgroup.c         |    8 -
 net/sched/cls_cgroup.c            |    8 -
 security/device_cgroup.c          |    8 -
 13 files changed, 278 insertions(+), 226 deletions(-)

Thanks.

--
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: lizefan@huawei.com, containers@lists.linux-foundation.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mhocko@suse.cz, glommer@parallels.com
Subject: [PATCHSET cgroup/for-3.8] cgroup: allow ->post_create() to fail
Date: Mon, 12 Nov 2012 19:01:27 -0800	[thread overview]
Message-ID: <1352775704-9023-1-git-send-email-tj@kernel.org> (raw)

Hello,

This became a rather large patchset mostly because there are a lot of
weirdities and subtle breakages in create/destroy/load/unload paths.
The goal of the patchset is allowing ->post_create() to fail and
renaming ->create/post_create/pre_destroy/destroy() to
->css_alloc/css_online/css_offline/css_free().

This patchset contains the following seventeen patches.

 0001-cgroup-remove-incorrect-dget-dput-pair-in-cgroup_cre.patch
 0002-cgroup-initialize-cgrp-allcg_node-in-init_cgroup_hou.patch
 0003-cgroup-open-code-cgroup_create_dir.patch
 0004-cgroup-create-directory-before-linking-while-creatin.patch
 0005-cgroup-cgroup-dentry-isn-t-a-RCU-pointer.patch
 0006-cgroup-remove-duplicate-RCU-free-on-struct-cgroup.patch
 0007-cgroup-make-CSS_-flags-bit-masks-instead-of-bit-posi.patch
 0008-cgroup-trivial-cleanup-for-cgroup_init-load_subsys.patch
 0009-cgroup-lock-cgroup_mutex-in-cgroup_init_subsys.patch
 0010-cgroup-fix-harmless-bugs-in-cgroup_load_subsys-fail-.patch
 0011-cgroup-separate-out-cgroup_destroy_locked.patch
 0012-cgroup-introduce-CSS_ONLINE-flag-and-on-offline_css-.patch
 0013-cgroup-simplify-cgroup_load_subsys-failure-path.patch
 0014-cgroup-use-mutex_trylock-when-grabbing-i_mutex-of-a-.patch
 0015-cgroup-update-cgroup_create-failure-path.patch
 0016-cgroup-allow-post_create-to-fail.patch
 0017-cgroup-rename-create-post_create-pre_destroy-destroy.patch

0001 is a bugfix.  Tagged for -stable.  I don't I'll push it through
for-3.7-fixes tho.  This has been broken forever and nobody reported
anything yet.

0002-0011 are various fixes and cleanups to prepare for the following
changes.  Each should be self-explanatory.

0012-0015 are preparation patches more directly related to allowing
failure of ->post_create().

0016 allows ->post_create() to fail.

0017 renames ops and updates documentation.

This patchst is on top of cgroup/for-3.8 and available on the
following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-cgroup-online-may-fail

and contains the following changes.

 Documentation/cgroups/cgroups.txt |   49 +++---
 block/blk-cgroup.c                |   14 -
 include/linux/cgroup.h            |   47 +++---
 kernel/cgroup.c                   |  288 +++++++++++++++++++++-----------------
 kernel/cgroup_freezer.c           |   22 +-
 kernel/cpuset.c                   |   10 -
 kernel/events/core.c              |    8 -
 kernel/sched/core.c               |   16 +-
 mm/hugetlb_cgroup.c               |   14 -
 mm/memcontrol.c                   |   12 -
 net/core/netprio_cgroup.c         |    8 -
 net/sched/cls_cgroup.c            |    8 -
 security/device_cgroup.c          |    8 -
 13 files changed, 278 insertions(+), 226 deletions(-)

Thanks.

--
tejun

             reply	other threads:[~2012-11-13  3:01 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13  3:01 Tejun Heo [this message]
2012-11-13  3:01 ` [PATCHSET cgroup/for-3.8] cgroup: allow ->post_create() to fail Tejun Heo
2012-11-13  3:01 ` [PATCH 12/17] cgroup: introduce CSS_ONLINE flag and on/offline_css() helpers Tejun Heo
     [not found] ` <1352775704-9023-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-13  3:01   ` [PATCH 01/17] cgroup: remove incorrect dget/dput() pair in cgroup_create_dir() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
     [not found]     ` <1352775704-9023-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-19  8:08       ` Li Zefan
2012-11-19  8:08         ` Li Zefan
     [not found]         ` <50A9E8E4.4050004-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-11-19 16:28           ` Tejun Heo
2012-11-19 16:28             ` Tejun Heo
2012-11-19  8:08       ` Li Zefan
2012-11-13  3:01   ` [PATCH 02/17] cgroup: initialize cgrp->allcg_node in init_cgroup_housekeeping() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 03/17] cgroup: open-code cgroup_create_dir() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 04/17] cgroup: create directory before linking while creating a new cgroup Tejun Heo
2012-11-13  3:01     ` Tejun Heo
     [not found]     ` <1352775704-9023-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-14  3:20       ` Li Zefan
2012-11-14  3:20         ` Li Zefan
     [not found]         ` <50A30E0F.7000408-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-11-14 19:04           ` Tejun Heo
2012-11-14 19:04           ` Tejun Heo
2012-11-14 19:04             ` Tejun Heo
     [not found]             ` <20121114190407.GI21185-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-11-16  6:04               ` Li Zefan
2012-11-16  6:04               ` Li Zefan
2012-11-16  6:04                 ` Li Zefan
2012-11-14 19:48       ` [PATCH v2 " Tejun Heo
2012-11-14 19:48         ` Tejun Heo
2012-11-14 19:48       ` Tejun Heo
2012-11-13  3:01   ` [PATCH 05/17] cgroup: cgroup->dentry isn't a RCU pointer Tejun Heo
2012-11-13  3:01     ` Tejun Heo
     [not found]     ` <1352775704-9023-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-14 11:05       ` Glauber Costa
2012-11-14 11:05       ` Glauber Costa
2012-11-14 11:05         ` Glauber Costa
     [not found]         ` <50A37B0A.7010608-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-14 18:55           ` Tejun Heo
2012-11-14 18:55             ` Tejun Heo
     [not found]             ` <20121114185504.GG21185-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2012-11-15  3:00               ` Glauber Costa
2012-11-15  3:00               ` Glauber Costa
2012-11-15  3:00                 ` Glauber Costa
     [not found]                 ` <50A45ABB.3040507-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-11-14 19:01                   ` Tejun Heo
2012-11-14 19:01                     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 06/17] cgroup: remove duplicate RCU free on struct cgroup Tejun Heo
2012-11-13  3:01     ` Tejun Heo
     [not found]     ` <1352775704-9023-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-11-19  9:02       ` Li Zefan
2012-11-19  9:02         ` Li Zefan
     [not found]         ` <50A9F5B2.5080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-11-19 16:59           ` Tejun Heo
2012-11-19 16:59             ` Tejun Heo
2012-11-13  3:01   ` [PATCH 07/17] cgroup: make CSS_* flags bit masks instead of bit positions Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 08/17] cgroup: trivial cleanup for cgroup_init/load_subsys() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 09/17] cgroup: lock cgroup_mutex in cgroup_init_subsys() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 10/17] cgroup: fix harmless bugs in cgroup_load_subsys() fail path and cgroup_unload_subsys() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 11/17] cgroup: separate out cgroup_destroy_locked() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 12/17] cgroup: introduce CSS_ONLINE flag and on/offline_css() helpers Tejun Heo
2012-11-13  3:01   ` [PATCH 13/17] cgroup: simplify cgroup_load_subsys() failure path Tejun Heo
2012-11-13  3:01   ` Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 14/17] cgroup: use mutex_trylock() when grabbing i_mutex of a new cgroup directory Tejun Heo
2012-11-13  3:01   ` Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 15/17] cgroup: update cgroup_create() failure path Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 16/17] cgroup: allow ->post_create() to fail Tejun Heo
2012-11-13  3:01   ` Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` [PATCH 17/17] cgroup: rename ->create/post_create/pre_destroy/destroy() to ->css_alloc/online/offline/free() Tejun Heo
2012-11-13  3:01     ` Tejun Heo
2012-11-13  3:01   ` Tejun Heo
2012-11-19  8:54   ` [PATCHSET cgroup/for-3.8] cgroup: allow ->post_create() to fail Li Zefan
2012-11-19  8:54     ` Li Zefan
     [not found]     ` <50A9F3B3.2010607-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-11-19 16:34       ` Tejun Heo
2012-11-19 16:34         ` Tejun Heo
2012-11-19 16:34       ` Tejun Heo
2012-11-19  8:54   ` Li Zefan
  -- strict thread matches above, loose matches on Subject: below --
2012-11-13  3:01 Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352775704-9023-1-git-send-email-tj@kernel.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.