From: Pawel Moll <pawel.moll@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] video: Versatile Express DVI output driver
Date: Mon, 19 Nov 2012 16:26:16 +0000 [thread overview]
Message-ID: <1353342376.3303.32.camel@hornet> (raw)
In-Reply-To: <201211191543.51923.arnd@arndb.de>
On Mon, 2012-11-19 at 15:43 +0000, Arnd Bergmann wrote:
> * vexpress_dvi_fb_select uses the 'fb' argument as an index into
> the registered_fb array, but does not check for overflow against
> FB_MAX.
Uh, right. Will fix in a second.
> I think you need to use get_fb_info().
I was considering this, but it's a static. And I don't want to change
the fb core, as I'm planning to plug this driver into the "Generic
Panel/Display Framework" [1] that Laurent is working on when it's
available. Then I won't have to hack into the core at all...
[1] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/52565
> * There is no documentation for the newly introduced sysfs interface.
Hm, I didn't want to do that, as it's currently just a debug feature -
there is no class symlink to the device available
(Documentation/ABI/testing/sysfs-devices) so there's no universal way of
describing the path to the device.
I'll do my best and post v4 soon.
Paweł
WARNING: multiple messages have this Message-ID (diff)
From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] video: Versatile Express DVI output driver
Date: Mon, 19 Nov 2012 16:26:16 +0000 [thread overview]
Message-ID: <1353342376.3303.32.camel@hornet> (raw)
In-Reply-To: <201211191543.51923.arnd@arndb.de>
On Mon, 2012-11-19 at 15:43 +0000, Arnd Bergmann wrote:
> * vexpress_dvi_fb_select uses the 'fb' argument as an index into
> the registered_fb array, but does not check for overflow against
> FB_MAX.
Uh, right. Will fix in a second.
> I think you need to use get_fb_info().
I was considering this, but it's a static. And I don't want to change
the fb core, as I'm planning to plug this driver into the "Generic
Panel/Display Framework" [1] that Laurent is working on when it's
available. Then I won't have to hack into the core at all...
[1] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/52565
> * There is no documentation for the newly introduced sysfs interface.
Hm, I didn't want to do that, as it's currently just a debug feature -
there is no class symlink to the device available
(Documentation/ABI/testing/sysfs-devices) so there's no universal way of
describing the path to the device.
I'll do my best and post v4 soon.
Pawe?
next prev parent reply other threads:[~2012-11-19 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 16:30 [PATCH v3] video: Versatile Express DVI output driver Pawel Moll
2012-10-16 16:30 ` Pawel Moll
2012-10-30 15:58 ` Pawel Moll
2012-10-30 15:58 ` Pawel Moll
2012-11-19 13:56 ` Pawel Moll
2012-11-19 13:56 ` Pawel Moll
2012-11-19 15:43 ` Arnd Bergmann
2012-11-19 15:43 ` Arnd Bergmann
2012-11-19 16:26 ` Pawel Moll [this message]
2012-11-19 16:26 ` Pawel Moll
2012-11-19 16:39 ` [PATCH v4] " Pawel Moll
2012-11-19 16:39 ` Pawel Moll
2012-12-12 18:05 ` Pawel Moll
2012-12-12 18:05 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353342376.3303.32.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.