From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] video: Versatile Express DVI output driver
Date: Mon, 19 Nov 2012 15:43:51 +0000 [thread overview]
Message-ID: <201211191543.51923.arnd@arndb.de> (raw)
In-Reply-To: <1353333377.3303.7.camel@hornet>
On Monday 19 November 2012, Pawel Moll wrote:
> I've asked the framebuffer people 3 times about this but got no comment
> whatsoever:
>
> https://patchwork.kernel.org/patch/1473091/
> https://patchwork.kernel.org/patch/1601781/
>
> so I assume there is no problem with merging this code ;-) Therefore,
> would you be so kind to pull this single patch? Without it the 3.8
> kernel will not be able to show anything on VE's display...
Hi Pawel,
I have two comments for the patch that need to be fixed:
* vexpress_dvi_fb_select uses the 'fb' argument as an index into
the registered_fb array, but does not check for overflow against
FB_MAX. I think you need to use get_fb_info().
* There is no documentation for the newly introduced sysfs interface.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] video: Versatile Express DVI output driver
Date: Mon, 19 Nov 2012 15:43:51 +0000 [thread overview]
Message-ID: <201211191543.51923.arnd@arndb.de> (raw)
In-Reply-To: <1353333377.3303.7.camel@hornet>
On Monday 19 November 2012, Pawel Moll wrote:
> I've asked the framebuffer people 3 times about this but got no comment
> whatsoever:
>
> https://patchwork.kernel.org/patch/1473091/
> https://patchwork.kernel.org/patch/1601781/
>
> so I assume there is no problem with merging this code ;-) Therefore,
> would you be so kind to pull this single patch? Without it the 3.8
> kernel will not be able to show anything on VE's display...
Hi Pawel,
I have two comments for the patch that need to be fixed:
* vexpress_dvi_fb_select uses the 'fb' argument as an index into
the registered_fb array, but does not check for overflow against
FB_MAX. I think you need to use get_fb_info().
* There is no documentation for the newly introduced sysfs interface.
Arnd
next prev parent reply other threads:[~2012-11-19 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 16:30 [PATCH v3] video: Versatile Express DVI output driver Pawel Moll
2012-10-16 16:30 ` Pawel Moll
2012-10-30 15:58 ` Pawel Moll
2012-10-30 15:58 ` Pawel Moll
2012-11-19 13:56 ` Pawel Moll
2012-11-19 13:56 ` Pawel Moll
2012-11-19 15:43 ` Arnd Bergmann [this message]
2012-11-19 15:43 ` Arnd Bergmann
2012-11-19 16:26 ` Pawel Moll
2012-11-19 16:26 ` Pawel Moll
2012-11-19 16:39 ` [PATCH v4] " Pawel Moll
2012-11-19 16:39 ` Pawel Moll
2012-12-12 18:05 ` Pawel Moll
2012-12-12 18:05 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211191543.51923.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.