From: Tony Prisk <linux@prisktech.co.nz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
dri-devel@lists.freedesktop.org,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL
Date: Tue, 18 Dec 2012 19:39:15 +0000 [thread overview]
Message-ID: <1355859555.24188.6.camel@gitbox> (raw)
In-Reply-To: <1355857917.24188.3.camel@gitbox>
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote:
> On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
> > I don't care either way, but being different from the documentation
> > is less bad than crashing which is what your patch does. Please
> > be more careful in the future.
> >
> > regards,
> > dan carpenter
>
> Critism accepted.
>
> Given that the driver depends on (PLAT_SAMSUNG || ARCH_MULTIPLATFORM),
> and multiplatform select COMMON_CLK and PLAT_SAMSUNG is selected only by
> ARCH_S3C64XX which has HAVE_CLK I didn't see a problem here.
>
> Your point is still valid and I will sort it out with Mike first.
>
> Regards
> Tony P
Actually, I was wrong here - PLAT_SAMSUNG is selectable via
PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
but all these options (or the options that select them) seem to select a
clock system as well, hence still no reason for a crash.
Regards
Tony P
WARNING: multiple messages have this Message-ID (diff)
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL
Date: Wed, 19 Dec 2012 08:39:15 +1300 [thread overview]
Message-ID: <1355859555.24188.6.camel@gitbox> (raw)
In-Reply-To: <1355857917.24188.3.camel@gitbox>
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote:
> On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
> > I don't care either way, but being different from the documentation
> > is less bad than crashing which is what your patch does. Please
> > be more careful in the future.
> >
> > regards,
> > dan carpenter
>
> Critism accepted.
>
> Given that the driver depends on (PLAT_SAMSUNG || ARCH_MULTIPLATFORM),
> and multiplatform select COMMON_CLK and PLAT_SAMSUNG is selected only by
> ARCH_S3C64XX which has HAVE_CLK I didn't see a problem here.
>
> Your point is still valid and I will sort it out with Mike first.
>
> Regards
> Tony P
Actually, I was wrong here - PLAT_SAMSUNG is selectable via
PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
but all these options (or the options that select them) seem to select a
clock system as well, hence still no reason for a crash.
Regards
Tony P
WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
dri-devel@lists.freedesktop.org,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL
Date: Wed, 19 Dec 2012 08:39:15 +1300 [thread overview]
Message-ID: <1355859555.24188.6.camel@gitbox> (raw)
In-Reply-To: <1355857917.24188.3.camel@gitbox>
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote:
> On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
> > I don't care either way, but being different from the documentation
> > is less bad than crashing which is what your patch does. Please
> > be more careful in the future.
> >
> > regards,
> > dan carpenter
>
> Critism accepted.
>
> Given that the driver depends on (PLAT_SAMSUNG || ARCH_MULTIPLATFORM),
> and multiplatform select COMMON_CLK and PLAT_SAMSUNG is selected only by
> ARCH_S3C64XX which has HAVE_CLK I didn't see a problem here.
>
> Your point is still valid and I will sort it out with Mike first.
>
> Regards
> Tony P
Actually, I was wrong here - PLAT_SAMSUNG is selectable via
PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
but all these options (or the options that select them) seem to select a
clock system as well, hence still no reason for a crash.
Regards
Tony P
next prev parent reply other threads:[~2012-12-18 19:39 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 17:34 [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 1/6] clk: omap: Fix incorrect usage of IS_ERR_OR_NULL Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 2/6] clk: exynos: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 17:34 ` [PATCH RESEND 3/6] " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:52 ` Tony Prisk
2012-12-18 18:52 ` Tony Prisk
2012-12-18 18:52 ` Tony Prisk
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:39 ` Tony Prisk [this message]
2012-12-18 19:39 ` Tony Prisk
2012-12-18 19:39 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 4/6] clk: s5p-tv: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2013-01-01 19:41 ` Sylwester Nawrocki
2013-01-01 19:41 ` Sylwester Nawrocki
2013-01-01 19:41 ` Sylwester Nawrocki
2012-12-18 17:34 ` [PATCH RESEND 5/6] clk: s5p-fimc: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 6/6] clk: s5p-g2d: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-22 21:53 ` Sergei Shtylyov
2012-12-22 21:53 ` Sergei Shtylyov
2012-12-22 21:53 ` Sergei Shtylyov
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:31 ` Tony Prisk
2013-01-02 5:31 ` Tony Prisk
2013-01-02 5:31 ` Tony Prisk
2013-01-02 7:29 ` Julia Lawall
2013-01-02 7:29 ` Julia Lawall
2013-01-02 7:29 ` Julia Lawall
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:14 ` Julia Lawall
2013-01-03 9:14 ` Julia Lawall
2013-01-03 9:14 ` Julia Lawall
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 11:10 ` Dan Carpenter
2013-01-03 11:10 ` Dan Carpenter
2013-01-03 11:10 ` Dan Carpenter
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:44 ` Julia Lawall
2013-01-02 9:44 ` Julia Lawall
2013-01-02 9:44 ` Julia Lawall
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 23:14 ` Sylwester Nawrocki
2013-01-02 23:14 ` Sylwester Nawrocki
2013-01-02 23:14 ` Sylwester Nawrocki
2012-12-18 18:42 ` [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Dan Carpenter
2012-12-18 18:42 ` Dan Carpenter
2012-12-18 18:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355859555.24188.6.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.