From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL
Date: Thu, 03 Jan 2013 11:10:40 +0000 [thread overview]
Message-ID: <20130103111040.GD7247@mwanda> (raw)
In-Reply-To: <20130103100000.GJ2631@n2100.arm.linux.org.uk>
Come on... Don't say we haven't read comment. Obviously, the first
thing we did was read that comment. I've read it many times at this
point and I still think we should add in a bit which says:
"NOTE: Drivers should treat the return value as an opaque cookie
and not dereference it. NULL returns don't imply an error so don't
use IS_ERR_OR_NULL() to check for errors."
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL
Date: Thu, 3 Jan 2013 14:10:40 +0300 [thread overview]
Message-ID: <20130103111040.GD7247@mwanda> (raw)
In-Reply-To: <20130103100000.GJ2631@n2100.arm.linux.org.uk>
Come on... Don't say we haven't read comment. Obviously, the first
thing we did was read that comment. I've read it many times at this
point and I still think we should add in a bit which says:
"NOTE: Drivers should treat the return value as an opaque cookie
and not dereference it. NULL returns don't imply an error so don't
use IS_ERR_OR_NULL() to check for errors."
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Tony Prisk <linux@prisktech.co.nz>,
Tomasz Stanislawski <t.stanislaws@samsung.com>,
Dan Carpenter <error27@gmail.com>,
Sergei Shtylyov <sshtylyov@mvista.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL
Date: Thu, 3 Jan 2013 14:10:40 +0300 [thread overview]
Message-ID: <20130103111040.GD7247@mwanda> (raw)
In-Reply-To: <20130103100000.GJ2631@n2100.arm.linux.org.uk>
Come on... Don't say we haven't read comment. Obviously, the first
thing we did was read that comment. I've read it many times at this
point and I still think we should add in a bit which says:
"NOTE: Drivers should treat the return value as an opaque cookie
and not dereference it. NULL returns don't imply an error so don't
use IS_ERR_OR_NULL() to check for errors."
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-03 11:10 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 17:34 [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 1/6] clk: omap: Fix incorrect usage of IS_ERR_OR_NULL Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 2/6] clk: exynos: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 18:48 ` Dan Carpenter
2012-12-18 17:34 ` [PATCH RESEND 3/6] " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:39 ` Dan Carpenter
2012-12-18 18:52 ` Tony Prisk
2012-12-18 18:52 ` Tony Prisk
2012-12-18 18:52 ` Tony Prisk
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:03 ` Dan Carpenter
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:11 ` Tony Prisk
2012-12-18 19:39 ` Tony Prisk
2012-12-18 19:39 ` Tony Prisk
2012-12-18 19:39 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 4/6] clk: s5p-tv: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2013-01-01 19:41 ` Sylwester Nawrocki
2013-01-01 19:41 ` Sylwester Nawrocki
2013-01-01 19:41 ` Sylwester Nawrocki
2012-12-18 17:34 ` [PATCH RESEND 5/6] clk: s5p-fimc: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 6/6] clk: s5p-g2d: " Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-18 17:34 ` Tony Prisk
2012-12-22 21:53 ` Sergei Shtylyov
2012-12-22 21:53 ` Sergei Shtylyov
2012-12-22 21:53 ` Sergei Shtylyov
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-01 18:33 ` Sylwester Nawrocki
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:10 ` Dan Carpenter
2013-01-02 5:31 ` Tony Prisk
2013-01-02 5:31 ` Tony Prisk
2013-01-02 5:31 ` Tony Prisk
2013-01-02 7:29 ` Julia Lawall
2013-01-02 7:29 ` Julia Lawall
2013-01-02 7:29 ` Julia Lawall
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-02 9:28 ` Russell King - ARM Linux
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:05 ` Dan Carpenter
2013-01-03 9:14 ` Julia Lawall
2013-01-03 9:14 ` Julia Lawall
2013-01-03 9:14 ` Julia Lawall
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 10:00 ` Russell King - ARM Linux
2013-01-03 11:10 ` Dan Carpenter [this message]
2013-01-03 11:10 ` Dan Carpenter
2013-01-03 11:10 ` Dan Carpenter
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 11:21 ` Russell King - ARM Linux
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:45 ` Dan Carpenter
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-03 13:52 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:26 ` Russell King - ARM Linux
2013-01-02 9:44 ` Julia Lawall
2013-01-02 9:44 ` Julia Lawall
2013-01-02 9:44 ` Julia Lawall
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 10:15 ` Russell King - ARM Linux
2013-01-02 23:14 ` Sylwester Nawrocki
2013-01-02 23:14 ` Sylwester Nawrocki
2013-01-02 23:14 ` Sylwester Nawrocki
2012-12-18 18:42 ` [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Dan Carpenter
2012-12-18 18:42 ` Dan Carpenter
2012-12-18 18:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103111040.GD7247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.