* [PATCH] connman: fixed init script, so it can run with nfs
[not found] <1349809566-7013-1-git-send-email-ftonello@cercacor.com>
@ 2012-10-10 16:24 ` Felipe Ferreri Tonello
0 siblings, 0 replies; 11+ messages in thread
From: Felipe Ferreri Tonello @ 2012-10-10 16:24 UTC (permalink / raw)
To: poky
From: "Felipe F. Tonello" <ftonello@cercacor.com>
Adding -I to the arguments, connmand will ignore the eth interface, so
if you are
using nfs it will not be disconnected.
FIXME: it might not work if using more than one eth interface. But it's
better
than not using connman with nfs at all.
Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
meta/recipes-connectivity/connman/connman/connman | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-connectivity/connman/connman/connman
b/meta/recipes-connectivity/connman/connman/connman
index 4a0017f..e90925e 100644
--- a/meta/recipes-connectivity/connman/connman/connman
+++ b/meta/recipes-connectivity/connman/connman/connman
@@ -26,11 +26,14 @@ while read dev mtpt fstype rest; do
fi
done
+ethn=`ifconfig | grep eth | sed -e "s/\(eth[0-9]\)\(.*\)/\1/"`
+
do_start() {
EXTRA_PARAM=""
- if test $nfsroot -eq 0 ; then
- $DAEMON $EXTRA_PARAM
+ if test $nfsroot -eq 1 ; then
+ EXTRA_PARAM="-I $ethn"
fi
+ $DAEMON $EXTRA_PARAM
}
do_stop() {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] connman: fixed init script, so it can run with nfs
@ 2013-01-09 0:37 eu
2013-01-09 10:12 ` Iorga, Cristian
0 siblings, 1 reply; 11+ messages in thread
From: eu @ 2013-01-09 0:37 UTC (permalink / raw)
To: poky; +Cc: Felipe F. Tonello
From: "Felipe F. Tonello" <ftonello@cercacor.com>
Adding -I to the arguments, connmand will ignore the eth interface, so if you are
using nfs it will not be disconnected.
FIXME: it might not work if using more than one eth interface. But it's better
than not using connman with nfs at all.
Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
meta/recipes-connectivity/connman/connman/connman | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-connectivity/connman/connman/connman b/meta/recipes-connectivity/connman/connman/connman
index 4a0017f..e90925e 100644
--- a/meta/recipes-connectivity/connman/connman/connman
+++ b/meta/recipes-connectivity/connman/connman/connman
@@ -26,11 +26,14 @@ while read dev mtpt fstype rest; do
fi
done
+ethn=`ifconfig | grep eth | sed -e "s/\(eth[0-9]\)\(.*\)/\1/"`
+
do_start() {
EXTRA_PARAM=""
- if test $nfsroot -eq 0 ; then
- $DAEMON $EXTRA_PARAM
+ if test $nfsroot -eq 1 ; then
+ EXTRA_PARAM="-I $ethn"
fi
+ $DAEMON $EXTRA_PARAM
}
do_stop() {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-09 0:37 [PATCH] connman: fixed init script, so it can run with nfs eu
@ 2013-01-09 10:12 ` Iorga, Cristian
2013-01-09 13:03 ` Richard Purdie
2013-01-09 18:15 ` Felipe Ferreri Tonello
0 siblings, 2 replies; 11+ messages in thread
From: Iorga, Cristian @ 2013-01-09 10:12 UTC (permalink / raw)
To: eu@felipetonello.com, poky@yoctoproject.org; +Cc: Felipe F. Tonello
Hello Felipe,
I have some questions regarding this patch:
1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
2. In what way is connman affecting nfs? In other words, what is the root cause?
3. Which version of connman are you using?
I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
Regards,
Cristian Iorga
-----Original Message-----
From: poky-bounces@yoctoproject.org [mailto:poky-bounces@yoctoproject.org] On Behalf Of eu@felipetonello.com
Sent: Wednesday, January 09, 2013 2:37 AM
To: poky@yoctoproject.org
Cc: Felipe F. Tonello
Subject: [poky] [PATCH] connman: fixed init script, so it can run with nfs
From: "Felipe F. Tonello" <ftonello@cercacor.com>
Adding -I to the arguments, connmand will ignore the eth interface, so if you are using nfs it will not be disconnected.
FIXME: it might not work if using more than one eth interface. But it's better than not using connman with nfs at all.
Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
meta/recipes-connectivity/connman/connman/connman | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-connectivity/connman/connman/connman b/meta/recipes-connectivity/connman/connman/connman
index 4a0017f..e90925e 100644
--- a/meta/recipes-connectivity/connman/connman/connman
+++ b/meta/recipes-connectivity/connman/connman/connman
@@ -26,11 +26,14 @@ while read dev mtpt fstype rest; do
fi
done
+ethn=`ifconfig | grep eth | sed -e "s/\(eth[0-9]\)\(.*\)/\1/"`
+
do_start() {
EXTRA_PARAM=""
- if test $nfsroot -eq 0 ; then
- $DAEMON $EXTRA_PARAM
+ if test $nfsroot -eq 1 ; then
+ EXTRA_PARAM="-I $ethn"
fi
+ $DAEMON $EXTRA_PARAM
}
do_stop() {
--
1.7.9.5
_______________________________________________
poky mailing list
poky@yoctoproject.org
https://lists.yoctoproject.org/listinfo/poky
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-09 10:12 ` Iorga, Cristian
@ 2013-01-09 13:03 ` Richard Purdie
2013-01-09 18:14 ` Felipe Ferreri Tonello
2013-01-10 19:23 ` Felipe Ferreri Tonello
2013-01-09 18:15 ` Felipe Ferreri Tonello
1 sibling, 2 replies; 11+ messages in thread
From: Richard Purdie @ 2013-01-09 13:03 UTC (permalink / raw)
To: Iorga, Cristian; +Cc: Felipe F. Tonello, poky@yoctoproject.org
On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
> Hello Felipe,
>
> I have some questions regarding this patch:
>
> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
> 2. In what way is connman affecting nfs? In other words, what is the root cause?
> 3. Which version of connman are you using?
>
> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
I'd also add that:
a) Patches to this part of the tree need to go to the OE-Core mailing list
b) Unconditionally running the expression is inefficient, it should move
inside the if statement as it triggers a number of exec calls. This may
sound trivial but that all mount up.
Cheers,
Richard
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-09 13:03 ` Richard Purdie
@ 2013-01-09 18:14 ` Felipe Ferreri Tonello
2013-01-10 19:23 ` Felipe Ferreri Tonello
1 sibling, 0 replies; 11+ messages in thread
From: Felipe Ferreri Tonello @ 2013-01-09 18:14 UTC (permalink / raw)
To: Richard Purdie; +Cc: Felipe F. Tonello, poky@yoctoproject.org
Hi Richard,
On 01/09/2013 05:03 AM, Richard Purdie wrote:
> On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
>> Hello Felipe,
>>
>> I have some questions regarding this patch:
>>
>> 1. On which hardware/machine have you tested this patch? (real
hardware, qemu machine, etc)
>> 2. In what way is connman affecting nfs? In other words, what is the
root cause?
>> 3. Which version of connman are you using?
>>
>> I am asking these questions because I am working on something
somehow related, and I think a more general fix might be needed.
>
> I'd also add that:
>
> a) Patches to this part of the tree need to go to the OE-Core mailing
list
Ok.
> b) Unconditionally running the expression is inefficient, it should move
> inside the if statement as it triggers a number of exec calls. This may
> sound trivial but that all mount up.
I agree. I will fix that before sending to OE-Core.
Felipe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-09 10:12 ` Iorga, Cristian
2013-01-09 13:03 ` Richard Purdie
@ 2013-01-09 18:15 ` Felipe Ferreri Tonello
2013-01-10 7:33 ` Iorga, Cristian
1 sibling, 1 reply; 11+ messages in thread
From: Felipe Ferreri Tonello @ 2013-01-09 18:15 UTC (permalink / raw)
To: Iorga, Cristian; +Cc: Felipe F. Tonello, poky@yoctoproject.org
Hi Iorga,
On 01/09/2013 02:12 AM, Iorga, Cristian wrote:
> Hello Felipe,
>
> I have some questions regarding this patch:
>
> 1. On which hardware/machine have you tested this patch? (real
hardware, qemu machine, etc)
Real hardware.
> 2. In what way is connman affecting nfs? In other words, what is the
root cause?
When connman tried to take ownership of eth, it crashes the nfs, that is
hosting rootfs for instance, connection.
> 3. Which version of connman are you using?
I'm using 1.9 but I tested this patch on 1.6 as well.
>
> I am asking these questions because I am working on something somehow
related, and I think a more general fix might be needed.
I agree, this is not a generic patch. But it works on most of the times.
Also I think it's better then just disabling ConnMan with nfs.
Felipe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-09 18:15 ` Felipe Ferreri Tonello
@ 2013-01-10 7:33 ` Iorga, Cristian
0 siblings, 0 replies; 11+ messages in thread
From: Iorga, Cristian @ 2013-01-10 7:33 UTC (permalink / raw)
To: Felipe Ferreri Tonello; +Cc: Felipe F. Tonello, poky@yoctoproject.org
Hello Felipe,
My first name is Cristian.
I have reviewed your patch and it does look OK in regard to functionality.
Regards,
Cristian
-----Original Message-----
From: Felipe Ferreri Tonello [mailto:eu@felipetonello.com]
Sent: Wednesday, January 09, 2013 8:15 PM
To: Iorga, Cristian
Cc: poky@yoctoproject.org; Felipe F. Tonello
Subject: Re: [poky] [PATCH] connman: fixed init script, so it can run with nfs
Hi Iorga,
On 01/09/2013 02:12 AM, Iorga, Cristian wrote:
> Hello Felipe,
>
> I have some questions regarding this patch:
>
> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc) Real hardware.
> 2. In what way is connman affecting nfs? In other words, what is the root cause?
When connman tried to take ownership of eth, it crashes the nfs, that is hosting rootfs for instance, connection.
> 3. Which version of connman are you using?
I'm using 1.9 but I tested this patch on 1.6 as well.
>
> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
I agree, this is not a generic patch. But it works on most of the times.
Also I think it's better then just disabling ConnMan with nfs.
Felipe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-09 13:03 ` Richard Purdie
2013-01-09 18:14 ` Felipe Ferreri Tonello
@ 2013-01-10 19:23 ` Felipe Ferreri Tonello
2013-01-10 23:57 ` Richard Purdie
1 sibling, 1 reply; 11+ messages in thread
From: Felipe Ferreri Tonello @ 2013-01-10 19:23 UTC (permalink / raw)
To: Richard Purdie; +Cc: poky@yoctoproject.org
Richard and Cristian,
On 01/09/2013 05:03 AM, Richard Purdie wrote:
> On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
>> Hello Felipe,
>>
>> I have some questions regarding this patch:
>>
>> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
>> 2. In what way is connman affecting nfs? In other words, what is the root cause?
>> 3. Which version of connman are you using?
>>
>> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
>
> I'd also add that:
>
> a) Patches to this part of the tree need to go to the OE-Core mailing list
I saw on openembedded tree that connman recipes are old. They are not
the same as in poky.
I'm always confused about this. Where is oe-core that poky and oe share?
Felipe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-10 19:23 ` Felipe Ferreri Tonello
@ 2013-01-10 23:57 ` Richard Purdie
2013-01-11 1:17 ` Felipe Ferreri Tonello
0 siblings, 1 reply; 11+ messages in thread
From: Richard Purdie @ 2013-01-10 23:57 UTC (permalink / raw)
To: Felipe Ferreri Tonello; +Cc: poky@yoctoproject.org
On Thu, 2013-01-10 at 11:23 -0800, Felipe Ferreri Tonello wrote:
> Richard and Cristian,
>
> On 01/09/2013 05:03 AM, Richard Purdie wrote:
> > On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
> >> Hello Felipe,
> >>
> >> I have some questions regarding this patch:
> >>
> >> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
> >> 2. In what way is connman affecting nfs? In other words, what is the root cause?
> >> 3. Which version of connman are you using?
> >>
> >> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
> >
> > I'd also add that:
> >
> > a) Patches to this part of the tree need to go to the OE-Core mailing list
>
> I saw on openembedded tree that connman recipes are old. They are not
> the same as in poky.
>
> I'm always confused about this. Where is oe-core that poky and oe share?
These two repositories should be in sync in terms of file level content
of the meta directory:
http://cgit.openembedded.org/openembedded-core/log/
http://git.yoctoproject.org/cgit/cgit.cgi/poky/log/
Were you looking at openembedded or openembedded-core?
Cheers,
Richard
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-10 23:57 ` Richard Purdie
@ 2013-01-11 1:17 ` Felipe Ferreri Tonello
2013-01-11 16:13 ` Richard Purdie
0 siblings, 1 reply; 11+ messages in thread
From: Felipe Ferreri Tonello @ 2013-01-11 1:17 UTC (permalink / raw)
To: Richard Purdie; +Cc: poky@yoctoproject.org
Hi Richard,
On 01/10/2013 03:57 PM, Richard Purdie wrote:
> On Thu, 2013-01-10 at 11:23 -0800, Felipe Ferreri Tonello wrote:
>> Richard and Cristian,
>>
>> On 01/09/2013 05:03 AM, Richard Purdie wrote:
>>> On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
>>>> Hello Felipe,
>>>>
>>>> I have some questions regarding this patch:
>>>>
>>>> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
>>>> 2. In what way is connman affecting nfs? In other words, what is the root cause?
>>>> 3. Which version of connman are you using?
>>>>
>>>> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
>>>
>>> I'd also add that:
>>>
>>> a) Patches to this part of the tree need to go to the OE-Core mailing list
>>
>> I saw on openembedded tree that connman recipes are old. They are not
>> the same as in poky.
>>
>> I'm always confused about this. Where is oe-core that poky and oe share?
>
> These two repositories should be in sync in terms of file level content
> of the meta directory:
>
> http://cgit.openembedded.org/openembedded-core/log/
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/log/
>
> Were you looking at openembedded or openembedded-core?
I was looking into openembedded, now I got it.
btw, What's the difference between them? openembedded tree is the
meta-oe? and openembedded-core ie oe-core?
Thanks,
Felipe
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] connman: fixed init script, so it can run with nfs
2013-01-11 1:17 ` Felipe Ferreri Tonello
@ 2013-01-11 16:13 ` Richard Purdie
0 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2013-01-11 16:13 UTC (permalink / raw)
To: Felipe Ferreri Tonello; +Cc: poky@yoctoproject.org
On Thu, 2013-01-10 at 17:17 -0800, Felipe Ferreri Tonello wrote:
> Hi Richard,
>
> On 01/10/2013 03:57 PM, Richard Purdie wrote:
> > On Thu, 2013-01-10 at 11:23 -0800, Felipe Ferreri Tonello wrote:
> >> Richard and Cristian,
> >>
> >> On 01/09/2013 05:03 AM, Richard Purdie wrote:
> >>> On Wed, 2013-01-09 at 10:12 +0000, Iorga, Cristian wrote:
> >>>> Hello Felipe,
> >>>>
> >>>> I have some questions regarding this patch:
> >>>>
> >>>> 1. On which hardware/machine have you tested this patch? (real hardware, qemu machine, etc)
> >>>> 2. In what way is connman affecting nfs? In other words, what is the root cause?
> >>>> 3. Which version of connman are you using?
> >>>>
> >>>> I am asking these questions because I am working on something somehow related, and I think a more general fix might be needed.
> >>>
> >>> I'd also add that:
> >>>
> >>> a) Patches to this part of the tree need to go to the OE-Core mailing list
> >>
> >> I saw on openembedded tree that connman recipes are old. They are not
> >> the same as in poky.
> >>
> >> I'm always confused about this. Where is oe-core that poky and oe share?
> >
> > These two repositories should be in sync in terms of file level content
> > of the meta directory:
> >
> > http://cgit.openembedded.org/openembedded-core/log/
> >
> > http://git.yoctoproject.org/cgit/cgit.cgi/poky/log/
> >
> > Were you looking at openembedded or openembedded-core?
>
> I was looking into openembedded, now I got it.
>
> btw, What's the difference between them? openembedded tree is the
> meta-oe? and openembedded-core ie oe-core?
openembedded is OE-Classic, i.e. from before it got split into various
pieces such as oe-core and meta-oe.
Cheers,
Richard
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-01-11 16:13 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-09 0:37 [PATCH] connman: fixed init script, so it can run with nfs eu
2013-01-09 10:12 ` Iorga, Cristian
2013-01-09 13:03 ` Richard Purdie
2013-01-09 18:14 ` Felipe Ferreri Tonello
2013-01-10 19:23 ` Felipe Ferreri Tonello
2013-01-10 23:57 ` Richard Purdie
2013-01-11 1:17 ` Felipe Ferreri Tonello
2013-01-11 16:13 ` Richard Purdie
2013-01-09 18:15 ` Felipe Ferreri Tonello
2013-01-10 7:33 ` Iorga, Cristian
[not found] <1349809566-7013-1-git-send-email-ftonello@cercacor.com>
2012-10-10 16:24 ` Felipe Ferreri Tonello
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.