From: Emil Goode <emilgoode@gmail.com>
To: Antonio Quartulli <ordex@autistici.org>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
siwu@hrz.tu-chemnitz.de, lindner_marek@yahoo.de,
davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable
Date: Wed, 06 Feb 2013 18:55:53 +0100 [thread overview]
Message-ID: <1360173353.22154.4.camel@debian> (raw)
In-Reply-To: <20130206172234.GB6008@ritirata.org>
Hi Antonio,
The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.
Best regards, Emil
On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> Hi Emil,
>
> On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > The commit ed242d01 removed a node parameter from iterators.
> > This patch removes a hlist_node struct that is no longer used.
> >
> > Sparse gives a warning:
> >
> > net/batman-adv/originator.c:411:21: warning:
> > unused variable ‘node_tmp’ [-Wunused-variable]
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> On which tree did you base your patch?
> I cannot find the commit you are referring to (ed242d01) and the patch does not
> apply (neither on net nor net-next).
>
> Other than that the variable is used a couple of lines below (in the code we
> have)...
>
> Regards,
>
WARNING: multiple messages have this Message-ID (diff)
From: Emil Goode <emilgoode@gmail.com>
To: Antonio Quartulli <ordex@autistici.org>
Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de,
davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] batman-adv: Remove unused variable
Date: Wed, 06 Feb 2013 17:55:53 +0000 [thread overview]
Message-ID: <1360173353.22154.4.camel@debian> (raw)
In-Reply-To: <20130206172234.GB6008@ritirata.org>
Hi Antonio,
The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.
Best regards, Emil
On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> Hi Emil,
>
> On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > The commit ed242d01 removed a node parameter from iterators.
> > This patch removes a hlist_node struct that is no longer used.
> >
> > Sparse gives a warning:
> >
> > net/batman-adv/originator.c:411:21: warning:
> > unused variable ‘node_tmp’ [-Wunused-variable]
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> On which tree did you base your patch?
> I cannot find the commit you are referring to (ed242d01) and the patch does not
> apply (neither on net nor net-next).
>
> Other than that the variable is used a couple of lines below (in the code we
> have)...
>
> Regards,
>
WARNING: multiple messages have this Message-ID (diff)
From: Emil Goode <emilgoode@gmail.com>
To: Antonio Quartulli <ordex@autistici.org>
Cc: lindner_marek@yahoo.de, siwu@hrz.tu-chemnitz.de,
davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] batman-adv: Remove unused variable
Date: Wed, 06 Feb 2013 18:55:53 +0100 [thread overview]
Message-ID: <1360173353.22154.4.camel@debian> (raw)
In-Reply-To: <20130206172234.GB6008@ritirata.org>
Hi Antonio,
The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.
Best regards, Emil
On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> Hi Emil,
>
> On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > The commit ed242d01 removed a node parameter from iterators.
> > This patch removes a hlist_node struct that is no longer used.
> >
> > Sparse gives a warning:
> >
> > net/batman-adv/originator.c:411:21: warning:
> > unused variable ‘node_tmp’ [-Wunused-variable]
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> On which tree did you base your patch?
> I cannot find the commit you are referring to (ed242d01) and the patch does not
> apply (neither on net nor net-next).
>
> Other than that the variable is used a couple of lines below (in the code we
> have)...
>
> Regards,
>
next prev parent reply other threads:[~2013-02-06 17:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 16:37 [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unused variable Emil Goode
2013-02-06 16:37 ` Emil Goode
2013-02-06 16:37 ` Emil Goode
2013-02-06 17:22 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-02-06 17:22 ` Antonio Quartulli
2013-02-06 17:22 ` Antonio Quartulli
2013-02-06 17:55 ` Emil Goode [this message]
2013-02-06 17:55 ` Emil Goode
2013-02-06 17:55 ` Emil Goode
2013-02-06 19:55 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-02-06 19:55 ` Antonio Quartulli
2013-02-06 19:55 ` Antonio Quartulli
2013-02-06 21:59 ` [B.A.T.M.A.N.] " Emil Goode
2013-02-06 21:59 ` Emil Goode
2013-02-06 21:59 ` Emil Goode
2013-02-06 21:59 ` Emil Goode
2013-02-06 22:10 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-02-06 22:10 ` Antonio Quartulli
2013-02-06 22:10 ` Antonio Quartulli
2013-02-06 22:23 ` [B.A.T.M.A.N.] " Dan Carpenter
2013-02-06 22:23 ` Dan Carpenter
2013-02-06 22:23 ` Dan Carpenter
2013-02-06 22:23 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2012-02-27 12:36 [B.A.T.M.A.N.] [PATCH] batman-adv: remove " Antonio Quartulli
2012-02-28 5:50 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360173353.22154.4.camel@debian \
--to=emilgoode@gmail.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lindner_marek@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ordex@autistici.org \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.