From: Emil Goode <emilgoode@gmail.com>
To: ptyser@xes-inc.com, sameo@linux.intel.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Emil Goode <emilgoode@gmail.com>
Subject: [PATCH] mfd: lpc_ich: Fix arguments to kmalloc
Date: Wed, 06 Feb 2013 17:59:12 +0000 [thread overview]
Message-ID: <1360173659-22409-1-git-send-email-emilgoode@gmail.com> (raw)
This patch changes the order of the arguments to kmalloc,
the allocation flag should be the second argument.
Sparse warnings:
drivers/mfd/lpc_ich.c:881:24: warning:
incorrect type in argument 1 (different base types)
drivers/mfd/lpc_ich.c:881:24:
expected unsigned long [unsigned] [usertype] size
drivers/mfd/lpc_ich.c:881:24: got restricted gfp_t
drivers/mfd/lpc_ich.c:881:36: warning:
incorrect type in argument 2 (different base types)
drivers/mfd/lpc_ich.c:881:36:
expected restricted gfp_t [usertype] flags
drivers/mfd/lpc_ich.c:881:36: got unsigned long
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/mfd/lpc_ich.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index a0cfdf9..3af8590 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -878,7 +878,7 @@ static int lpc_ich_probe(struct pci_dev *dev,
int ret;
bool cell_added = false;
- priv = kmalloc(GFP_KERNEL, sizeof(struct lpc_ich_priv));
+ priv = kmalloc(sizeof(struct lpc_ich_priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Emil Goode <emilgoode@gmail.com>
To: ptyser@xes-inc.com, sameo@linux.intel.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Emil Goode <emilgoode@gmail.com>
Subject: [PATCH] mfd: lpc_ich: Fix arguments to kmalloc
Date: Wed, 6 Feb 2013 19:00:59 +0100 [thread overview]
Message-ID: <1360173659-22409-1-git-send-email-emilgoode@gmail.com> (raw)
This patch changes the order of the arguments to kmalloc,
the allocation flag should be the second argument.
Sparse warnings:
drivers/mfd/lpc_ich.c:881:24: warning:
incorrect type in argument 1 (different base types)
drivers/mfd/lpc_ich.c:881:24:
expected unsigned long [unsigned] [usertype] size
drivers/mfd/lpc_ich.c:881:24: got restricted gfp_t
drivers/mfd/lpc_ich.c:881:36: warning:
incorrect type in argument 2 (different base types)
drivers/mfd/lpc_ich.c:881:36:
expected restricted gfp_t [usertype] flags
drivers/mfd/lpc_ich.c:881:36: got unsigned long
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/mfd/lpc_ich.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index a0cfdf9..3af8590 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -878,7 +878,7 @@ static int lpc_ich_probe(struct pci_dev *dev,
int ret;
bool cell_added = false;
- priv = kmalloc(GFP_KERNEL, sizeof(struct lpc_ich_priv));
+ priv = kmalloc(sizeof(struct lpc_ich_priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
1.7.10.4
next reply other threads:[~2013-02-06 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 17:59 Emil Goode [this message]
2013-02-06 18:00 ` [PATCH] mfd: lpc_ich: Fix arguments to kmalloc Emil Goode
2013-02-06 18:17 ` Samuel Ortiz
2013-02-06 18:17 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360173659-22409-1-git-send-email-emilgoode@gmail.com \
--to=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.