From: Samuel Ortiz <sameo@linux.intel.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: ptyser@xes-inc.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mfd: lpc_ich: Fix arguments to kmalloc
Date: Wed, 06 Feb 2013 18:17:52 +0000 [thread overview]
Message-ID: <20130206181752.GD3418@sortiz-mobl> (raw)
In-Reply-To: <1360173659-22409-1-git-send-email-emilgoode@gmail.com>
HI Emil,
On Wed, Feb 06, 2013 at 07:00:59PM +0100, Emil Goode wrote:
> This patch changes the order of the arguments to kmalloc,
> the allocation flag should be the second argument.
>
> Sparse warnings:
>
> drivers/mfd/lpc_ich.c:881:24: warning:
> incorrect type in argument 1 (different base types)
> drivers/mfd/lpc_ich.c:881:24:
> expected unsigned long [unsigned] [usertype] size
> drivers/mfd/lpc_ich.c:881:24: got restricted gfp_t
>
> drivers/mfd/lpc_ich.c:881:36: warning:
> incorrect type in argument 2 (different base types)
> drivers/mfd/lpc_ich.c:881:36:
> expected restricted gfp_t [usertype] flags
> drivers/mfd/lpc_ich.c:881:36: got unsigned long
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
> drivers/mfd/lpc_ich.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch does not apply to my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo@linux.intel.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: ptyser@xes-inc.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mfd: lpc_ich: Fix arguments to kmalloc
Date: Wed, 6 Feb 2013 19:17:52 +0100 [thread overview]
Message-ID: <20130206181752.GD3418@sortiz-mobl> (raw)
In-Reply-To: <1360173659-22409-1-git-send-email-emilgoode@gmail.com>
HI Emil,
On Wed, Feb 06, 2013 at 07:00:59PM +0100, Emil Goode wrote:
> This patch changes the order of the arguments to kmalloc,
> the allocation flag should be the second argument.
>
> Sparse warnings:
>
> drivers/mfd/lpc_ich.c:881:24: warning:
> incorrect type in argument 1 (different base types)
> drivers/mfd/lpc_ich.c:881:24:
> expected unsigned long [unsigned] [usertype] size
> drivers/mfd/lpc_ich.c:881:24: got restricted gfp_t
>
> drivers/mfd/lpc_ich.c:881:36: warning:
> incorrect type in argument 2 (different base types)
> drivers/mfd/lpc_ich.c:881:36:
> expected restricted gfp_t [usertype] flags
> drivers/mfd/lpc_ich.c:881:36: got unsigned long
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
> drivers/mfd/lpc_ich.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch does not apply to my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2013-02-06 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 17:59 [PATCH] mfd: lpc_ich: Fix arguments to kmalloc Emil Goode
2013-02-06 18:00 ` Emil Goode
2013-02-06 18:17 ` Samuel Ortiz [this message]
2013-02-06 18:17 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206181752.GD3418@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.