From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM
Date: Wed, 27 Mar 2013 18:28:00 +1300 [thread overview]
Message-ID: <1364362080-8489-1-git-send-email-linux@prisktech.co.nz> (raw)
Compiling with !CONFIG_PM generates an unused function warning on
unlink_empty_async_suspended().
Enclose the function in a #ifdef CONFIG_PM
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2:
Tidy up blank line as requested by Alan Stern
drivers/usb/host/ehci-q.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 23d1369..1ea4de1 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -1316,6 +1316,7 @@ static void unlink_empty_async(struct ehci_hcd *ehci)
}
}
+#ifdef CONFIG_PM
/* The root hub is suspended; unlink all the async QHs */
static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
{
@@ -1328,6 +1329,7 @@ static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
}
start_iaa_cycle(ehci, false);
}
+#endif
/* makes sure the async qh will become idle */
/* caller must own ehci->lock */
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
Tony Prisk <linux@prisktech.co.nz>
Subject: [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM
Date: Wed, 27 Mar 2013 18:28:00 +1300 [thread overview]
Message-ID: <1364362080-8489-1-git-send-email-linux@prisktech.co.nz> (raw)
Compiling with !CONFIG_PM generates an unused function warning on
unlink_empty_async_suspended().
Enclose the function in a #ifdef CONFIG_PM
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
v2:
Tidy up blank line as requested by Alan Stern
drivers/usb/host/ehci-q.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c
index 23d1369..1ea4de1 100644
--- a/drivers/usb/host/ehci-q.c
+++ b/drivers/usb/host/ehci-q.c
@@ -1316,6 +1316,7 @@ static void unlink_empty_async(struct ehci_hcd *ehci)
}
}
+#ifdef CONFIG_PM
/* The root hub is suspended; unlink all the async QHs */
static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
{
@@ -1328,6 +1329,7 @@ static void unlink_empty_async_suspended(struct ehci_hcd *ehci)
}
start_iaa_cycle(ehci, false);
}
+#endif
/* makes sure the async qh will become idle */
/* caller must own ehci->lock */
--
1.7.9.5
next reply other threads:[~2013-03-27 5:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 5:28 Tony Prisk [this message]
2013-03-27 5:28 ` [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM Tony Prisk
2013-03-28 21:09 ` [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused Arnd Bergmann
2013-03-28 21:09 ` Arnd Bergmann
2013-03-28 21:16 ` Arnd Bergmann
2013-03-28 21:16 ` Arnd Bergmann
2013-03-28 21:20 ` Tony Prisk
2013-03-28 21:20 ` Tony Prisk
2013-03-29 14:05 ` Alan Stern
2013-03-29 14:05 ` Alan Stern
2013-03-29 14:05 ` Alan Stern
2013-03-29 14:05 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2013-03-26 18:14 [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM Tony Prisk
2013-03-26 18:14 ` Tony Prisk
2013-03-26 18:45 ` Alan Stern
2013-03-26 18:45 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364362080-8489-1-git-send-email-linux@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.