All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused
Date: Fri, 29 Mar 2013 10:20:54 +1300	[thread overview]
Message-ID: <5154B436.5080700@prisktech.co.nz> (raw)
In-Reply-To: <201303282116.21727.arnd@arndb.de>

On 29/03/13 10:16, Arnd Bergmann wrote:
> On Thursday 28 March 2013, Arnd Bergmann wrote:
>> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used
>> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function
>> inside of an #ifdef to work around an unused function warning.
> Hi Greg,
>
> Apparently the warning is now also in 3.8.5, so you might want to backport
> this fix as well after you send it upstream.
>
> 	Arnd
Grr, my bad - I originally wrote the patch with the forward decl 
#ifdef'd as well, but Alan pointed out that it didn't need to be. I 
thought I recompiled it after the change, but obviously not.

Thanks Arnd,

Regards
Tony P

WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux@prisktech.co.nz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stern@rowland.harvard.edu
Subject: Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused
Date: Fri, 29 Mar 2013 10:20:54 +1300	[thread overview]
Message-ID: <5154B436.5080700@prisktech.co.nz> (raw)
In-Reply-To: <201303282116.21727.arnd@arndb.de>

On 29/03/13 10:16, Arnd Bergmann wrote:
> On Thursday 28 March 2013, Arnd Bergmann wrote:
>> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used
>> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function
>> inside of an #ifdef to work around an unused function warning.
> Hi Greg,
>
> Apparently the warning is now also in 3.8.5, so you might want to backport
> this fix as well after you send it upstream.
>
> 	Arnd
Grr, my bad - I originally wrote the patch with the forward decl 
#ifdef'd as well, but Alan pointed out that it didn't need to be. I 
thought I recompiled it after the change, but obviously not.

Thanks Arnd,

Regards
Tony P

  reply	other threads:[~2013-03-28 21:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  5:28 [PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM Tony Prisk
2013-03-27  5:28 ` Tony Prisk
2013-03-28 21:09 ` [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused Arnd Bergmann
2013-03-28 21:09   ` Arnd Bergmann
2013-03-28 21:16   ` Arnd Bergmann
2013-03-28 21:16     ` Arnd Bergmann
2013-03-28 21:20     ` Tony Prisk [this message]
2013-03-28 21:20       ` Tony Prisk
2013-03-29 14:05       ` Alan Stern
2013-03-29 14:05         ` Alan Stern
2013-03-29 14:05   ` Alan Stern
2013-03-29 14:05     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5154B436.5080700@prisktech.co.nz \
    --to=linux@prisktech.co.nz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.