All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Pedersen <thomas@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wirelss <linux-wireless@vger.kernel.org>,
	open80211s <devel@lists.open80211s.org>,
	Thomas Pedersen <thomas@cozybit.com>
Subject: [PATCH 2/6] mac80211: exclude multicast frames from BA accounting
Date: Mon,  8 Apr 2013 11:06:13 -0700	[thread overview]
Message-ID: <1365444377-9959-2-git-send-email-thomas@cozybit.com> (raw)
In-Reply-To: <1365444377-9959-1-git-send-email-thomas@cozybit.com>

Since multicast aggregation is not currently supported by
mac80211, we can safely ignore them when reordering
aggregate MPDUs.

This fixes a bug where the expected sequence number might
be reset after processing a multicast frame from a STA
with an established aggregation session. The expected
sequence number would then be incorrect and all aggregated
frames until the sequence number rolled over would be
dropped.

Signed-off-by: Thomas Pedersen <thomas@cozybit.com>
---
 net/mac80211/rx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 5168f89..cb55ef0 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -864,7 +864,8 @@ static void ieee80211_rx_reorder_ampdu(struct ieee80211_rx_data *rx,
 	u16 sc;
 	u8 tid, ack_policy;
 
-	if (!ieee80211_is_data_qos(hdr->frame_control))
+	if (!ieee80211_is_data_qos(hdr->frame_control) ||
+	    is_multicast_ether_addr(hdr->addr1))
 		goto dont_reorder;
 
 	/*
-- 
1.7.10.4


  reply	other threads:[~2013-04-08 18:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 18:06 [PATCH 1/6] mac80211: unset FC retry bit in mesh fwding path Thomas Pedersen
2013-04-08 18:06 ` Thomas Pedersen [this message]
2013-04-09  9:47   ` [PATCH 2/6] mac80211: exclude multicast frames from BA accounting Johannes Berg
2013-04-10 22:15     ` Thomas Pedersen
2013-04-08 18:06 ` [PATCH 3/6] mac80211: ieee80211_queue_stopped returns reasons Thomas Pedersen
2013-04-08 18:32   ` Antonio Quartulli
2013-04-08 18:37   ` Johannes Berg
2013-04-08 19:30     ` Thomas Pedersen
2013-04-08 19:38       ` Johannes Berg
2013-04-08 19:57         ` Thomas Pedersen
2013-04-09  9:37           ` Johannes Berg
2013-04-10 17:36             ` Thomas Pedersen
2013-04-10 18:16               ` Johannes Berg
2013-04-08 18:06 ` [PATCH 4/6] mac80211: limit mesh forwarding drops Thomas Pedersen
2013-04-08 18:06 ` [PATCH 5/6] mac80211: stringify another plink state Thomas Pedersen
2013-04-09  9:48   ` Johannes Berg
2013-04-08 18:06 ` [PATCH 6/6] mac80211: avoid mesh peer rate update warning Thomas Pedersen
2013-04-09  9:38   ` Johannes Berg
2013-04-09  9:42     ` Johannes Berg
2013-04-10 17:38       ` Thomas Pedersen
     [not found] ` <1782507887.154.1365455855469.JavaMail.mail@webmail12>
2013-04-08 21:27   ` [PATCH 5/6] mac80211: stringify another plink state Joe Perches
2013-04-08 22:19     ` Joe Perches
2013-04-09  9:39 ` [PATCH 1/6] mac80211: unset FC retry bit in mesh fwding path Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365444377-9959-2-git-send-email-thomas@cozybit.com \
    --to=thomas@cozybit.com \
    --cc=devel@lists.open80211s.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.