From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wirelss <linux-wireless@vger.kernel.org>,
open80211s <devel@lists.open80211s.org>
Subject: Re: [PATCH 3/6] mac80211: ieee80211_queue_stopped returns reasons
Date: Wed, 10 Apr 2013 20:16:40 +0200 [thread overview]
Message-ID: <1365617800.4235.31.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAG6hwVOamzGVJ8x3omSu_9oY48WK=8nk=3P4CWnba53TfhsqUw@mail.gmail.com> (sfid-20130410_193731_490850_24C6FDAC)
On Wed, 2013-04-10 at 10:36 -0700, Thomas Pedersen wrote:
> > However it seems that ieee80211_queue_stopped() is actually kinda broken
> > and should only return the 'driver-stopped' reason to start with. If you
> > fix that, it's probably good enough for you. I don't think in patch 4
> > you should drop frames for scanning, for example.
>
> It looks like mac80211 already just checks local->queue_stop_reasons
> for being 0 (or not), so that check would still hold. I'm not 100%
> sure the driver calls to ieee80211_queue_stopped() only returning true
> for REASON_DRIVER are ok? What if the queues are being flushed, or say
> REASON_PS is set?
I looked at the drivers, and while (almost?) all of them use it
incorrectly they really want only REASON_DRIVER. In fact, they'd be
better off with just that even in the incorrect usages.
johannes
next prev parent reply other threads:[~2013-04-10 18:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 18:06 [PATCH 1/6] mac80211: unset FC retry bit in mesh fwding path Thomas Pedersen
2013-04-08 18:06 ` [PATCH 2/6] mac80211: exclude multicast frames from BA accounting Thomas Pedersen
2013-04-09 9:47 ` Johannes Berg
2013-04-10 22:15 ` Thomas Pedersen
2013-04-08 18:06 ` [PATCH 3/6] mac80211: ieee80211_queue_stopped returns reasons Thomas Pedersen
2013-04-08 18:32 ` Antonio Quartulli
2013-04-08 18:37 ` Johannes Berg
2013-04-08 19:30 ` Thomas Pedersen
2013-04-08 19:38 ` Johannes Berg
2013-04-08 19:57 ` Thomas Pedersen
2013-04-09 9:37 ` Johannes Berg
2013-04-10 17:36 ` Thomas Pedersen
2013-04-10 18:16 ` Johannes Berg [this message]
2013-04-08 18:06 ` [PATCH 4/6] mac80211: limit mesh forwarding drops Thomas Pedersen
2013-04-08 18:06 ` [PATCH 5/6] mac80211: stringify another plink state Thomas Pedersen
2013-04-09 9:48 ` Johannes Berg
2013-04-08 18:06 ` [PATCH 6/6] mac80211: avoid mesh peer rate update warning Thomas Pedersen
2013-04-09 9:38 ` Johannes Berg
2013-04-09 9:42 ` Johannes Berg
2013-04-10 17:38 ` Thomas Pedersen
[not found] ` <1782507887.154.1365455855469.JavaMail.mail@webmail12>
2013-04-08 21:27 ` [PATCH 5/6] mac80211: stringify another plink state Joe Perches
2013-04-08 22:19 ` Joe Perches
2013-04-09 9:39 ` [PATCH 1/6] mac80211: unset FC retry bit in mesh fwding path Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365617800.4235.31.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.