All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Pedersen <thomas@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wirelss <linux-wireless@vger.kernel.org>,
	open80211s <devel@lists.open80211s.org>,
	Thomas Pedersen <thomas@cozybit.com>
Subject: [PATCH 6/6] mac80211: avoid mesh peer rate update warning
Date: Mon,  8 Apr 2013 11:06:17 -0700	[thread overview]
Message-ID: <1365444377-9959-6-git-send-email-thomas@cozybit.com> (raw)
In-Reply-To: <1365444377-9959-1-git-send-email-thomas@cozybit.com>

Some drivers (like ath9k_htc) will take a mutex in
rate_control_rate_update(), so drop the sta lock before we
get there.

Signed-off-by: Thomas Pedersen <thomas@cozybit.com>

Can go towards 3.9.
---
 net/mac80211/mesh_plink.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c
index cdd4183..ca284ee 100644
--- a/net/mac80211/mesh_plink.c
+++ b/net/mac80211/mesh_plink.c
@@ -379,8 +379,10 @@ static void mesh_sta_info_init(struct ieee80211_sub_if_data *sdata,
 	sta->last_rx = jiffies;
 
 	/* rates and capabilities don't change during peering */
-	if (sta->plink_state == NL80211_PLINK_ESTAB)
-		goto out;
+	if (sta->plink_state == NL80211_PLINK_ESTAB) {
+		spin_unlock_bh(&sta->lock);
+		return;
+	}
 
 	if (sta->sta.supp_rates[band] != rates)
 		changed |= IEEE80211_RC_SUPP_RATES_CHANGED;
@@ -398,13 +400,12 @@ static void mesh_sta_info_init(struct ieee80211_sub_if_data *sdata,
 			changed |= IEEE80211_RC_BW_CHANGED;
 		sta->sta.bandwidth = IEEE80211_STA_RX_BW_20;
 	}
+	spin_unlock_bh(&sta->lock);
 
 	if (insert)
 		rate_control_rate_init(sta);
 	else
 		rate_control_rate_update(local, sband, sta, changed);
-out:
-	spin_unlock_bh(&sta->lock);
 }
 
 static struct sta_info *
-- 
1.7.10.4


  parent reply	other threads:[~2013-04-08 18:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 18:06 [PATCH 1/6] mac80211: unset FC retry bit in mesh fwding path Thomas Pedersen
2013-04-08 18:06 ` [PATCH 2/6] mac80211: exclude multicast frames from BA accounting Thomas Pedersen
2013-04-09  9:47   ` Johannes Berg
2013-04-10 22:15     ` Thomas Pedersen
2013-04-08 18:06 ` [PATCH 3/6] mac80211: ieee80211_queue_stopped returns reasons Thomas Pedersen
2013-04-08 18:32   ` Antonio Quartulli
2013-04-08 18:37   ` Johannes Berg
2013-04-08 19:30     ` Thomas Pedersen
2013-04-08 19:38       ` Johannes Berg
2013-04-08 19:57         ` Thomas Pedersen
2013-04-09  9:37           ` Johannes Berg
2013-04-10 17:36             ` Thomas Pedersen
2013-04-10 18:16               ` Johannes Berg
2013-04-08 18:06 ` [PATCH 4/6] mac80211: limit mesh forwarding drops Thomas Pedersen
2013-04-08 18:06 ` [PATCH 5/6] mac80211: stringify another plink state Thomas Pedersen
2013-04-09  9:48   ` Johannes Berg
2013-04-08 18:06 ` Thomas Pedersen [this message]
2013-04-09  9:38   ` [PATCH 6/6] mac80211: avoid mesh peer rate update warning Johannes Berg
2013-04-09  9:42     ` Johannes Berg
2013-04-10 17:38       ` Thomas Pedersen
     [not found] ` <1782507887.154.1365455855469.JavaMail.mail@webmail12>
2013-04-08 21:27   ` [PATCH 5/6] mac80211: stringify another plink state Joe Perches
2013-04-08 22:19     ` Joe Perches
2013-04-09  9:39 ` [PATCH 1/6] mac80211: unset FC retry bit in mesh fwding path Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365444377-9959-6-git-send-email-thomas@cozybit.com \
    --to=thomas@cozybit.com \
    --cc=devel@lists.open80211s.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.