Re: [PATCH] eglibc: include libgcc when libpthread is enabled

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2013-05-09 at 15:55 +0300, Bogdan Marinescu wrote:
> libpthread needs libgcc to function properly. Without libgcc I get
> the following error:
> 
> root@qemux86:~# tclsh
> % exit 0
> libgcc_s.so.1 must be installed for pthread_cancel to work
> Aborted
> root@qemux86:~#
> 
> This patch fixes the above issue and similar ones by adding a
> runtime dependency of libgcc to eglibc when threads are enabled.
> 
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>  meta/recipes-core/eglibc/eglibc.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
> index 1e04197..24fb05b 100644
> --- a/meta/recipes-core/eglibc/eglibc.inc
> +++ b/meta/recipes-core/eglibc/eglibc.inc
> @@ -35,7 +35,7 @@ siteconfig_do_siteconfig_gencache_prepend = " \
>  # nptl needs unwind support in gcc, which can't be built without glibc.
>  DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial linux-libc-headers virtual/${TARGET_PREFIX}libc-initial"
>  # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect this
> -#RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> +RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
>  PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc"
>  PROVIDES += "virtual/libintl virtual/libiconv"
>  inherit autotools

Why/when was that line commented out originally? Also, afaik glibc
doesn't support anything other than nptl these days so we can probably
drop the GLIBC_ADDONS check. Khem/Phil?

Cheers,

Richard