From: Phil Blundell <pb@pbcl.net>
To: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: include libgcc when libpthread is enabled
Date: Thu, 09 May 2013 14:20:05 +0100 [thread overview]
Message-ID: <1368105605.16243.65.camel@pb-ThinkPad-R50e> (raw)
In-Reply-To: <1368104132-30116-1-git-send-email-bogdan.a.marinescu@intel.com>
On Thu, 2013-05-09 at 15:55 +0300, Bogdan Marinescu wrote:
> # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect this
> -#RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> +RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
Wow, it seems like this has been broken since 2008 and nobody noticed.
That line was commented out in oe-classic e96e82cd without any real
explanation and it's been that way ever since.
That said, forcing libgcc into RDEPENDS_${PN} unconditionally like this
is suboptimal, because programs that don't link -lpthread (or possibly
even programs that do, if they don't use cancellation) still don't need
libgcc. With this change it will be impossible to avoid getting libgcc
in an image, which will be a loss for those trying to build small images
with single threaded programs.
p.
next prev parent reply other threads:[~2013-05-09 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 12:55 [PATCH] eglibc: include libgcc when libpthread is enabled Bogdan Marinescu
2013-05-09 13:19 ` Richard Purdie
2013-05-09 14:32 ` Phil Blundell
2013-05-09 13:20 ` Phil Blundell [this message]
2013-05-09 13:28 ` Marinescu, Bogdan A
2013-05-09 14:08 ` Phil Blundell
2013-05-09 15:02 ` Phil Blundell
2013-05-09 14:25 ` Khem Raj
2013-05-09 14:32 ` Khem Raj
2013-05-09 15:26 ` Mark Hatle
2013-05-09 15:36 ` Richard Purdie
2013-05-09 15:40 ` Phil Blundell
2013-05-09 16:04 ` Mark Hatle
2013-05-09 16:40 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368105605.16243.65.camel@pb-ThinkPad-R50e \
--to=pb@pbcl.net \
--cc=bogdan.a.marinescu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.