From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: include libgcc when libpthread is enabled
Date: Thu, 09 May 2013 16:36:21 +0100 [thread overview]
Message-ID: <1368113781.27116.100.camel@ted> (raw)
In-Reply-To: <518BC02E.8010909@windriver.com>
On Thu, 2013-05-09 at 10:26 -0500, Mark Hatle wrote:
> On 5/9/13 9:32 AM, Khem Raj wrote:
> >
> > On May 9, 2013, at 5:55 AM, Bogdan Marinescu <bogdan.a.marinescu@intel.com> wrote:
> >
> >> libpthread needs libgcc to function properly. Without libgcc I get
> >> the following error:
> >>
> >> root@qemux86:~# tclsh
> >> % exit 0
> >> libgcc_s.so.1 must be installed for pthread_cancel to work
> >> Aborted
> >> root@qemux86:~#
> >>
> >> This patch fixes the above issue and similar ones by adding a
> >> runtime dependency of libgcc to eglibc when threads are enabled.
> >>
> >> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> >> ---
> >> meta/recipes-core/eglibc/eglibc.inc | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
> >> index 1e04197..24fb05b 100644
> >> --- a/meta/recipes-core/eglibc/eglibc.inc
> >> +++ b/meta/recipes-core/eglibc/eglibc.inc
> >> @@ -35,7 +35,7 @@ siteconfig_do_siteconfig_gencache_prepend = " \
> >> # nptl needs unwind support in gcc, which can't be built without glibc.
> >> DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial linux-libc-headers virtual/${TARGET_PREFIX}libc-initial"
> >> # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect this
> >> -#RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> >> +RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
> >
> > ah too early. I think you should spin out libpthread into separate package and then RDEPEND_libpthread = "…"
> > and don't use nptl we do not have any other option now a days.
>
> This would be my suggestion. I'd also want to make sure there is a
> libpthread-dev (which for some reason I think there already is) because the
> links in there are required for on-target thread debugging...
As I keep mentioning, rightly or probably more wrongly we support one
-dev package per recipe right now, not multiple packages.
Cheers,
Richard
next prev parent reply other threads:[~2013-05-09 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 12:55 [PATCH] eglibc: include libgcc when libpthread is enabled Bogdan Marinescu
2013-05-09 13:19 ` Richard Purdie
2013-05-09 14:32 ` Phil Blundell
2013-05-09 13:20 ` Phil Blundell
2013-05-09 13:28 ` Marinescu, Bogdan A
2013-05-09 14:08 ` Phil Blundell
2013-05-09 15:02 ` Phil Blundell
2013-05-09 14:25 ` Khem Raj
2013-05-09 14:32 ` Khem Raj
2013-05-09 15:26 ` Mark Hatle
2013-05-09 15:36 ` Richard Purdie [this message]
2013-05-09 15:40 ` Phil Blundell
2013-05-09 16:04 ` Mark Hatle
2013-05-09 16:40 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368113781.27116.100.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.