All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.
@ 2013-06-04 15:13 Egbert Eich
  2013-06-04 15:35 ` Chris Wilson
  0 siblings, 1 reply; 3+ messages in thread
From: Egbert Eich @ 2013-06-04 15:13 UTC (permalink / raw)
  To: intel-gfx; +Cc: Egbert Eich, Daniel Vetter, Chris Wilson, Rodrigo Vivi

In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
for DDC. Thus the code will always have to rely on a LVDS panel
mode supplied by VBT.
In most cases this succeeds, so this didn't get detected for quite
a while.

Signed-off-by: Egbert Eich <eich@suse.de>
---
 drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index 7068195..8618b15 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1848,7 +1848,7 @@ static void intel_sdvo_get_lvds_modes(struct drm_connector *connector)
 	 * Assume that the preferred modes are
 	 * arranged in priority order.
 	 */
-	intel_ddc_get_modes(connector, intel_sdvo->i2c);
+	intel_ddc_get_modes(connector, &intel_sdvo->ddc);
 	if (list_empty(&connector->probed_modes) == false)
 		goto end;
 
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.
  2013-06-04 15:13 [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC Egbert Eich
@ 2013-06-04 15:35 ` Chris Wilson
  2013-06-04 15:48   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2013-06-04 15:35 UTC (permalink / raw)
  To: Egbert Eich; +Cc: Daniel Vetter, intel-gfx, Chris Wilson, Rodrigo Vivi

On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote:
> In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
> for DDC. Thus the code will always have to rely on a LVDS panel
> mode supplied by VBT.
> In most cases this succeeds, so this didn't get detected for quite
> a while.
> 
> Signed-off-by: Egbert Eich <eich@suse.de>

Good catch!
Cc: stable@vger.kernel.org
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC.
  2013-06-04 15:35 ` Chris Wilson
@ 2013-06-04 15:48   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2013-06-04 15:48 UTC (permalink / raw)
  To: Chris Wilson
  Cc: Egbert Eich, Daniel Vetter, intel-gfx, Chris Wilson, Rodrigo Vivi

On Tue, Jun 04, 2013 at 04:35:32PM +0100, Chris Wilson wrote:
> On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote:
> > In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
> > for DDC. Thus the code will always have to rely on a LVDS panel
> > mode supplied by VBT.
> > In most cases this succeeds, so this didn't get detected for quite
> > a while.
> > 
> > Signed-off-by: Egbert Eich <eich@suse.de>
> 
> Good catch!
> Cc: stable@vger.kernel.org
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Yeah, nice catch. If my history digging is correct this has been broken in

commit f899fc64cda8569d0529452aafc0da31c042df2e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Jul 20 15:44:45 2010 -0700

    drm/i915: use GMBUS to manage i2c links

Patch merged with that note added, thanks.
-Daniel
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-04 15:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-04 15:13 [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead of intel_sdvo->i2c for DDC Egbert Eich
2013-06-04 15:35 ` Chris Wilson
2013-06-04 15:48   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.