* [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values
@ 2013-06-10 14:23 Axel Lin
2013-06-10 14:26 ` Lars-Peter Clausen
2013-06-10 17:06 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-06-10 14:23 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood
Otherwise, ssm2518_set_tdm_slot() always returns error if slots != 0.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/ssm2518.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
index a76b341..f4883d9 100644
--- a/sound/soc/codecs/ssm2518.c
+++ b/sound/soc/codecs/ssm2518.c
@@ -538,7 +538,7 @@ static int ssm2518_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
SSM2518_REG_SAI_CTRL1, SSM2518_SAI_CTRL1_SAI_MASK,
SSM2518_SAI_CTRL1_SAI_I2S);
- if (tx_mask == 0 || tx_mask != 0)
+ if (tx_mask == 0 || rx_mask != 0)
return -EINVAL;
if (slots == 1) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values
2013-06-10 14:23 [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values Axel Lin
@ 2013-06-10 14:26 ` Lars-Peter Clausen
2013-06-10 17:06 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2013-06-10 14:26 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, Liam Girdwood
On 06/10/2013 04:23 PM, Axel Lin wrote:
> Otherwise, ssm2518_set_tdm_slot() always returns error if slots != 0.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> sound/soc/codecs/ssm2518.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
> index a76b341..f4883d9 100644
> --- a/sound/soc/codecs/ssm2518.c
> +++ b/sound/soc/codecs/ssm2518.c
> @@ -538,7 +538,7 @@ static int ssm2518_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
> SSM2518_REG_SAI_CTRL1, SSM2518_SAI_CTRL1_SAI_MASK,
> SSM2518_SAI_CTRL1_SAI_I2S);
>
> - if (tx_mask == 0 || tx_mask != 0)
> + if (tx_mask == 0 || rx_mask != 0)
> return -EINVAL;
>
> if (slots == 1) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values
2013-06-10 14:23 [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values Axel Lin
2013-06-10 14:26 ` Lars-Peter Clausen
@ 2013-06-10 17:06 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-06-10 17:06 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 148 bytes --]
On Mon, Jun 10, 2013 at 10:23:53PM +0800, Axel Lin wrote:
> Otherwise, ssm2518_set_tdm_slot() always returns error if slots != 0.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-10 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 14:23 [PATCH] ASoC: ssm2518: Fix trivial typo in checking tx_mask and rx_mask values Axel Lin
2013-06-10 14:26 ` Lars-Peter Clausen
2013-06-10 17:06 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.