From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, Paul Mackerras <paulus@samba.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap
Date: Sun, 16 Jun 2013 04:31:20 +0000 [thread overview]
Message-ID: <1371357080.21896.115.camel@pasglop> (raw)
In-Reply-To: <1371356818.21896.114.camel@pasglop>
On Sun, 2013-06-16 at 14:26 +1000, Benjamin Herrenschmidt wrote:
> > +int realmode_get_page(struct page *page)
> > +{
> > + if (PageCompound(page))
> > + return -EAGAIN;
> > +
> > + get_page(page);
> > +
> > + return 0;
> > +}
Shouldn't it be get_page_unless_zero ?
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, Alexander Graf <agraf@suse.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap
Date: Sun, 16 Jun 2013 14:31:20 +1000 [thread overview]
Message-ID: <1371357080.21896.115.camel@pasglop> (raw)
In-Reply-To: <1371356818.21896.114.camel@pasglop>
On Sun, 2013-06-16 at 14:26 +1000, Benjamin Herrenschmidt wrote:
> > +int realmode_get_page(struct page *page)
> > +{
> > + if (PageCompound(page))
> > + return -EAGAIN;
> > +
> > + get_page(page);
> > +
> > + return 0;
> > +}
Shouldn't it be get_page_unless_zero ?
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, Paul Mackerras <paulus@samba.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap
Date: Sun, 16 Jun 2013 14:31:20 +1000 [thread overview]
Message-ID: <1371357080.21896.115.camel@pasglop> (raw)
In-Reply-To: <1371356818.21896.114.camel@pasglop>
On Sun, 2013-06-16 at 14:26 +1000, Benjamin Herrenschmidt wrote:
> > +int realmode_get_page(struct page *page)
> > +{
> > + if (PageCompound(page))
> > + return -EAGAIN;
> > +
> > + get_page(page);
> > +
> > + return 0;
> > +}
Shouldn't it be get_page_unless_zero ?
Cheers,
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, Paul Mackerras <paulus@samba.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap
Date: Sun, 16 Jun 2013 14:31:20 +1000 [thread overview]
Message-ID: <1371357080.21896.115.camel@pasglop> (raw)
In-Reply-To: <1371356818.21896.114.camel@pasglop>
On Sun, 2013-06-16 at 14:26 +1000, Benjamin Herrenschmidt wrote:
> > +int realmode_get_page(struct page *page)
> > +{
> > + if (PageCompound(page))
> > + return -EAGAIN;
> > +
> > + get_page(page);
> > +
> > + return 0;
> > +}
Shouldn't it be get_page_unless_zero ?
Cheers,
Ben.
next prev parent reply other threads:[~2013-06-16 4:31 UTC|newest]
Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 6:11 [PATCH 0/4 v3] KVM: PPC: IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-05 6:11 ` [PATCH 1/4] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-16 4:20 ` Benjamin Herrenschmidt
2013-06-16 4:20 ` Benjamin Herrenschmidt
2013-06-16 4:20 ` Benjamin Herrenschmidt
2013-06-16 22:06 ` Alexander Graf
2013-06-16 22:06 ` Alexander Graf
2013-06-16 22:06 ` Alexander Graf
2013-06-17 7:55 ` Alexey Kardashevskiy
2013-06-17 7:55 ` Alexey Kardashevskiy
2013-06-17 7:55 ` Alexey Kardashevskiy
2013-06-17 8:02 ` Alexander Graf
2013-06-17 8:02 ` Alexander Graf
2013-06-17 8:02 ` Alexander Graf
2013-06-17 8:34 ` Alexey Kardashevskiy
2013-06-17 8:34 ` Alexey Kardashevskiy
2013-06-17 8:34 ` Alexey Kardashevskiy
2013-06-17 8:40 ` Alexander Graf
2013-06-17 8:40 ` Alexander Graf
2013-06-17 8:40 ` Alexander Graf
2013-06-17 8:51 ` Alexey Kardashevskiy
2013-06-17 8:51 ` Alexey Kardashevskiy
2013-06-17 8:51 ` Alexey Kardashevskiy
2013-06-17 10:46 ` Alexander Graf
2013-06-17 10:46 ` Alexander Graf
2013-06-17 10:46 ` Alexander Graf
2013-06-17 10:48 ` Alexander Graf
2013-06-17 10:48 ` Alexander Graf
2013-06-17 10:48 ` Alexander Graf
2013-06-17 8:37 ` Benjamin Herrenschmidt
2013-06-17 8:37 ` Benjamin Herrenschmidt
2013-06-17 8:37 ` Benjamin Herrenschmidt
2013-06-17 8:42 ` Alexander Graf
2013-06-17 8:42 ` Alexander Graf
2013-06-17 8:42 ` Alexander Graf
2013-06-05 6:11 ` [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-16 4:26 ` Benjamin Herrenschmidt
2013-06-16 4:26 ` Benjamin Herrenschmidt
2013-06-16 4:26 ` Benjamin Herrenschmidt
2013-06-16 4:26 ` Benjamin Herrenschmidt
2013-06-16 4:31 ` Benjamin Herrenschmidt [this message]
2013-06-16 4:31 ` Benjamin Herrenschmidt
2013-06-16 4:31 ` Benjamin Herrenschmidt
2013-06-16 4:31 ` Benjamin Herrenschmidt
2013-06-17 9:17 ` Alexey Kardashevskiy
2013-06-17 9:17 ` Alexey Kardashevskiy
2013-06-17 9:17 ` Alexey Kardashevskiy
2013-06-17 9:17 ` Alexey Kardashevskiy
2013-06-05 6:11 ` [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-16 4:39 ` Benjamin Herrenschmidt
2013-06-16 4:39 ` Benjamin Herrenschmidt
2013-06-16 4:39 ` Benjamin Herrenschmidt
2013-06-19 3:17 ` Alexey Kardashevskiy
2013-06-19 3:17 ` Alexey Kardashevskiy
2013-06-19 3:17 ` Alexey Kardashevskiy
2013-06-16 22:25 ` Alexander Graf
2013-06-16 22:25 ` Alexander Graf
2013-06-16 22:25 ` Alexander Graf
2013-06-16 22:39 ` Benjamin Herrenschmidt
2013-06-16 22:39 ` Benjamin Herrenschmidt
2013-06-16 22:39 ` Benjamin Herrenschmidt
2013-06-17 3:13 ` Alex Williamson
2013-06-17 3:13 ` Alex Williamson
2013-06-17 3:13 ` Alex Williamson
2013-06-17 3:56 ` Benjamin Herrenschmidt
2013-06-17 3:56 ` Benjamin Herrenschmidt
2013-06-17 3:56 ` Benjamin Herrenschmidt
2013-06-18 2:32 ` Alex Williamson
2013-06-18 2:32 ` Alex Williamson
2013-06-18 2:32 ` Alex Williamson
2013-06-18 4:38 ` Benjamin Herrenschmidt
2013-06-18 4:38 ` Benjamin Herrenschmidt
2013-06-18 4:38 ` Benjamin Herrenschmidt
2013-06-18 14:48 ` Alex Williamson
2013-06-18 14:48 ` Alex Williamson
2013-06-18 14:48 ` Alex Williamson
2013-06-18 21:58 ` Benjamin Herrenschmidt
2013-06-18 21:58 ` Benjamin Herrenschmidt
2013-06-18 21:58 ` Benjamin Herrenschmidt
2013-06-19 3:35 ` Rusty Russell
2013-06-19 3:47 ` Rusty Russell
2013-06-19 3:35 ` Rusty Russell
2013-06-19 4:59 ` Benjamin Herrenschmidt
2013-06-19 4:59 ` Benjamin Herrenschmidt
2013-06-19 4:59 ` Benjamin Herrenschmidt
2013-06-19 9:58 ` Alexander Graf
2013-06-19 9:58 ` Alexander Graf
2013-06-19 9:58 ` Alexander Graf
2013-06-19 14:50 ` Benjamin Herrenschmidt
2013-06-19 14:50 ` Benjamin Herrenschmidt
2013-06-19 14:50 ` Benjamin Herrenschmidt
2013-06-19 15:49 ` Alex Williamson
2013-06-19 15:49 ` Alex Williamson
2013-06-19 15:49 ` Alex Williamson
2013-06-20 4:58 ` Alexey Kardashevskiy
2013-06-20 4:58 ` Alexey Kardashevskiy
2013-06-20 4:58 ` Alexey Kardashevskiy
2013-06-20 5:28 ` David Gibson
2013-06-20 5:28 ` David Gibson
2013-06-20 5:28 ` David Gibson
2013-06-20 7:47 ` Benjamin Herrenschmidt
2013-06-20 7:47 ` Benjamin Herrenschmidt
2013-06-20 7:47 ` Benjamin Herrenschmidt
2013-06-20 8:48 ` Alexey Kardashevskiy
2013-06-20 8:48 ` Alexey Kardashevskiy
2013-06-20 8:48 ` Alexey Kardashevskiy
2013-06-20 14:55 ` Alex Williamson
2013-06-20 14:55 ` Alex Williamson
2013-06-20 14:55 ` Alex Williamson
2013-06-22 8:25 ` Alexey Kardashevskiy
2013-06-22 8:25 ` Alexey Kardashevskiy
2013-06-22 8:25 ` Alexey Kardashevskiy
2013-06-22 12:03 ` David Gibson
2013-06-22 12:03 ` David Gibson
2013-06-22 12:03 ` David Gibson
2013-06-22 14:28 ` Alex Williamson
2013-06-22 14:28 ` Alex Williamson
2013-06-22 14:28 ` Alex Williamson
2013-06-24 3:52 ` David Gibson
2013-06-24 3:52 ` David Gibson
2013-06-24 3:52 ` David Gibson
2013-06-24 3:52 ` David Gibson
2013-06-24 4:41 ` Alex Williamson
2013-06-24 4:41 ` Alex Williamson
2013-06-24 4:41 ` Alex Williamson
2013-06-27 11:01 ` David Gibson
2013-06-27 11:01 ` David Gibson
2013-06-27 11:01 ` David Gibson
2013-06-22 23:28 ` Benjamin Herrenschmidt
2013-06-22 23:28 ` Benjamin Herrenschmidt
2013-06-22 23:28 ` Benjamin Herrenschmidt
2013-06-24 3:54 ` David Gibson
2013-06-24 3:54 ` David Gibson
2013-06-24 3:54 ` David Gibson
2013-06-24 3:58 ` Benjamin Herrenschmidt
2013-06-24 3:58 ` Benjamin Herrenschmidt
2013-06-24 3:58 ` Benjamin Herrenschmidt
2013-06-05 6:11 ` [PATCH 4/4] KVM: PPC: Add hugepage " Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-05 6:11 ` Alexey Kardashevskiy
2013-06-16 4:46 ` Benjamin Herrenschmidt
2013-06-16 4:46 ` Benjamin Herrenschmidt
2013-06-16 4:46 ` Benjamin Herrenschmidt
2013-06-17 16:35 ` Paolo Bonzini
2013-06-17 16:35 ` Paolo Bonzini
2013-06-17 16:35 ` Paolo Bonzini
2013-06-12 3:14 ` [PATCH 0/4 v3] KVM: PPC: " Benjamin Herrenschmidt
2013-06-12 3:14 ` Benjamin Herrenschmidt
2013-06-12 3:14 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2013-05-21 3:06 [PATCH 0/4 v2] " Alexey Kardashevskiy
2013-05-21 3:06 ` [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap Alexey Kardashevskiy
2013-05-21 3:06 ` Alexey Kardashevskiy
2013-05-21 3:06 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371357080.21896.115.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.