All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Alex Williamson <alex.williamson@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
	"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	kvm-ppc@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling
Date: Thu, 20 Jun 2013 07:47:29 +0000	[thread overview]
Message-ID: <1371714449.3944.14.camel@pasglop> (raw)
In-Reply-To: <20130620052822.GB3140@voom.redhat.com>

On Thu, 2013-06-20 at 15:28 +1000, David Gibson wrote:
> > Just out of curiosity - would not get_file() and fput_atomic() on a
> group's
> > file* do the right job instead of vfio_group_add_external_user() and
> > vfio_group_del_external_user()?
> 
> I was thinking that too.  Grabbing a file reference would certainly be
> the usual way of handling this sort of thing.

But that wouldn't prevent the group ownership to be returned to
the kernel or another user would it ?

Ben.



WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: "kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Joerg Roedel <joro@8bytes.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Alexander Graf <agraf@suse.de>,
	kvm-ppc@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling
Date: Thu, 20 Jun 2013 17:47:29 +1000	[thread overview]
Message-ID: <1371714449.3944.14.camel@pasglop> (raw)
In-Reply-To: <20130620052822.GB3140@voom.redhat.com>

On Thu, 2013-06-20 at 15:28 +1000, David Gibson wrote:
> > Just out of curiosity - would not get_file() and fput_atomic() on a
> group's
> > file* do the right job instead of vfio_group_add_external_user() and
> > vfio_group_del_external_user()?
> 
> I was thinking that too.  Grabbing a file reference would certainly be
> the usual way of handling this sort of thing.

But that wouldn't prevent the group ownership to be returned to
the kernel or another user would it ?

Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Alex Williamson <alex.williamson@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
	"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	kvm-ppc@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling
Date: Thu, 20 Jun 2013 17:47:29 +1000	[thread overview]
Message-ID: <1371714449.3944.14.camel@pasglop> (raw)
In-Reply-To: <20130620052822.GB3140@voom.redhat.com>

On Thu, 2013-06-20 at 15:28 +1000, David Gibson wrote:
> > Just out of curiosity - would not get_file() and fput_atomic() on a
> group's
> > file* do the right job instead of vfio_group_add_external_user() and
> > vfio_group_del_external_user()?
> 
> I was thinking that too.  Grabbing a file reference would certainly be
> the usual way of handling this sort of thing.

But that wouldn't prevent the group ownership to be returned to
the kernel or another user would it ?

Ben.



  reply	other threads:[~2013-06-20  7:47 UTC|newest]

Thread overview: 212+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05  6:11 [PATCH 0/4 v3] KVM: PPC: IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-05  6:11 ` Alexey Kardashevskiy
2013-06-05  6:11 ` Alexey Kardashevskiy
2013-06-05  6:11 ` [PATCH 1/4] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-16  4:20   ` Benjamin Herrenschmidt
2013-06-16  4:20     ` Benjamin Herrenschmidt
2013-06-16  4:20     ` Benjamin Herrenschmidt
2013-06-16 22:06   ` Alexander Graf
2013-06-16 22:06     ` Alexander Graf
2013-06-16 22:06     ` Alexander Graf
2013-06-17  7:55     ` Alexey Kardashevskiy
2013-06-17  7:55       ` Alexey Kardashevskiy
2013-06-17  7:55       ` Alexey Kardashevskiy
2013-06-17  8:02       ` Alexander Graf
2013-06-17  8:02         ` Alexander Graf
2013-06-17  8:02         ` Alexander Graf
2013-06-17  8:34         ` Alexey Kardashevskiy
2013-06-17  8:34           ` Alexey Kardashevskiy
2013-06-17  8:34           ` Alexey Kardashevskiy
2013-06-17  8:40           ` Alexander Graf
2013-06-17  8:40             ` Alexander Graf
2013-06-17  8:40             ` Alexander Graf
2013-06-17  8:51             ` Alexey Kardashevskiy
2013-06-17  8:51               ` Alexey Kardashevskiy
2013-06-17  8:51               ` Alexey Kardashevskiy
2013-06-17 10:46               ` Alexander Graf
2013-06-17 10:46                 ` Alexander Graf
2013-06-17 10:46                 ` Alexander Graf
2013-06-17 10:48                 ` Alexander Graf
2013-06-17 10:48                   ` Alexander Graf
2013-06-17 10:48                   ` Alexander Graf
2013-06-17  8:37       ` Benjamin Herrenschmidt
2013-06-17  8:37         ` Benjamin Herrenschmidt
2013-06-17  8:37         ` Benjamin Herrenschmidt
2013-06-17  8:42         ` Alexander Graf
2013-06-17  8:42           ` Alexander Graf
2013-06-17  8:42           ` Alexander Graf
2013-06-05  6:11 ` [PATCH 2/4] powerpc: Prepare to support kernel handling of IOMMU map/unmap Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-16  4:26   ` Benjamin Herrenschmidt
2013-06-16  4:26     ` Benjamin Herrenschmidt
2013-06-16  4:26     ` Benjamin Herrenschmidt
2013-06-16  4:26     ` Benjamin Herrenschmidt
2013-06-16  4:31     ` Benjamin Herrenschmidt
2013-06-16  4:31       ` Benjamin Herrenschmidt
2013-06-16  4:31       ` Benjamin Herrenschmidt
2013-06-16  4:31       ` Benjamin Herrenschmidt
2013-06-17  9:17     ` Alexey Kardashevskiy
2013-06-17  9:17       ` Alexey Kardashevskiy
2013-06-17  9:17       ` Alexey Kardashevskiy
2013-06-17  9:17       ` Alexey Kardashevskiy
2013-06-05  6:11 ` [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-16  4:39   ` Benjamin Herrenschmidt
2013-06-16  4:39     ` Benjamin Herrenschmidt
2013-06-16  4:39     ` Benjamin Herrenschmidt
2013-06-19  3:17     ` Alexey Kardashevskiy
2013-06-19  3:17       ` Alexey Kardashevskiy
2013-06-19  3:17       ` Alexey Kardashevskiy
2013-06-16 22:25   ` Alexander Graf
2013-06-16 22:25     ` Alexander Graf
2013-06-16 22:25     ` Alexander Graf
2013-06-16 22:39   ` Benjamin Herrenschmidt
2013-06-16 22:39     ` Benjamin Herrenschmidt
2013-06-16 22:39     ` Benjamin Herrenschmidt
2013-06-17  3:13     ` Alex Williamson
2013-06-17  3:13       ` Alex Williamson
2013-06-17  3:13       ` Alex Williamson
2013-06-17  3:56       ` Benjamin Herrenschmidt
2013-06-17  3:56         ` Benjamin Herrenschmidt
2013-06-17  3:56         ` Benjamin Herrenschmidt
2013-06-18  2:32         ` Alex Williamson
2013-06-18  2:32           ` Alex Williamson
2013-06-18  2:32           ` Alex Williamson
2013-06-18  4:38           ` Benjamin Herrenschmidt
2013-06-18  4:38             ` Benjamin Herrenschmidt
2013-06-18  4:38             ` Benjamin Herrenschmidt
2013-06-18 14:48             ` Alex Williamson
2013-06-18 14:48               ` Alex Williamson
2013-06-18 14:48               ` Alex Williamson
2013-06-18 21:58               ` Benjamin Herrenschmidt
2013-06-18 21:58                 ` Benjamin Herrenschmidt
2013-06-18 21:58                 ` Benjamin Herrenschmidt
2013-06-19  3:35           ` Rusty Russell
2013-06-19  3:47             ` Rusty Russell
2013-06-19  3:35             ` Rusty Russell
2013-06-19  4:59             ` Benjamin Herrenschmidt
2013-06-19  4:59               ` Benjamin Herrenschmidt
2013-06-19  4:59               ` Benjamin Herrenschmidt
2013-06-19  9:58               ` Alexander Graf
2013-06-19  9:58                 ` Alexander Graf
2013-06-19  9:58                 ` Alexander Graf
2013-06-19 14:50                 ` Benjamin Herrenschmidt
2013-06-19 14:50                   ` Benjamin Herrenschmidt
2013-06-19 14:50                   ` Benjamin Herrenschmidt
2013-06-19 15:49                   ` Alex Williamson
2013-06-19 15:49                     ` Alex Williamson
2013-06-19 15:49                     ` Alex Williamson
2013-06-20  4:58                     ` Alexey Kardashevskiy
2013-06-20  4:58                       ` Alexey Kardashevskiy
2013-06-20  4:58                       ` Alexey Kardashevskiy
2013-06-20  5:28                       ` David Gibson
2013-06-20  5:28                         ` David Gibson
2013-06-20  5:28                         ` David Gibson
2013-06-20  7:47                         ` Benjamin Herrenschmidt [this message]
2013-06-20  7:47                           ` Benjamin Herrenschmidt
2013-06-20  7:47                           ` Benjamin Herrenschmidt
2013-06-20  8:48                           ` Alexey Kardashevskiy
2013-06-20  8:48                             ` Alexey Kardashevskiy
2013-06-20  8:48                             ` Alexey Kardashevskiy
2013-06-20 14:55                             ` Alex Williamson
2013-06-20 14:55                               ` Alex Williamson
2013-06-20 14:55                               ` Alex Williamson
2013-06-22  8:25                               ` Alexey Kardashevskiy
2013-06-22  8:25                                 ` Alexey Kardashevskiy
2013-06-22  8:25                                 ` Alexey Kardashevskiy
2013-06-22 12:03                               ` David Gibson
2013-06-22 12:03                                 ` David Gibson
2013-06-22 12:03                                 ` David Gibson
2013-06-22 14:28                                 ` Alex Williamson
2013-06-22 14:28                                   ` Alex Williamson
2013-06-22 14:28                                   ` Alex Williamson
2013-06-24  3:52                                   ` David Gibson
2013-06-24  3:52                                     ` David Gibson
2013-06-24  3:52                                     ` David Gibson
2013-06-24  3:52                                     ` David Gibson
2013-06-24  4:41                                     ` Alex Williamson
2013-06-24  4:41                                       ` Alex Williamson
2013-06-24  4:41                                       ` Alex Williamson
2013-06-27 11:01                                       ` David Gibson
2013-06-27 11:01                                         ` David Gibson
2013-06-27 11:01                                         ` David Gibson
2013-06-22 23:28                                 ` Benjamin Herrenschmidt
2013-06-22 23:28                                   ` Benjamin Herrenschmidt
2013-06-22 23:28                                   ` Benjamin Herrenschmidt
2013-06-24  3:54                                   ` David Gibson
2013-06-24  3:54                                     ` David Gibson
2013-06-24  3:54                                     ` David Gibson
2013-06-24  3:58                                     ` Benjamin Herrenschmidt
2013-06-24  3:58                                       ` Benjamin Herrenschmidt
2013-06-24  3:58                                       ` Benjamin Herrenschmidt
2013-06-05  6:11 ` [PATCH 4/4] KVM: PPC: Add hugepage " Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-05  6:11   ` Alexey Kardashevskiy
2013-06-16  4:46   ` Benjamin Herrenschmidt
2013-06-16  4:46     ` Benjamin Herrenschmidt
2013-06-16  4:46     ` Benjamin Herrenschmidt
2013-06-17 16:35   ` Paolo Bonzini
2013-06-17 16:35     ` Paolo Bonzini
2013-06-17 16:35     ` Paolo Bonzini
2013-06-12  3:14 ` [PATCH 0/4 v3] KVM: PPC: " Benjamin Herrenschmidt
2013-06-12  3:14   ` Benjamin Herrenschmidt
2013-06-12  3:14   ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2013-05-21  3:06 [PATCH 0/4 v2] " Alexey Kardashevskiy
2013-05-21  3:06 ` [PATCH 3/4] KVM: PPC: Add support for " Alexey Kardashevskiy
2013-05-21  3:06   ` Alexey Kardashevskiy
2013-05-21  3:06   ` Alexey Kardashevskiy
2013-05-22 21:06   ` Scott Wood
2013-05-22 21:06     ` Scott Wood
2013-05-22 21:06     ` Scott Wood
2013-05-25  2:45     ` David Gibson
2013-05-25  2:45       ` David Gibson
2013-05-25  2:45       ` David Gibson
2013-05-27  2:44       ` Alexey Kardashevskiy
2013-05-27  2:44         ` Alexey Kardashevskiy
2013-05-27  2:44         ` Alexey Kardashevskiy
2013-05-27 10:23       ` Paolo Bonzini
2013-05-27 10:23         ` Paolo Bonzini
2013-05-27 10:23         ` Paolo Bonzini
2013-05-27 14:26         ` Alexey Kardashevskiy
2013-05-27 14:26           ` Alexey Kardashevskiy
2013-05-27 14:26           ` Alexey Kardashevskiy
2013-05-27 14:41           ` Paolo Bonzini
2013-05-27 14:41             ` Paolo Bonzini
2013-05-27 14:41             ` Paolo Bonzini
2013-05-28 16:32   ` Scott Wood
2013-05-28 16:32     ` Scott Wood
2013-05-28 16:32     ` Scott Wood
2013-05-29  0:20     ` Alexey Kardashevskiy
2013-05-29  0:20       ` Alexey Kardashevskiy
2013-05-29  0:20       ` Alexey Kardashevskiy
2013-05-28 17:45   ` Scott Wood
2013-05-28 17:45     ` Scott Wood
2013-05-28 17:45     ` Scott Wood
2013-05-28 23:30     ` Alexey Kardashevskiy
2013-05-28 23:30       ` Alexey Kardashevskiy
2013-05-28 23:30       ` Alexey Kardashevskiy
2013-05-28 23:35       ` Scott Wood
2013-05-28 23:35         ` Scott Wood
2013-05-28 23:35         ` Scott Wood
2013-05-29  0:12         ` Alexey Kardashevskiy
2013-05-29  0:12           ` Alexey Kardashevskiy
2013-05-29  0:12           ` Alexey Kardashevskiy
2013-05-29 20:05           ` Scott Wood
2013-05-29 20:05             ` Scott Wood
2013-05-29 20:05             ` Scott Wood
2013-05-29 23:10             ` Alexey Kardashevskiy
2013-05-29 23:10               ` Alexey Kardashevskiy
2013-05-29 23:10               ` Alexey Kardashevskiy
2013-05-29 23:14               ` Scott Wood
2013-05-29 23:14                 ` Scott Wood
2013-05-29 23:14                 ` Scott Wood
2013-05-29 23:14                 ` Scott Wood
2013-05-29 23:29                 ` Alexey Kardashevskiy
2013-05-29 23:29                   ` Alexey Kardashevskiy
2013-05-29 23:29                   ` Alexey Kardashevskiy
2013-05-29 23:32                   ` Scott Wood
2013-05-29 23:32                     ` Scott Wood
2013-05-29 23:32                     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371714449.3944.14.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=joro@8bytes.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.