From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Mihai Caraman <mihai.caraman@freescale.com>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler
Date: Wed, 03 Jul 2013 21:52:53 +0000 [thread overview]
Message-ID: <1372888373.8183.152@snotra> (raw)
In-Reply-To: <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> (from agraf@suse.de on Wed Jul 3 16:42:40 2013)
On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
>
> On 03.07.2013, at 22:16, Scott Wood wrote:
>
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
>
> Why does the split break bisectability?
Same reason as the altivec build breakage from earlier. If we add a
new exception type but not a KVM handler for it, the kernel won't link.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Mihai Caraman <mihai.caraman@freescale.com>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler
Date: Wed, 3 Jul 2013 16:52:53 -0500 [thread overview]
Message-ID: <1372888373.8183.152@snotra> (raw)
In-Reply-To: <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> (from agraf@suse.de on Wed Jul 3 16:42:40 2013)
On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
>=20
> On 03.07.2013, at 22:16, Scott Wood wrote:
>=20
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception =20
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
>=20
> Why does the split break bisectability?
Same reason as the altivec build breakage from earlier. If we add a =20
new exception type but not a KVM handler for it, the kernel won't link.
-Scott=
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: Mihai Caraman <mihai.caraman@freescale.com>,
<linuxppc-dev@lists.ozlabs.org>, <kvm-ppc@vger.kernel.org>,
<kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] KVM: PPC: Book3E: Add LRAT error exception handler
Date: Wed, 3 Jul 2013 16:52:53 -0500 [thread overview]
Message-ID: <1372888373.8183.152@snotra> (raw)
In-Reply-To: <6D66E322-D680-4F47-9841-E0A299F45EC1@suse.de> (from agraf@suse.de on Wed Jul 3 16:42:40 2013)
On 07/03/2013 04:42:40 PM, Alexander Graf wrote:
>
> On 03.07.2013, at 22:16, Scott Wood wrote:
>
> > On 07/03/2013 11:56:06 AM, Mihai Caraman wrote:
> >> With LRAT (Logical to Real Address Translation) error exception
> handler in kernel
> >> KVM needs to add the counterpart otherwise will break the build.
> >> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>
> >> ---
> >> arch/powerpc/kvm/bookehv_interrupts.S | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Please combine these two patches to avoid breaking bisectability.
>
> Why does the split break bisectability?
Same reason as the altivec build breakage from earlier. If we add a
new exception type but not a KVM handler for it, the kernel won't link.
-Scott
next prev parent reply other threads:[~2013-07-03 21:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 16:56 [PATCH 1/2] powerpc/booke64: Add LRAT error exception handler Mihai Caraman
2013-07-03 16:56 ` Mihai Caraman
2013-07-03 16:56 ` Mihai Caraman
2013-07-03 16:56 ` [PATCH 2/2] KVM: PPC: Book3E: " Mihai Caraman
2013-07-03 16:56 ` Mihai Caraman
2013-07-03 16:56 ` Mihai Caraman
2013-07-03 20:16 ` Scott Wood
2013-07-03 20:16 ` Scott Wood
2013-07-03 20:16 ` Scott Wood
2013-07-03 21:42 ` Alexander Graf
2013-07-03 21:42 ` Alexander Graf
2013-07-03 21:42 ` Alexander Graf
2013-07-03 21:52 ` Scott Wood [this message]
2013-07-03 21:52 ` Scott Wood
2013-07-03 21:52 ` Scott Wood
2013-07-04 6:47 ` Caraman Mihai Claudiu-B02008
2013-07-04 6:47 ` Caraman Mihai Claudiu-B02008
2013-07-04 6:47 ` Caraman Mihai Claudiu-B02008
2013-07-04 6:57 ` Benjamin Herrenschmidt
2013-07-04 6:57 ` Benjamin Herrenschmidt
2013-07-04 6:57 ` Benjamin Herrenschmidt
2013-07-03 20:18 ` [PATCH 1/2] powerpc/booke64: " Scott Wood
2013-07-03 20:18 ` Scott Wood
2013-07-03 20:18 ` Scott Wood
2013-07-04 6:34 ` Caraman Mihai Claudiu-B02008
2013-07-04 6:34 ` Caraman Mihai Claudiu-B02008
2013-07-04 6:34 ` Caraman Mihai Claudiu-B02008
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372888373.8183.152@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mihai.caraman@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.