All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Chris Friesen <cbf123@mail.usask.ca>,
	kexec@lists.infradead.org, Haren Myneni <hbabu@us.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: visible memory seems wrong in kexec crash dump kernel
Date: Sun, 14 Jul 2013 15:26:24 +1000	[thread overview]
Message-ID: <1373779584.19894.270.camel@pasglop> (raw)
In-Reply-To: <20130714043600.GA30717@concordia>

On Sun, 2013-07-14 at 14:36 +1000, Michael Ellerman wrote:
> > >Is this expected behaviour? It seems to be the same in current git
> > >versions of kexec-tools.
> > >
> > >On my system I see "/proc/device-tree/memory".
> > >
> > >If I modify add_usable_mem_property() to also accept "/memory" then
> my

This is a bug in your device-tree. The memory node should have a unit
address which corresponds to it's reg property. I know people tend to
skip it for "0" but it's bad practice.

So for memory starting at 0 it should be memory@0

Cheers,
Ben.



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Chris Friesen <cbf123@mail.usask.ca>,
	kexec@lists.infradead.org, Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: visible memory seems wrong in kexec crash dump kernel
Date: Sun, 14 Jul 2013 15:26:24 +1000	[thread overview]
Message-ID: <1373779584.19894.270.camel@pasglop> (raw)
In-Reply-To: <20130714043600.GA30717@concordia>

On Sun, 2013-07-14 at 14:36 +1000, Michael Ellerman wrote:
> > >Is this expected behaviour? It seems to be the same in current git
> > >versions of kexec-tools.
> > >
> > >On my system I see "/proc/device-tree/memory".
> > >
> > >If I modify add_usable_mem_property() to also accept "/memory" then
> my

This is a bug in your device-tree. The memory node should have a unit
address which corresponds to it's reg property. I know people tend to
skip it for "0" but it's bad practice.

So for memory starting at 0 it should be memory@0

Cheers,
Ben.

  reply	other threads:[~2013-07-14  5:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 20:55 visible memory seems wrong in kexec crash dump kernel Chris Friesen
2013-07-11 20:55 ` Chris Friesen
2013-07-11 21:22 ` Chris Friesen
2013-07-11 21:22   ` Chris Friesen
2013-07-11 22:46   ` Chris Friesen
2013-07-11 22:46     ` Chris Friesen
2013-07-12  1:21   ` Michael Ellerman
2013-07-12  1:21     ` Michael Ellerman
2013-07-12 21:08     ` Chris Friesen
2013-07-12 21:08       ` Chris Friesen
2013-07-12 22:59       ` Chris Friesen
2013-07-12 22:59         ` Chris Friesen
2013-07-13  6:30         ` Chris Friesen
2013-07-13  6:30           ` Chris Friesen
2013-07-14  4:36           ` Michael Ellerman
2013-07-14  4:36             ` Michael Ellerman
2013-07-14  5:26             ` Benjamin Herrenschmidt [this message]
2013-07-14  5:26               ` Benjamin Herrenschmidt
2013-07-14 23:08               ` Chris Friesen
2013-07-14 23:08                 ` Chris Friesen
2013-07-14 23:11                 ` Benjamin Herrenschmidt
2013-07-14 23:11                   ` Benjamin Herrenschmidt
2013-07-29 23:10           ` Scott Wood
2013-07-29 23:10             ` Scott Wood
2013-07-31 16:40             ` Friesen, Christopher
2013-07-31 16:40               ` Friesen, Christopher
2013-07-31 16:50               ` Scott Wood
2013-07-31 16:50                 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373779584.19894.270.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=cbf123@mail.usask.ca \
    --cc=hbabu@us.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.