From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: linux-mm@kvack.org
Subject: Re: [PATCH 06/14] vrange: Add basic functions to purge volatile pages
Date: Thu, 03 Oct 2013 12:22:24 +0200 [thread overview]
Message-ID: <1380795744.3392.3.camel@AMDC1943> (raw)
In-Reply-To: <1380761503-14509-7-git-send-email-john.stultz@linaro.org>
On śro, 2013-10-02 at 17:51 -0700, John Stultz wrote:
> +static void try_to_discard_one(struct vrange_root *vroot, struct page *page,
> + struct vm_area_struct *vma, unsigned long addr)
> +{
> + struct mm_struct *mm = vma->vm_mm;
> + pte_t *pte;
> + pte_t pteval;
> + spinlock_t *ptl;
> +
> + VM_BUG_ON(!PageLocked(page));
> +
> + pte = page_check_address(page, mm, addr, &ptl, 0);
> + if (!pte)
> + return;
> +
> + BUG_ON(vma->vm_flags & (VM_SPECIAL|VM_LOCKED|VM_MIXEDMAP|VM_HUGETLB));
> +
> + flush_cache_page(vma, addr, page_to_pfn(page));
It seems that this patch is different in your GIT repo
(git://git.linaro.org/people/jstultz/android-dev.git dev/vrange-v9). In
GIT it is missing the fix: s/address/addr.
Best regards,
Krzysztof
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/14] vrange: Add basic functions to purge volatile pages
Date: Thu, 03 Oct 2013 12:22:24 +0200 [thread overview]
Message-ID: <1380795744.3392.3.camel@AMDC1943> (raw)
In-Reply-To: <1380761503-14509-7-git-send-email-john.stultz@linaro.org>
On śro, 2013-10-02 at 17:51 -0700, John Stultz wrote:
> +static void try_to_discard_one(struct vrange_root *vroot, struct page *page,
> + struct vm_area_struct *vma, unsigned long addr)
> +{
> + struct mm_struct *mm = vma->vm_mm;
> + pte_t *pte;
> + pte_t pteval;
> + spinlock_t *ptl;
> +
> + VM_BUG_ON(!PageLocked(page));
> +
> + pte = page_check_address(page, mm, addr, &ptl, 0);
> + if (!pte)
> + return;
> +
> + BUG_ON(vma->vm_flags & (VM_SPECIAL|VM_LOCKED|VM_MIXEDMAP|VM_HUGETLB));
> +
> + flush_cache_page(vma, addr, page_to_pfn(page));
It seems that this patch is different in your GIT repo
(git://git.linaro.org/people/jstultz/android-dev.git dev/vrange-v9). In
GIT it is missing the fix: s/address/addr.
Best regards,
Krzysztof
next prev parent reply other threads:[~2013-10-03 10:22 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 0:51 [PATCH 00/14] Volatile Ranges v9 John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 01/14] vrange: Add basic data structure and functions John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 02/14] vrange: Add vrange support to mm_structs John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 03/14] vrange: Clear volatility on new mmaps John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 04/14] vrange: Add support for volatile ranges on file mappings John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 05/14] vrange: Add new vrange(2) system call John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-07 22:56 ` H. Peter Anvin
2013-10-07 22:56 ` H. Peter Anvin
2013-10-07 23:14 ` John Stultz
2013-10-07 23:14 ` John Stultz
2013-10-07 23:26 ` H. Peter Anvin
2013-10-07 23:26 ` H. Peter Anvin
2013-10-07 23:41 ` John Stultz
2013-10-07 23:41 ` John Stultz
2013-10-07 23:46 ` H. Peter Anvin
2013-10-07 23:46 ` H. Peter Anvin
2013-10-07 23:54 ` John Stultz
2013-10-07 23:54 ` John Stultz
2013-10-07 23:59 ` H. Peter Anvin
2013-10-07 23:59 ` H. Peter Anvin
2013-10-08 0:13 ` Minchan Kim
2013-10-08 0:13 ` Minchan Kim
2013-10-08 0:18 ` John Stultz
2013-10-08 0:18 ` John Stultz
2013-10-08 0:34 ` Minchan Kim
2013-10-08 0:34 ` Minchan Kim
2013-10-08 0:38 ` Minchan Kim
2013-10-08 0:38 ` Minchan Kim
2013-10-08 1:24 ` H. Peter Anvin
2013-10-08 1:24 ` H. Peter Anvin
2013-10-08 2:08 ` Minchan Kim
2013-10-08 2:08 ` Minchan Kim
2013-10-08 2:51 ` KOSAKI Motohiro
2013-10-08 2:51 ` KOSAKI Motohiro
2013-10-08 3:07 ` Minchan Kim
2013-10-08 3:07 ` Minchan Kim
2013-10-08 4:35 ` KOSAKI Motohiro
2013-10-08 4:35 ` KOSAKI Motohiro
2013-10-08 7:12 ` Minchan Kim
2013-10-08 7:12 ` Minchan Kim
2013-10-08 7:17 ` Minchan Kim
2013-10-08 7:17 ` Minchan Kim
2013-10-08 0:03 ` Minchan Kim
2013-10-08 0:03 ` Minchan Kim
2013-10-08 0:07 ` John Stultz
2013-10-08 0:07 ` John Stultz
2013-10-03 0:51 ` [PATCH 06/14] vrange: Add basic functions to purge volatile pages John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 10:22 ` Krzysztof Kozlowski [this message]
2013-10-03 10:22 ` Krzysztof Kozlowski
2013-10-03 0:51 ` [PATCH 07/14] vrange: Purge volatile pages when memory is tight John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-08 3:27 ` Zhan Jianyu
2013-10-08 3:27 ` Zhan Jianyu
2013-10-08 16:22 ` John Stultz
2013-10-08 16:22 ` John Stultz
2013-10-03 0:51 ` [PATCH 08/14] vrange: Send SIGBUS when user try to access purged page John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 09/14] vrange: Add vrange LRU list for purging John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 10/14] vrange: Add core shrinking logic for swapless system John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 11/14] vrange: Purging vrange-anon pages from shrinker John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 12/14] vrange: Support background purging for vrange-file John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 13/14] vrange: Allocate vroot dynamically John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 0:51 ` [PATCH 14/14] vrange: Add vmstat counter about purged page John Stultz
2013-10-03 0:51 ` John Stultz
2013-10-03 23:56 ` [PATCH 00/14] Volatile Ranges v9 John Stultz
2013-10-03 23:56 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380795744.3392.3.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.