* [PATCH] bin/bitbake: Catch establish connection log messages
@ 2013-10-04 13:14 Richard Purdie
2013-10-04 14:23 ` Martin Jansa
0 siblings, 1 reply; 2+ messages in thread
From: Richard Purdie @ 2013-10-04 13:14 UTC (permalink / raw)
To: bitbake-devel
If for example you try "bitbake -m" with an invalid BBSERVER, error
messages are not dsplayed. This change ensures logging is in place
to catch and display such errors.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/bitbake/bin/bitbake b/bitbake/bin/bitbake
index 222dabd..21a6c81 100755
--- a/bitbake/bin/bitbake
+++ b/bitbake/bin/bitbake
@@ -297,8 +297,6 @@ def main():
server = servermodule.BitBakeXMLRPCClient(configParams.observe_only)
server.saveConnectionDetails(configParams.remote_server)
- logger.removeHandler(handler)
-
if not configParams.server_only:
# Collect the feature set for the UI
featureset = getattr(ui_module, "featureSet", [])
@@ -310,6 +308,8 @@ def main():
for k in cleanedvars:
os.environ[k] = cleanedvars[k]
+ logger.removeHandler(handler)
+
try:
return ui_module.main(server_connection.connection, server_connection.events, configParams)
finally:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bin/bitbake: Catch establish connection log messages
2013-10-04 13:14 [PATCH] bin/bitbake: Catch establish connection log messages Richard Purdie
@ 2013-10-04 14:23 ` Martin Jansa
0 siblings, 0 replies; 2+ messages in thread
From: Martin Jansa @ 2013-10-04 14:23 UTC (permalink / raw)
To: Richard Purdie; +Cc: bitbake-devel
[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]
On Fri, Oct 04, 2013 at 02:14:52PM +0100, Richard Purdie wrote:
> If for example you try "bitbake -m" with an invalid BBSERVER, error
> messages are not dsplayed. This change ensures logging is in place
small typo ^
displayed
> to catch and display such errors.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/bitbake/bin/bitbake b/bitbake/bin/bitbake
> index 222dabd..21a6c81 100755
> --- a/bitbake/bin/bitbake
> +++ b/bitbake/bin/bitbake
> @@ -297,8 +297,6 @@ def main():
> server = servermodule.BitBakeXMLRPCClient(configParams.observe_only)
> server.saveConnectionDetails(configParams.remote_server)
>
> - logger.removeHandler(handler)
> -
> if not configParams.server_only:
> # Collect the feature set for the UI
> featureset = getattr(ui_module, "featureSet", [])
> @@ -310,6 +308,8 @@ def main():
> for k in cleanedvars:
> os.environ[k] = cleanedvars[k]
>
> + logger.removeHandler(handler)
> +
> try:
> return ui_module.main(server_connection.connection, server_connection.events, configParams)
> finally:
>
>
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-04 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 13:14 [PATCH] bin/bitbake: Catch establish connection log messages Richard Purdie
2013-10-04 14:23 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.