From: Geoff Levand <geoff@infradead.org>
To: Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>
Cc: cbe-oss-dev@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [Cbe-oss-dev] [PATCH 2/8] cell: Remove OOM message after input_allocate_device
Date: Wed, 23 Oct 2013 13:49:14 -0700 [thread overview]
Message-ID: <1382561354.5204.51.camel@smoke> (raw)
In-Reply-To: <d4dc0be1a19693fca1d8d6bbd3a7ee75163cc269.1382555436.git.joe@perches.com>
Hi Joe,
On Wed, 2013-10-23 at 12:14 -0700, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> index 2bb8031..8804dbd 100644
> --- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> +++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> @@ -58,7 +58,6 @@ static int __init cbe_powerbutton_init(void)
> dev = input_allocate_device();
> if (!dev) {
> ret = -ENOMEM;
> - printk(KERN_ERR "%s: Not enough memory.\n", __func__);
> goto out;
> }
Arnd is out on leave, so I'll say that this looks OK.
Acked-by: Geoff Levand <geoff@infradead.org>
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoff@infradead.org>
To: Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, cbe-oss-dev@lists.ozlabs.org,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH 2/8] cell: Remove OOM message after input_allocate_device
Date: Wed, 23 Oct 2013 13:49:14 -0700 [thread overview]
Message-ID: <1382561354.5204.51.camel@smoke> (raw)
In-Reply-To: <d4dc0be1a19693fca1d8d6bbd3a7ee75163cc269.1382555436.git.joe@perches.com>
Hi Joe,
On Wed, 2013-10-23 at 12:14 -0700, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> index 2bb8031..8804dbd 100644
> --- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> +++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> @@ -58,7 +58,6 @@ static int __init cbe_powerbutton_init(void)
> dev = input_allocate_device();
> if (!dev) {
> ret = -ENOMEM;
> - printk(KERN_ERR "%s: Not enough memory.\n", __func__);
> goto out;
> }
Arnd is out on leave, so I'll say that this looks OK.
Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2013-10-23 20:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 19:14 [PATCH 0/8] treewide: Remove OOM message after input_alloc_device Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-23 19:14 ` [PATCH 1/8] Documentation: Remove OOM message after input_allocate_device Joe Perches
2013-10-23 19:14 ` [PATCH 2/8] cell: " Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-23 20:49 ` Geoff Levand [this message]
2013-10-23 20:49 ` [Cbe-oss-dev] " Geoff Levand
2013-10-23 19:14 ` [PATCH 3/8] hid: " Joe Perches
2013-10-23 19:14 ` [PATCH 4/8] input: " Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-24 18:26 ` Uwe Kleine-König
2013-10-24 18:26 ` Uwe Kleine-König
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:46 ` Uwe Kleine-König
2013-10-24 18:46 ` Uwe Kleine-König
2013-10-24 18:48 ` Joe Perches
2013-10-24 18:48 ` Joe Perches
2013-10-24 19:15 ` Uwe Kleine-König
2013-10-24 19:15 ` Uwe Kleine-König
2013-10-24 18:37 ` Dmitry Torokhov
2013-10-24 18:37 ` Dmitry Torokhov
2013-10-24 18:45 ` Joe Perches
2013-10-24 18:45 ` Joe Perches
2013-10-24 19:10 ` Dmitry Torokhov
2013-10-24 19:10 ` Dmitry Torokhov
2013-10-24 19:20 ` Joe Perches
2013-10-24 19:20 ` Joe Perches
2013-10-23 19:14 ` [PATCH 5/8] media: " Joe Perches
[not found] ` <cover.1382555436.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2013-10-23 19:14 ` [PATCH 6/8] platform:x86: " Joe Perches
2013-10-23 19:14 ` Joe Perches
[not found] ` <93f2f693853e4409877d3d639e39b3b497738757.1382555436.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2013-10-24 9:31 ` Henrique de Moraes Holschuh
2013-10-24 9:31 ` Henrique de Moraes Holschuh
2013-11-20 23:55 ` Matthew Garrett
2013-10-23 19:14 ` [PATCH 7/8] staging: " Joe Perches
2013-10-24 8:30 ` Jonathan Cameron
2013-10-23 19:14 ` [PATCH 8/8] sound: " Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-24 9:26 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382561354.5204.51.camel@smoke \
--to=geoff@infradead.org \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.