From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Wan ZongShun <mcuos.com@gmail.com>,
Andrey Moiseev <o2g.org.ru@gmail.com>,
Henrik Rydberg <rydberg@euromail.se>, Josh Wu <josh.wu@atmel.com>,
Ferruh Yigit <fery@cypress.com>, Pau Oliva Fora <pof@eslack.org>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device
Date: Thu, 24 Oct 2013 12:10:33 -0700 [thread overview]
Message-ID: <20131024191032.GA5553@core.coreip.homeip.net> (raw)
In-Reply-To: <1382640339.22433.73.camel@joe-AO722>
On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote:
> On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote:
> > Hi Joe,
> >
> > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
> > > Emitting an OOM message isn't necessary after input_allocate_device
> > > as there's a generic OOM and a dump_stack already done.
> >
> > No, please don't. The kzalloc may get changed in the future to not dump
> > stack (that was added originally because not everyone was handling OOM
> > properly, right?), input core might get changed to use something else
> > than kzalloc, etc, etc.
> >
> > The majority of errors use dev_err so we also get idea what device
> > failed (if there are several), and more.
>
> I think that's not valuable as input_allocate_device already has
> dozens of locations that don't emit a specific OOM and centralizing
> the location for any generic message would work anyway.
Not having diagnostic messages in some of the drivers is hardly a
justification to remove them from everywhere else.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] input: Remove OOM message after input_allocate_device
Date: Thu, 24 Oct 2013 12:10:33 -0700 [thread overview]
Message-ID: <20131024191032.GA5553@core.coreip.homeip.net> (raw)
In-Reply-To: <1382640339.22433.73.camel@joe-AO722>
On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote:
> On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote:
> > Hi Joe,
> >
> > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
> > > Emitting an OOM message isn't necessary after input_allocate_device
> > > as there's a generic OOM and a dump_stack already done.
> >
> > No, please don't. The kzalloc may get changed in the future to not dump
> > stack (that was added originally because not everyone was handling OOM
> > properly, right?), input core might get changed to use something else
> > than kzalloc, etc, etc.
> >
> > The majority of errors use dev_err so we also get idea what device
> > failed (if there are several), and more.
>
> I think that's not valuable as input_allocate_device already has
> dozens of locations that don't emit a specific OOM and centralizing
> the location for any generic message would work anyway.
Not having diagnostic messages in some of the drivers is hardly a
justification to remove them from everywhere else.
--
Dmitry
next prev parent reply other threads:[~2013-10-24 19:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 19:14 [PATCH 0/8] treewide: Remove OOM message after input_alloc_device Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-23 19:14 ` [PATCH 1/8] Documentation: Remove OOM message after input_allocate_device Joe Perches
2013-10-23 19:14 ` [PATCH 2/8] cell: " Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-23 20:49 ` [Cbe-oss-dev] " Geoff Levand
2013-10-23 20:49 ` Geoff Levand
2013-10-23 19:14 ` [PATCH 3/8] hid: " Joe Perches
2013-10-23 19:14 ` [PATCH 4/8] input: " Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-24 18:26 ` Uwe Kleine-König
2013-10-24 18:26 ` Uwe Kleine-König
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:43 ` Joe Perches
2013-10-24 18:46 ` Uwe Kleine-König
2013-10-24 18:46 ` Uwe Kleine-König
2013-10-24 18:48 ` Joe Perches
2013-10-24 18:48 ` Joe Perches
2013-10-24 19:15 ` Uwe Kleine-König
2013-10-24 19:15 ` Uwe Kleine-König
2013-10-24 18:37 ` Dmitry Torokhov
2013-10-24 18:37 ` Dmitry Torokhov
2013-10-24 18:45 ` Joe Perches
2013-10-24 18:45 ` Joe Perches
2013-10-24 19:10 ` Dmitry Torokhov [this message]
2013-10-24 19:10 ` Dmitry Torokhov
2013-10-24 19:20 ` Joe Perches
2013-10-24 19:20 ` Joe Perches
2013-10-23 19:14 ` [PATCH 5/8] media: " Joe Perches
[not found] ` <cover.1382555436.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2013-10-23 19:14 ` [PATCH 6/8] platform:x86: " Joe Perches
2013-10-23 19:14 ` Joe Perches
[not found] ` <93f2f693853e4409877d3d639e39b3b497738757.1382555436.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2013-10-24 9:31 ` Henrique de Moraes Holschuh
2013-10-24 9:31 ` Henrique de Moraes Holschuh
2013-11-20 23:55 ` Matthew Garrett
2013-10-23 19:14 ` [PATCH 7/8] staging: " Joe Perches
2013-10-24 8:30 ` Jonathan Cameron
2013-10-23 19:14 ` [PATCH 8/8] sound: " Joe Perches
2013-10-23 19:14 ` Joe Perches
2013-10-24 9:26 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024191032.GA5553@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=ben-linux@fluff.org \
--cc=fery@cypress.com \
--cc=joe@perches.com \
--cc=josh.wu@atmel.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=o2g.org.ru@gmail.com \
--cc=pof@eslack.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.