Re: [PATCH v5 04/17] libxc/libxl: sanitize error handling in *_get_max_{cpus, nodes}

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2306 bytes --]

On gio, 2013-12-05 at 12:10 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH v5 04/17] libxc/libxl: sanitize error handling in *_get_max_{cpus, nodes}"):
> > In libxc, make xc_get_max_{cpus,node}() always return either a
> > positive number or -1, and change all the callers to deal with
> > that.
> > 
> > In libxl, make libxl_get_max_{cpus,nodes}() always return either a
> > positive number or a libxl error code. Thanks to that, it is also
> > possible to fix loggig for libxl_{cpu,node}_bitmap_alloc(), which
> > now happens inside the functions themselves, more accurately
> > reporting what happened.
> > 
> > Note that libxl_{cpu,node}_bitmap_alloc() are also moved to
> > libxl_utils.c as, apart from having become less trivial and hence
> > better suited there, that's required for using GC_INIT()/GC_FREE,
> > which in turn is needed for the LOG()/LOGE() macros.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
So, are these going to be committed, at some point before RC0?

I'm talking about the first half of the series, i.e., patches 1 to 8,
containint _not_ the soft affinity work, but just fixes for and libxl
and the node-wise specification of vcpu pinning for xl.

Here's the current situation, as far as I can tell:

   a  xl: match output of vcpu-list with pinning syntax
   a  libxl: better name for last parameter of libxl_list_vcpu
   a  libxl: fix memory leak in libxl_list_vcpu
   a  libxc/libxl: sanitize error handling in *_get_max_{cpus,nodes}
   a  libxc/libxl: allow to retrieve the number of online pCPUs
  ra  xl: allow for node-wise specification of vcpu pinning
   a  xl: implement and enable dryrun mode for `xl vcpu-pin'
   a  xl: test script for the cpumap parser (for vCPU pinning)

 r = has been 'Reviewed-by'
 a = has been 'Acked-by'

Should I resend that part of the series with all the Ack-s?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel