Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1767 bytes --]

On gio, 2013-12-12 at 12:16 +0000, Wei Liu wrote:
> On Thu, Dec 12, 2013 at 09:49:11AM +0100, Dario Faggioli wrote:
> > On mer, 2013-12-11 at 16:11 +0000, Wei Liu wrote:
> > > diff --git a/ts-ovmf-debian-install b/ts-ovmf-debian-install
> > > new file mode 100755
> > > index 0000000..2e19348
> > > --- /dev/null
> > > +++ b/ts-ovmf-debian-install
> > 
> > > +sub start () {
> > > +    target_cmd_root($ho, "$xl create $gho->{CfgPath}", 100);
> > > +}
> > > +
> > Something like "toolstack()->{Command}" instead of "xl" ?
> > 
> 
> $xl is in fact toolstack()->{Command}.
> 
I know.

> > I don't know how important this is, though, as I don't think this has
> > much chances to work with xend, has it?
> > 
> 
> No. Xend is deprecated so I don't bother fiddling with that.
> 
Ok. I was also thinking that keeping these things general and abstract
enough would be better if, at some point, we'd like to intdocude other
toolstack (e.g., virsh/libvirt). However, changes will be needed anyway,
e.g., to the "create" part... so, yeah, I guess this is a non issue.

> > Does this mean that the guest remains up after the end of the test? This
> > is also probably not a big deal, but, shouldn't we tear it down?
> > 
> 
> I copied this from ts-redhat-install.
> 
You're right, sorry for this. I thought I see gests being teared down
somewhere, but just finished running a (similar) test myself, and the
guest is up.

Sorry again for the noise. :-)

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel