Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1196 bytes --]

On gio, 2013-12-12 at 16:26 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [Xen-devel] [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install"):
> > On gio, 2013-12-12 at 12:16 +0000, Wei Liu wrote:
> > > $xl is in fact toolstack()->{Command}.
> > 
> > I know.
> 
> So err, I'm not sure what your point was.  Wei's code seems correct to
> me.
> 
My point was that, even if it's obviously true that
toolstack()->{Command}==xl, and hence Wei's code looks correct to me
too, we better use toolstack()->{Command}.

> > > > I don't know how important this is, though, as I don't think this has
> > > > much chances to work with xend, has it?
> > > 
> > > No. Xend is deprecated so I don't bother fiddling with that.
> 
> I think it's better to be consistent and always use
> toolstack()->{Command} even in tests which aren't going to work with
> xend.
> 
So, err... Exactly my point. :-)

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel