* [PATCH 0/5] fyi, here are the patches that I haven't yet committed
@ 2013-12-24 8:02 Ian Kent
2013-12-24 8:02 ` [PATCH 1/5] autofs-5.0.8 - fix ipv6 link local address handling Ian Kent
` (5 more replies)
0 siblings, 6 replies; 22+ messages in thread
From: Ian Kent @ 2013-12-24 8:02 UTC (permalink / raw)
To: Lan Yixun (dlan); +Cc: autofs mailing list
Let's try that again.
Not certain yet what the problem is but today I investigated a problem
reported against host map not working and it was something quite different.
There are a couple of patches here that are most likely needed in addition
to the currently committed patches.
In paticualar
autofs-5.0.8 - fix fix ipv6 libtirpc getport
autofs-5.0.8 - fix rpc_portmap_getport() proto not set
and possibly
autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given
might be useful.
---
Ian Kent (4):
autofs-5.0.8 - fix ipv6 link local address handling
autofs-5.0.8 - fix fix ipv6 libtirpc getport
autofs-5.0.8 - fix rpc_portmap_getport() proto not set
autofs-5.0.8 - fix options compare
Scott Mayhew (1):
autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given
include/automount.h | 1 +
lib/cat_path.c | 9 +++++++++
lib/rpc_subs.c | 14 +++++++++-----
modules/mount_autofs.c | 12 ++++++------
modules/mount_bind.c | 2 +-
modules/mount_ext2.c | 2 +-
modules/mount_nfs.c | 34 +++++++++++++++++-----------------
modules/parse_sun.c | 22 +++++++++++-----------
modules/replicated.c | 9 ++++++---
9 files changed, 61 insertions(+), 44 deletions(-)
--
Ian
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH 1/5] autofs-5.0.8 - fix ipv6 link local address handling 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent @ 2013-12-24 8:02 ` Ian Kent 2013-12-24 8:02 ` [PATCH 2/5] autofs-5.0.8 - fix fix ipv6 libtirpc getport Ian Kent ` (4 subsequent siblings) 5 siblings, 0 replies; 22+ messages in thread From: Ian Kent @ 2013-12-24 8:02 UTC (permalink / raw) To: Lan Yixun (dlan); +Cc: autofs mailing list Stop the validate_location() function from choking on link local ipv6 addresses. --- lib/rpc_subs.c | 6 ++++++ modules/parse_sun.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/rpc_subs.c b/lib/rpc_subs.c index 2365b6e..9d5b2f5 100644 --- a/lib/rpc_subs.c +++ b/lib/rpc_subs.c @@ -669,6 +669,12 @@ static int create_client(struct conn_info *info, CLIENT **client) goto done; if (ret == -EHOSTUNREACH) goto out_close; + if (ret == -EINVAL) { + char buf[MAX_ERR_BUF]; + char *estr = strerror_r(-ret, buf, MAX_ERR_BUF); + error(LOGOPT_ANY, "connect() failed: %s", estr); + goto out_close; + } if (!info->client && fd != RPC_ANYSOCK) { close(fd); diff --git a/modules/parse_sun.c b/modules/parse_sun.c index 30820b5..e5a4def 100644 --- a/modules/parse_sun.c +++ b/modules/parse_sun.c @@ -862,7 +862,7 @@ static int validate_location(unsigned int logopt, char *loc) *ptr == '-' || *ptr == '.' || *ptr == '_' || *ptr == ',' || *ptr == '(' || *ptr == ')' || *ptr == '#' || *ptr == '@' || *ptr == ':' || - *ptr == '[' || *ptr == ']')) { + *ptr == '[' || *ptr == ']' || *ptr == '%')) { error(logopt, "invalid character \"%c\" " "found in location %s", *ptr, loc); return 0; ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 2/5] autofs-5.0.8 - fix fix ipv6 libtirpc getport 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent 2013-12-24 8:02 ` [PATCH 1/5] autofs-5.0.8 - fix ipv6 link local address handling Ian Kent @ 2013-12-24 8:02 ` Ian Kent 2013-12-24 8:02 ` [PATCH 3/5] autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given Ian Kent ` (3 subsequent siblings) 5 siblings, 0 replies; 22+ messages in thread From: Ian Kent @ 2013-12-24 8:02 UTC (permalink / raw) To: Lan Yixun (dlan); +Cc: autofs mailing list Remove a duplicated case entry and remove redundant check, since it can never be reached, in rpc_rpcb_getport(). --- lib/rpc_subs.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/rpc_subs.c b/lib/rpc_subs.c index 9d5b2f5..cfb63d2 100644 --- a/lib/rpc_subs.c +++ b/lib/rpc_subs.c @@ -524,7 +524,6 @@ static enum clnt_stat rpc_rpcb_getport(CLIENT *client, if (rpcerr.re_vers.low > RPCBVERS4) return status; continue; - case RPC_PROCUNAVAIL: case RPC_PROGUNAVAIL: continue; default: @@ -533,10 +532,7 @@ static enum clnt_stat rpc_rpcb_getport(CLIENT *client, } } - if (s_port == 0) - return RPC_PROGNOTREGISTERED; - - return RPC_PROCUNAVAIL; + return RPC_PROGNOTREGISTERED; } static enum clnt_stat rpc_getport(struct conn_info *info, ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 3/5] autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent 2013-12-24 8:02 ` [PATCH 1/5] autofs-5.0.8 - fix ipv6 link local address handling Ian Kent 2013-12-24 8:02 ` [PATCH 2/5] autofs-5.0.8 - fix fix ipv6 libtirpc getport Ian Kent @ 2013-12-24 8:02 ` Ian Kent 2013-12-24 8:02 ` [PATCH 4/5] autofs-5.0.8 - fix rpc_portmap_getport() proto not set Ian Kent ` (2 subsequent siblings) 5 siblings, 0 replies; 22+ messages in thread From: Ian Kent @ 2013-12-24 8:02 UTC (permalink / raw) To: Lan Yixun (dlan); +Cc: autofs mailing list From: Scott Mayhew <smayhew@redhat.com> It shouldn't just assume it can use port 2049. Signed-off-by: Scott Mayhew <smayhew@redhat.com> --- modules/replicated.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/modules/replicated.c b/modules/replicated.c index 5fdd9d9..2463235 100644 --- a/modules/replicated.c +++ b/modules/replicated.c @@ -444,9 +444,12 @@ static unsigned int get_nfs_info(unsigned logopt, struct host *host, host->name, proto, version); rpc_info->proto = proto; - if (port < 0) - rpc_info->port = NFS_PORT; - else if (port > 0) + if (port < 0) { + if (version & NFS4_REQUESTED) + rpc_info->port = NFS_PORT; + else + port = 0; + } else if (port > 0) rpc_info->port = port; memset(&parms, 0, sizeof(struct pmap)); ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 4/5] autofs-5.0.8 - fix rpc_portmap_getport() proto not set 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent ` (2 preceding siblings ...) 2013-12-24 8:02 ` [PATCH 3/5] autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given Ian Kent @ 2013-12-24 8:02 ` Ian Kent 2013-12-24 8:02 ` [PATCH 5/5] autofs-5.0.8 - fix options compare Ian Kent 2013-12-24 8:38 ` [PATCH 0/5] fyi, here are the patches that I haven't yet committed Dennis Lan (dlan) 5 siblings, 0 replies; 22+ messages in thread From: Ian Kent @ 2013-12-24 8:02 UTC (permalink / raw) To: Lan Yixun (dlan); +Cc: autofs mailing list Recent changes to fix libtirpc usage problems when getting a server exports list cause later server probing to fail. When getting an exports list a new rpc client is always created for the query, which includes setting the protocol in the parameters structure. But when probing availability the client is reused where possible and the protocol is not set in the parameters structure in this case. The rpc_portmap_getport() changes require that the protocol is set in oder to function. --- lib/rpc_subs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/rpc_subs.c b/lib/rpc_subs.c index cfb63d2..7c99ea8 100644 --- a/lib/rpc_subs.c +++ b/lib/rpc_subs.c @@ -877,6 +877,8 @@ int rpc_portmap_getport(struct conn_info *info, memset(&pmap_info, 0, sizeof(struct conn_info)); + pmap_info.proto = proto; + if (proto == IPPROTO_TCP) pmap_info.timeout.tv_sec = PMAP_TOUT_TCP; else ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH 5/5] autofs-5.0.8 - fix options compare 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent ` (3 preceding siblings ...) 2013-12-24 8:02 ` [PATCH 4/5] autofs-5.0.8 - fix rpc_portmap_getport() proto not set Ian Kent @ 2013-12-24 8:02 ` Ian Kent 2013-12-24 8:38 ` [PATCH 0/5] fyi, here are the patches that I haven't yet committed Dennis Lan (dlan) 5 siblings, 0 replies; 22+ messages in thread From: Ian Kent @ 2013-12-24 8:02 UTC (permalink / raw) To: Lan Yixun (dlan); +Cc: autofs mailing list When checking for options in mount locations incorrect matches can occur when the length of the option string is not also used for the check. --- include/automount.h | 1 + lib/cat_path.c | 9 +++++++++ modules/mount_autofs.c | 12 ++++++------ modules/mount_bind.c | 2 +- modules/mount_ext2.c | 2 +- modules/mount_nfs.c | 34 +++++++++++++++++----------------- modules/parse_sun.c | 20 ++++++++++---------- 7 files changed, 45 insertions(+), 35 deletions(-) diff --git a/include/automount.h b/include/automount.h index 71787a5..396391c 100644 --- a/include/automount.h +++ b/include/automount.h @@ -335,6 +335,7 @@ size_t _strlen(const char *str, size_t max); int cat_path(char *buf, size_t len, const char *dir, const char *base); int ncat_path(char *buf, size_t len, const char *dir, const char *base, size_t blen); +int _strncmp(const char *s1, const char *s2, size_t n); /* Core automount definitions */ diff --git a/lib/cat_path.c b/lib/cat_path.c index 60669db..c386b33 100644 --- a/lib/cat_path.c +++ b/lib/cat_path.c @@ -87,3 +87,12 @@ int ncat_path(char *buf, size_t len, return cat_path(buf, len, dir, name); } +/* Compare first n bytes of s1 and s2 and that n == strlen(s1) */ +int _strncmp(const char *s1, const char *s2, size_t n) +{ + size_t len = strlen(s1); + + if (n != len) + return n - len; + return strncmp(s1, s2, n); +} diff --git a/modules/mount_autofs.c b/modules/mount_autofs.c index 319f2e4..61aec70 100644 --- a/modules/mount_autofs.c +++ b/modules/mount_autofs.c @@ -116,17 +116,17 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, while (*comma != '\0' && *comma != ',') comma++; - if (strncmp(cp, "nobrowse", 8) == 0) + if (_strncmp(cp, "nobrowse", 8) == 0) ghost = 0; - else if (strncmp(cp, "nobind", 6) == 0) + else if (_strncmp(cp, "nobind", 6) == 0) nobind = 1; - else if (strncmp(cp, "browse", 6) == 0) + else if (_strncmp(cp, "browse", 6) == 0) ghost = 1; - else if (strncmp(cp, "symlink", 7) == 0) + else if (_strncmp(cp, "symlink", 7) == 0) symlnk = 1; - else if (strncmp(cp, "hosts", 5) == 0) + else if (_strncmp(cp, "hosts", 5) == 0) hosts = 1; - else if (strncmp(cp, "timeout=", 8) == 0) { + else if (_strncmp(cp, "timeout=", 8) == 0) { char *val = strchr(cp, '='); unsigned tout; if (val) { diff --git a/modules/mount_bind.c b/modules/mount_bind.c index 2b70104..a70bf3a 100644 --- a/modules/mount_bind.c +++ b/modules/mount_bind.c @@ -107,7 +107,7 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int end--; o_len = end - cp + 1; - if (strncmp("symlink", cp, o_len) == 0) + if (_strncmp("symlink", cp, o_len) == 0) symlnk = 1; } } diff --git a/modules/mount_ext2.c b/modules/mount_ext2.c index 1edf347..1bc429d 100644 --- a/modules/mount_ext2.c +++ b/modules/mount_ext2.c @@ -77,7 +77,7 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int if (options && options[0]) { for (p = options; (p1 = strchr(p, ',')); p = p1) - if (!strncmp(p, "ro", p1 - p) && ++p1 - p == sizeof("ro")) + if (!_strncmp(p, "ro", p1 - p) && ++p1 - p == sizeof("ro")) ro = 1; if (!strcmp(p, "ro")) ro = 1; diff --git a/modules/mount_nfs.c b/modules/mount_nfs.c index 5a582ef..315fc99 100644 --- a/modules/mount_nfs.c +++ b/modules/mount_nfs.c @@ -126,32 +126,32 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int o_len = end - cp + 1; - if (strncmp("proto=rdma", cp, o_len) == 0 || - strncmp("rdma", cp, o_len) == 0) + if (_strncmp("proto=rdma", cp, o_len) == 0 || + _strncmp("rdma", cp, o_len) == 0) rdma = 1; - if (strncmp("nosymlink", cp, o_len) == 0) { + if (_strncmp("nosymlink", cp, o_len) == 0) { warn(ap->logopt, MODPREFIX "the \"nosymlink\" option is depricated " "and will soon be removed, " "use the \"nobind\" option instead"); nosymlink = 1; - } else if (strncmp("nobind", cp, o_len) == 0) { + } else if (_strncmp("nobind", cp, o_len) == 0) { nobind = 1; - } else if (strncmp("no-use-weight-only", cp, o_len) == 0) { + } else if (_strncmp("no-use-weight-only", cp, o_len) == 0) { flags &= ~MOUNT_FLAG_USE_WEIGHT_ONLY; - } else if (strncmp("use-weight-only", cp, o_len) == 0) { + } else if (_strncmp("use-weight-only", cp, o_len) == 0) { flags |= MOUNT_FLAG_USE_WEIGHT_ONLY; } else { - if (strncmp("vers=4", cp, o_len) == 0 || - strncmp("nfsvers=4", cp, o_len) == 0) + if (_strncmp("vers=4", cp, o_len) == 0 || + _strncmp("nfsvers=4", cp, o_len) == 0) vers = NFS4_VERS_MASK | TCP_SUPPORTED; - else if (strncmp("vers=3", cp, o_len) == 0 || - strncmp("nfsvers=3", cp, o_len) == 0) { + else if (_strncmp("vers=3", cp, o_len) == 0 || + _strncmp("nfsvers=3", cp, o_len) == 0) { vers &= ~(NFS4_VERS_MASK | NFS_VERS_MASK); vers |= NFS3_REQUESTED; - } else if (strncmp("vers=2", cp, o_len) == 0 || - strncmp("nfsvers=2", cp, o_len) == 0) { + } else if (_strncmp("vers=2", cp, o_len) == 0 || + _strncmp("nfsvers=2", cp, o_len) == 0) { vers &= ~(NFS4_VERS_MASK | NFS_VERS_MASK); vers |= NFS2_REQUESTED; } else if (strstr(cp, "port=") == cp && @@ -164,16 +164,16 @@ int mount_mount(struct autofs_point *ap, const char *root, const char *name, int if (port < 0) port = 0; port_opt = cp; - } else if (strncmp("proto=udp", cp, o_len) == 0 || - strncmp("udp", cp, o_len) == 0) { + } else if (_strncmp("proto=udp", cp, o_len) == 0 || + _strncmp("udp", cp, o_len) == 0) { vers &= ~TCP_SUPPORTED; - } else if (strncmp("proto=tcp", cp, o_len) == 0 || - strncmp("tcp", cp, o_len) == 0) { + } else if (_strncmp("proto=tcp", cp, o_len) == 0 || + _strncmp("tcp", cp, o_len) == 0) { vers &= ~UDP_SUPPORTED; } /* Check for options that also make sense with bind mounts */ - else if (strncmp("ro", cp, o_len) == 0) + else if (_strncmp("ro", cp, o_len) == 0) ro = 1; /* and jump over trailing white space */ memcpy(nfsp, cp, comma - cp + 1); diff --git a/modules/parse_sun.c b/modules/parse_sun.c index e5a4def..9a877c8 100644 --- a/modules/parse_sun.c +++ b/modules/parse_sun.c @@ -511,29 +511,29 @@ static int sun_mount(struct autofs_point *ap, const char *root, while (*comma != '\0' && *comma != ',') comma++; - if (strncmp("fstype=", cp, 7) == 0) { + if (_strncmp("fstype=", cp, 7) == 0) { int typelen = comma - (cp + 7); fstype = alloca(typelen + 1); memcpy(fstype, cp + 7, typelen); fstype[typelen] = '\0'; - } else if (strncmp("nonstrict", cp, 9) == 0) { + } else if (_strncmp("nonstrict", cp, 9) == 0) { nonstrict = 1; - } else if (strncmp("strict", cp, 6) == 0) { + } else if (_strncmp("strict", cp, 6) == 0) { nonstrict = 0; - } else if (strncmp("nobrowse", cp, 8) == 0 || - strncmp("browse", cp, 6) == 0 || - strncmp("timeout=", cp, 8) == 0) { + } else if (_strncmp("nobrowse", cp, 8) == 0 || + _strncmp("browse", cp, 6) == 0 || + _strncmp("timeout=", cp, 8) == 0) { if (strcmp(fstype, "autofs") == 0 || strstr(cp, "fstype=autofs")) { memcpy(np, cp, comma - cp + 1); np += comma - cp + 1; } - } else if (strncmp("no-use-weight-only", cp, 18) == 0) { + } else if (_strncmp("no-use-weight-only", cp, 18) == 0) { use_weight_only = -1; - } else if (strncmp("use-weight-only", cp, 15) == 0) { + } else if (_strncmp("use-weight-only", cp, 15) == 0) { use_weight_only = MOUNT_FLAG_USE_WEIGHT_ONLY; - } else if (strncmp("bg", cp, 2) == 0 || - strncmp("nofg", cp, 4) == 0) { + } else if (_strncmp("bg", cp, 2) == 0 || + _strncmp("nofg", cp, 4) == 0) { continue; } else { memcpy(np, cp, comma - cp + 1); ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent ` (4 preceding siblings ...) 2013-12-24 8:02 ` [PATCH 5/5] autofs-5.0.8 - fix options compare Ian Kent @ 2013-12-24 8:38 ` Dennis Lan (dlan) 2013-12-24 9:04 ` Ian Kent 5 siblings, 1 reply; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-24 8:38 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list Hi Ian: Do you mind push a temporary branch into your git repo (if you don't want to queue other patches)? That would much convenient for me to test. Thanks. Lan On Tue, Dec 24, 2013 at 4:02 PM, Ian Kent <raven@themaw.net> wrote: > Let's try that again. > > Not certain yet what the problem is but today I investigated a problem > reported against host map not working and it was something quite different. > > There are a couple of patches here that are most likely needed in addition > to the currently committed patches. > > In paticualar > autofs-5.0.8 - fix fix ipv6 libtirpc getport > autofs-5.0.8 - fix rpc_portmap_getport() proto not set > and possibly > autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given > > might be useful. > > --- > > Ian Kent (4): > autofs-5.0.8 - fix ipv6 link local address handling > autofs-5.0.8 - fix fix ipv6 libtirpc getport > autofs-5.0.8 - fix rpc_portmap_getport() proto not set > autofs-5.0.8 - fix options compare > > Scott Mayhew (1): > autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given > > > include/automount.h | 1 + > lib/cat_path.c | 9 +++++++++ > lib/rpc_subs.c | 14 +++++++++----- > modules/mount_autofs.c | 12 ++++++------ > modules/mount_bind.c | 2 +- > modules/mount_ext2.c | 2 +- > modules/mount_nfs.c | 34 +++++++++++++++++----------------- > modules/parse_sun.c | 22 +++++++++++----------- > modules/replicated.c | 9 ++++++--- > 9 files changed, 61 insertions(+), 44 deletions(-) > > -- > Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-24 8:38 ` [PATCH 0/5] fyi, here are the patches that I haven't yet committed Dennis Lan (dlan) @ 2013-12-24 9:04 ` Ian Kent 2013-12-24 9:42 ` Dennis Lan (dlan) 0 siblings, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-24 9:04 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Tue, 2013-12-24 at 16:38 +0800, Dennis Lan (dlan) wrote: > Hi Ian: > Do you mind push a temporary branch into your git repo (if you don't > want to queue other patches)? > That would much convenient for me to test. Try branch autofs-5.0.public. As master and autofs-5.0 branches diverge the autofs-5.0 will be the place for version 5.0. > Thanks. > > Lan > > On Tue, Dec 24, 2013 at 4:02 PM, Ian Kent <raven@themaw.net> wrote: > > Let's try that again. > > > > Not certain yet what the problem is but today I investigated a problem > > reported against host map not working and it was something quite different. > > > > There are a couple of patches here that are most likely needed in addition > > to the currently committed patches. > > > > In paticualar > > autofs-5.0.8 - fix fix ipv6 libtirpc getport > > autofs-5.0.8 - fix rpc_portmap_getport() proto not set > > and possibly > > autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given > > > > might be useful. > > > > --- > > > > Ian Kent (4): > > autofs-5.0.8 - fix ipv6 link local address handling > > autofs-5.0.8 - fix fix ipv6 libtirpc getport > > autofs-5.0.8 - fix rpc_portmap_getport() proto not set > > autofs-5.0.8 - fix options compare > > > > Scott Mayhew (1): > > autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given > > > > > > include/automount.h | 1 + > > lib/cat_path.c | 9 +++++++++ > > lib/rpc_subs.c | 14 +++++++++----- > > modules/mount_autofs.c | 12 ++++++------ > > modules/mount_bind.c | 2 +- > > modules/mount_ext2.c | 2 +- > > modules/mount_nfs.c | 34 +++++++++++++++++----------------- > > modules/parse_sun.c | 22 +++++++++++----------- > > modules/replicated.c | 9 ++++++--- > > 9 files changed, 61 insertions(+), 44 deletions(-) > > > > -- > > Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-24 9:04 ` Ian Kent @ 2013-12-24 9:42 ` Dennis Lan (dlan) 2013-12-24 10:34 ` Ian Kent 0 siblings, 1 reply; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-24 9:42 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list On Tue, Dec 24, 2013 at 5:04 PM, Ian Kent <raven@themaw.net> wrote: > On Tue, 2013-12-24 at 16:38 +0800, Dennis Lan (dlan) wrote: >> Hi Ian: >> Do you mind push a temporary branch into your git repo (if you don't >> want to queue other patches)? >> That would much convenient for me to test. > > Try branch autofs-5.0.public. > As master and autofs-5.0 branches diverge the autofs-5.0 will be the > place for version 5.0. > > Hi Ian Have problem with branch autofs-5.0.public most obvious error 461:Dec 24 17:29:12 ofire automount[11496]: mount(nfs): no hosts available 462:Dec 24 17:29:12 ofire automount[11496]: dev_ioctl_send_fail: token = 79 ofire ~ # cat /etc/autofs/auto.misc cd -fstype=iso9660,ro,nosuid,nodev :/dev/cdrom # the following entries are samples to pique your imagination mkynfs -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis mkyand -ro,soft,intr,nfsvers=4 mickeycn:/home/android winxp -fstype=cifs,credentials=/etc/autofs/auto.auth ://192.168.90.168/share share -fstype=cifs,credentials=/etc/autofs/auto.auth ://192.168.90.3/For-sd/ ofire ~ # grep -n automount /var/log/messages 149:Dec 24 17:29:05 ofire automount[11496]: st_expire: state 1 path /net 150:Dec 24 17:29:05 ofire automount[11496]: expire_proc: exp_proc = 140156272908032 path /net 151:Dec 24 17:29:05 ofire automount[11496]: expire_cleanup: got thid 140156272908032 path /net stat 0 152:Dec 24 17:29:05 ofire automount[11496]: expire_cleanup: sigchld: exp 140156272908032 finished, switching from 2 to 1 153:Dec 24 17:29:05 ofire automount[11496]: st_ready: st_ready(): state = 2 path /net 448:Dec 24 17:29:12 ofire automount[11496]: handle_packet: type = 3 449:Dec 24 17:29:12 ofire automount[11496]: handle_packet_missing_indirect: token 79, name mkynfs, request pid 11679 450:Dec 24 17:29:12 ofire automount[11496]: attempting to mount entry /mnt/misc/mkynfs 451:Dec 24 17:29:12 ofire automount[11496]: lookup_mount: lookup(file): looking up mkynfs 452:Dec 24 17:29:12 ofire automount[11496]: lookup_mount: lookup(file): mkynfs -> -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis 453:Dec 24 17:29:12 ofire automount[11496]: parse_mount: parse(sun): expanded entry: -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis 454:Dec 24 17:29:12 ofire automount[11496]: parse_mount: parse(sun): gathered options: ro,soft,intr,nfsvers=4 455:Dec 24 17:29:12 ofire automount[11496]: parse_mount: parse(sun): dequote("mickeycn:/home/dennis") -> mickeycn:/home/dennis 456:Dec 24 17:29:12 ofire automount[11496]: parse_mount: parse(sun): core of entry: options=ro,soft,intr,nfsvers=4, loc=mickeycn:/home/dennis 457:Dec 24 17:29:12 ofire automount[11496]: sun_mount: parse(sun): mounting root /mnt/misc, mountpoint mkynfs, what mickeycn:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=4 458:Dec 24 17:29:12 ofire automount[11496]: mount_mount: mount(nfs): root=/mnt/misc name=mkynfs what=mickeycn:/home/dennis, fstype=nfs, options=ro,soft,intr,nfsvers=4 459:Dec 24 17:29:12 ofire automount[11496]: mount_mount: mount(nfs): nfs options="ro,soft,intr,nfsvers=4", nobind=0, nosymlink=0, ro=1 460:Dec 24 17:29:12 ofire automount[11496]: get_nfs_info: called with host mickeycn(192.168.90.12) proto 6 version 0x40 461:Dec 24 17:29:12 ofire automount[11496]: mount(nfs): no hosts available 462:Dec 24 17:29:12 ofire automount[11496]: dev_ioctl_send_fail: token = 79 463:Dec 24 17:29:12 ofire automount[11496]: failed to mount /mnt/misc/mkynfs 464:Dec 24 17:29:12 ofire automount[11496]: handle_packet: type = 3 465:Dec 24 17:29:12 ofire automount[11496]: handle_packet_missing_indirect: token 80, name mkynfs, request pid 11679 466:Dec 24 17:29:12 ofire automount[11496]: dev_ioctl_send_fail: token = 80 516:Dec 24 17:29:13 ofire automount[11496]: st_expire: state 1 path /net 517:Dec 24 17:29:13 ofire automount[11496]: expire_proc: exp_proc = 140156272908032 path /net 518:Dec 24 17:29:13 ofire automount[11496]: expire_cleanup: got thid 140156272908032 path /net stat 0 519:Dec 24 17:29:13 ofire automount[11496]: expire_cleanup: sigchld: exp 140156272908032 finished, switching from 2 to 1 520:Dec 24 17:29:13 ofire automount[11496]: st_ready: st_ready(): state = 2 path /net ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-24 9:42 ` Dennis Lan (dlan) @ 2013-12-24 10:34 ` Ian Kent 2013-12-27 6:11 ` Dennis Lan (dlan) 0 siblings, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-24 10:34 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Tue, 2013-12-24 at 17:42 +0800, Dennis Lan (dlan) wrote: > On Tue, Dec 24, 2013 at 5:04 PM, Ian Kent <raven@themaw.net> wrote: > > On Tue, 2013-12-24 at 16:38 +0800, Dennis Lan (dlan) wrote: > >> Hi Ian: > >> Do you mind push a temporary branch into your git repo (if you don't > >> want to queue other patches)? > >> That would much convenient for me to test. > > > > Try branch autofs-5.0.public. > > As master and autofs-5.0 branches diverge the autofs-5.0 will be the > > place for version 5.0. > > > > > > Hi Ian > Have problem with branch autofs-5.0.public > most obvious error > 461:Dec 24 17:29:12 ofire automount[11496]: mount(nfs): no hosts available > 462:Dec 24 17:29:12 ofire automount[11496]: dev_ioctl_send_fail: token = 79 Are you sure you're using the autofs-5.0.public branch. That's the error I'd expect to see using master. I put an entry with the same options into a map and tested it. Worked fine for me. What server are you using? What kernel is on the server? rpcbind or portmap? Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-24 10:34 ` Ian Kent @ 2013-12-27 6:11 ` Dennis Lan (dlan) 2013-12-27 6:36 ` Dennis Lan (dlan) 0 siblings, 1 reply; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-27 6:11 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list On Tue, Dec 24, 2013 at 6:34 PM, Ian Kent <raven@themaw.net> wrote: > On Tue, 2013-12-24 at 17:42 +0800, Dennis Lan (dlan) wrote: >> On Tue, Dec 24, 2013 at 5:04 PM, Ian Kent <raven@themaw.net> wrote: >> > On Tue, 2013-12-24 at 16:38 +0800, Dennis Lan (dlan) wrote: >> >> Hi Ian: >> >> Do you mind push a temporary branch into your git repo (if you don't >> >> want to queue other patches)? >> >> That would much convenient for me to test. >> > >> > Try branch autofs-5.0.public. >> > As master and autofs-5.0 branches diverge the autofs-5.0 will be the >> > place for version 5.0. >> > >> > >> >> Hi Ian >> Have problem with branch autofs-5.0.public >> most obvious error >> 461:Dec 24 17:29:12 ofire automount[11496]: mount(nfs): no hosts available >> 462:Dec 24 17:29:12 ofire automount[11496]: dev_ioctl_send_fail: token = 79 > > Are you sure you're using the autofs-5.0.public branch. > That's the error I'd expect to see using master. > yes. it's commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 # FEATURES="keeptemp keepwork" EGIT_BRANCH="autofs-5.0.public" emerge --nodeps -q autofs # cd /var/tmp/portage/net-fs/autofs-9999/work/autofs-9999/ && git log -1 commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 Author: Ian Kent <raven@themaw.net> Date: Fri Dec 27 08:23:47 2013 +0800 also following features are enabled (dmalloc hesiod ldap libtirpc sasl) > I put an entry with the same options into a map and tested it. > Worked fine for me. > > What server are you using? output from the server side: mickeycn ~ # qlist -ICv nfs-u net-fs/nfs-utils-1.2.9 > What kernel is on the server? mickeycn ~ # uname -a Linux mickeycn 3.10.9-gentoo #1 SMP Fri Aug 23 22:37:04 CST 2013 x86_64 Intel(R) Xeon(R) CPU E5410 @ 2.33GHz GenuineIntel GNU/Linux > rpcbind or portmap? I think it‘s rpcbind mickeycn ~ # rc-status |grep rpc rpc.pipefs [ started ] rpc.idmapd [ started ] rpc.statd [ started ] rpcbind [ started ] > > Ian > HI Ian: finally, I have some time to try this.. I have tested with autofs-5.0.7 and no problem when come to mount nfs. but with 5.0.8(using branch autofs-5.0.public), automount crashed (segmentfault) could you show me what's your "automount --version" there? lan details ofire ~ # automount --version Linux automount version 5.0.8 Directories: config dir: /etc/conf.d maps dir: /etc/autofs modules dir: /usr/lib64/autofs Compile options: DISABLE_MOUNT_LOCKING ENABLE_FORCED_SHUTDOWN ENABLE_IGNORE_BUSY_MOUNTS WITH_HESIOD WITH_LDAP WITH_SASL WITH_DMALLOC LIBXML2_WORKAROUND WITH_LIBTIRPC ofire ~ # rc-service autofs restart * Stopping automounter ... [ ok ] * Starting automounter ... [ ok ] ofire ~ # echo ""> /var/log/messages ofire ~ # cat /etc/autofs/auto.misc cd -fstype=iso9660,ro,nosuid,nodev :/dev/cdrom mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis mkyand -ro,soft,intr,nfsvers=3 mickeycn:/home/android winxp -fstype=cifs,credentials=/etc/autofs/auto.auth ://192.168.90.168/share ofire ~ # ls /mnt/misc/mkynfs ^Cls: cannot access /mnt/misc/mkynfs: Interrupted system call (stuck here, since automount crashed, and I have to use "ctrl + c" to terminate "ls") ofire ~ # cat /var/log/messages Dec 27 13:23:43 ofire automount[27788]: st_expire: state 1 path /net Dec 27 13:23:43 ofire automount[27788]: expire_proc: exp_proc = 140379437758208 path /net Dec 27 13:23:43 ofire automount[27788]: expire_cleanup: got thid 140379437758208 path /net stat 0 Dec 27 13:23:43 ofire automount[27788]: expire_cleanup: sigchld: exp 140379437758208 finished, switching from 2 to 1 Dec 27 13:23:43 ofire automount[27788]: st_ready: st_ready(): state = 2 path /net Dec 27 13:23:51 ofire automount[27788]: st_expire: state 1 path /net Dec 27 13:23:51 ofire automount[27788]: expire_proc: exp_proc = 140379437758208 path /net Dec 27 13:23:51 ofire automount[27788]: expire_cleanup: got thid 140379437758208 path /net stat 0 Dec 27 13:23:51 ofire automount[27788]: expire_cleanup: sigchld: exp 140379437758208 finished, switching from 2 to 1 Dec 27 13:23:51 ofire automount[27788]: st_ready: st_ready(): state = 2 path /net Dec 27 13:23:59 ofire automount[27788]: st_expire: state 1 path /net Dec 27 13:23:59 ofire automount[27788]: expire_proc: exp_proc = 140379437758208 path /net Dec 27 13:23:59 ofire automount[27788]: expire_cleanup: got thid 140379437758208 path /net stat 0 Dec 27 13:23:59 ofire automount[27788]: expire_cleanup: sigchld: exp 140379437758208 finished, switching from 2 to 1 Dec 27 13:23:59 ofire automount[27788]: st_ready: st_ready(): state = 2 path /net Dec 27 13:24:01 ofire automount[27788]: handle_packet: type = 3 Dec 27 13:24:01 ofire automount[27788]: handle_packet_missing_indirect: token 42, name mkynfs, request pid 27808 Dec 27 13:24:01 ofire automount[27788]: attempting to mount entry /mnt/misc/mkynfs Dec 27 13:24:01 ofire automount[27788]: lookup_mount: lookup(file): looking up mkynfs Dec 27 13:24:01 ofire automount[27788]: lookup_mount: lookup(file): mkynfs -> -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis Dec 27 13:24:01 ofire automount[27788]: parse_mount: parse(sun): expanded entry: -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis Dec 27 13:24:01 ofire automount[27788]: parse_mount: parse(sun): gathered options: ro,soft,intr,nfsvers=3 Dec 27 13:24:01 ofire automount[27788]: parse_mount: parse(sun): dequote("192.168.90.12:/home/dennis") -> 192.168.90.12:/home/dennis Dec 27 13:24:01 ofire automount[27788]: parse_mount: parse(sun): core of entry: options=ro,soft,intr,nfsvers=3, loc=192.168.90.12:/home/dennis Dec 27 13:24:01 ofire automount[27788]: sun_mount: parse(sun): mounting root /mnt/misc, mountpoint mkynfs, what 192.168.90.12:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=3 Dec 27 13:24:01 ofire automount[27788]: mount_mount: mount(nfs): root=/mnt/misc name=mkynfs what=192.168.90.12:/home/dennis, fstype=nfs, options=ro,soft,intr,nfsvers=3 Dec 27 13:24:01 ofire automount[27788]: mount_mount: mount(nfs): nfs options="ro,soft,intr,nfsvers=3", nobind=0, nosymlink=0, ro=1 Dec 27 13:24:01 ofire automount[27788]: get_nfs_info: called with host 192.168.90.12(192.168.90.12) proto 6 version 0x20 Dec 27 13:24:01 ofire automount[27788]: get_nfs_info: called with host 192.168.90.12(192.168.90.12) proto 17 version 0x20 Dec 27 13:24:01 ofire kernel: [14162.515864] automount[27809]: segfault at 0 ip (null) sp 00007faca284ec48 error 14 ofire ~ # mount -t nfs -o nfsvers=4 mickeycn:/home/dennis /mnt/nfs/ ofire ~ # grep nfs /proc/mounts rpc_pipefs /var/lib/nfs/rpc_pipefs rpc_pipefs rw,relatime 0 0 nfsd /proc/fs/nfsd nfsd rw,nosuid,nodev,noexec,relatime 0 0 mickeycn:/home/dennis /mnt/nfs nfs4 rw,relatime,vers=4.0,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=192.168.90.122,local_lock=none,addr=192.168.90.12 0 0 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-27 6:11 ` Dennis Lan (dlan) @ 2013-12-27 6:36 ` Dennis Lan (dlan) 2013-12-27 7:30 ` Dennis Lan (dlan) 2013-12-27 8:50 ` Ian Kent 0 siblings, 2 replies; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-27 6:36 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list Hi Ian I've tested with various USE combinations, still got segfault err. wi all USE="-dmalloc -hesiod -ldap -libtirpc -mount-locking -sasl" disabled, with libtirpc en/disabled. Next, I may need a few more time to setup gdb to investigate this.. also this patch needed to fix compile error while with libtirpc disabled, diff --git a/lib/rpc_subs.c b/lib/rpc_subs.c index aeece1e..a003074 100644 --- a/lib/rpc_subs.c +++ b/lib/rpc_subs.c @@ -235,7 +235,8 @@ static int rpc_do_create_client(struct sockaddr *addr, struct conn_info *info, i return 0; } static int rpc_getport(struct conn_info *info, - struct pmap *parms, CLIENT *client) + struct pmap *parms, CLIENT *client, + unsigned short *port) { [1] commit 076adfb0718e4b8a15ec11bf62597371ceb92399 Author: Ian Kent <ikent@redhat.com> Date: Mon Nov 18 12:15:52 2013 +0800 autofs-5.0.8 - fix ipv6 libtirpc getport ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-27 6:36 ` Dennis Lan (dlan) @ 2013-12-27 7:30 ` Dennis Lan (dlan) 2013-12-27 8:56 ` Ian Kent 2013-12-29 11:36 ` Ian Kent 2013-12-27 8:50 ` Ian Kent 1 sibling, 2 replies; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-27 7:30 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list sorry, I was not accurate about the failure cases. using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 snip from file /etc/autofs/auto.misc mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis with libtirpc enabled (all other features disabled),[1] "ls /mnt/misc/mkynfs" lead to automount segfault "ls /mnt/misc/mkydns" automount fail (no crash), but report "no hosts available" with libtirpc disabled (all other features disabled)[2] "ls /mnt/misc/mkynfs" automount fail (no crash), report "no hosts available" "ls /mnt/misc/mkydns" works fine [1] Dec 27 15:08:19 ofire automount[32570]: handle_packet: type = 3 Dec 27 15:08:19 ofire automount[32570]: handle_packet_missing_indirect: token 106, name mkydns, request pid 32583 Dec 27 15:08:19 ofire automount[32570]: attempting to mount entry /mnt/misc/mkydns Dec 27 15:08:19 ofire automount[32570]: lookup_mount: lookup(file): looking up mkydns Dec 27 15:08:19 ofire automount[32570]: lookup_mount: lookup(file): mkydns -> -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): expanded entry: -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): gathered options: ro,soft,intr,nfsvers=4 Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): dequote("mickeycn:/home/dennis") -> mickeycn:/home/dennis Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): core of entry: options=ro,soft,intr,nfsvers=4, loc=mickeycn:/home/dennis Dec 27 15:08:19 ofire automount[32570]: sun_mount: parse(sun): mounting root /mnt/misc, mountpoint mkydns, what mickeycn:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=4 Dec 27 15:08:19 ofire automount[32570]: mount_mount: mount(nfs): root=/mnt/misc name=mkydns what=mickeycn:/home/dennis, fstype=nfs, options=ro,soft,intr,nfsvers=4 Dec 27 15:08:19 ofire automount[32570]: mount_mount: mount(nfs): nfs options="ro,soft,intr,nfsvers=4", nobind=0, nosymlink=0, ro=1 Dec 27 15:08:19 ofire automount[32570]: get_nfs_info: called with host mickeycn(192.168.90.12) proto 6 version 0x40 Dec 27 15:08:19 ofire automount[32570]: mount(nfs): no hosts available Dec 27 15:08:19 ofire automount[32570]: dev_ioctl_send_fail: token = 106 Dec 27 15:08:19 ofire automount[32570]: failed to mount /mnt/misc/mkydns Dec 27 15:08:19 ofire automount[32570]: handle_packet: type = 3 Dec 27 15:08:19 ofire automount[32570]: handle_packet_missing_indirect: token 107, name mkydns, request pid 32583 Dec 27 15:08:19 ofire automount[32570]: dev_ioctl_send_fail: token = 107 Dec 27 15:08:26 ofire automount[32570]: st_expire: state 1 path /net Dec 27 15:08:26 ofire automount[32570]: expire_proc: exp_proc = 140502330578688 path /net Dec 27 15:08:26 ofire automount[32570]: expire_cleanup: got thid 140502330578688 path /net stat 0 Dec 27 15:08:26 ofire automount[32570]: expire_cleanup: sigchld: exp 140502330578688 finished, switching from 2 to 1 Dec 27 15:08:26 ofire automount[32570]: st_ready: st_ready(): state = 2 path /net Dec 27 15:08:26 ofire automount[32570]: handle_packet: type = 3 Dec 27 15:08:26 ofire automount[32570]: handle_packet_missing_indirect: token 108, name mkynfs, request pid 32586 Dec 27 15:08:26 ofire automount[32570]: attempting to mount entry /mnt/misc/mkynfs Dec 27 15:08:26 ofire automount[32570]: lookup_mount: lookup(file): looking up mkynfs Dec 27 15:08:26 ofire automount[32570]: lookup_mount: lookup(file): mkynfs -> -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): expanded entry: -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): gathered options: ro,soft,intr,nfsvers=3 Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): dequote("192.168.90.12:/home/dennis") -> 192.168.90.12:/home/dennis Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): core of entry: options=ro,soft,intr,nfsvers=3, loc=192.168.90.12:/home/dennis Dec 27 15:08:26 ofire automount[32570]: sun_mount: parse(sun): mounting root /mnt/misc, mountpoint mkynfs, what 192.168.90.12:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=3 Dec 27 15:08:26 ofire automount[32570]: mount_mount: mount(nfs): root=/mnt/misc name=mkynfs what=192.168.90.12:/home/dennis, fstype=nfs, options=ro,soft,intr,nfsvers=3 Dec 27 15:08:26 ofire automount[32570]: mount_mount: mount(nfs): nfs options="ro,soft,intr,nfsvers=3", nobind=0, nosymlink=0, ro=1 Dec 27 15:08:26 ofire automount[32570]: get_nfs_info: called with host 192.168.90.12(192.168.90.12) proto 6 version 0x20 Dec 27 15:08:26 ofire automount[32570]: get_nfs_info: called with host 192.168.90.12(192.168.90.12) proto 17 version 0x20 Dec 27 15:08:26 ofire kernel: [20427.317530] automount[32587]: segfault at 0 ip (null) sp 00007fc93f808c88 error 14 [2] log Dec 27 15:16:52 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:16:52 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:16:52 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:16:52 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:16:52 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net Dec 27 15:16:53 ofire automount[3879]: handle_packet: type = 3 Dec 27 15:16:53 ofire automount[3879]: handle_packet_missing_indirect: token 119, name mkydns, request pid 3898 Dec 27 15:16:53 ofire automount[3879]: attempting to mount entry /mnt/misc/mkydns Dec 27 15:16:53 ofire automount[3879]: lookup_mount: lookup(file): looking up mkydns Dec 27 15:16:53 ofire automount[3879]: lookup_mount: lookup(file): mkydns -> -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): expanded entry: -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): gathered options: ro,soft,intr,nfsvers=4 Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): dequote("mickeycn:/home/dennis") -> mickeycn:/home/dennis Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): core of entry: options=ro,soft,intr,nfsvers=4, loc=mickeycn:/home/dennis Dec 27 15:16:53 ofire automount[3879]: sun_mount: parse(sun): mounting root /mnt/misc, mountpoint mkydns, what mickeycn:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=4 Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): root=/mnt/misc name=mkydns what=mickeycn:/home/dennis, fstype=nfs, options=ro,soft,intr,nfsvers=4 Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): nfs options="ro,soft,intr,nfsvers=4", nobind=0, nosymlink=0, ro=1 Dec 27 15:16:53 ofire automount[3879]: get_nfs_info: called with host mickeycn(192.168.90.12) proto 6 version 0x40 Dec 27 15:16:53 ofire automount[3879]: get_nfs_info: nfs v4 rpc ping time: 0.000599 Dec 27 15:16:53 ofire automount[3879]: get_nfs_info: host mickeycn cost 598 weight 0 Dec 27 15:16:53 ofire automount[3879]: prune_host_list: selected subset of hosts that support NFS4 over TCP Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): calling mkdir_path /mnt/misc/mkydns Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): calling mount -t nfs -s -o ro,soft,intr,nfsvers=4 mickeycn:/home/dennis /mnt/misc/mkydns Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): mounted mickeycn:/home/dennis on /mnt/misc/mkydns Dec 27 15:16:53 ofire automount[3879]: dev_ioctl_send_ready: token = 119 Dec 27 15:16:53 ofire automount[3879]: mounted /mnt/misc/mkydns Dec 27 15:17:00 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:17:00 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:17:00 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:17:00 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:17:00 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net Dec 27 15:17:08 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:17:08 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:17:08 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:17:08 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:17:08 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net Dec 27 15:17:16 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:17:16 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:17:16 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:17:16 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:17:16 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net Dec 27 15:17:17 ofire automount[3879]: handle_packet: type = 3 Dec 27 15:17:17 ofire automount[3879]: handle_packet_missing_indirect: token 120, name mkynfs, request pid 3918 Dec 27 15:17:17 ofire automount[3879]: attempting to mount entry /mnt/misc/mkynfs Dec 27 15:17:17 ofire automount[3879]: lookup_mount: lookup(file): looking up mkynfs Dec 27 15:17:17 ofire automount[3879]: lookup_mount: lookup(file): mkynfs -> -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): expanded entry: -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): gathered options: ro,soft,intr,nfsvers=3 Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): dequote("192.168.90.12:/home/dennis") -> 192.168.90.12:/home/dennis Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): core of entry: options=ro,soft,intr,nfsvers=3, loc=192.168.90.12:/home/dennis Dec 27 15:17:17 ofire automount[3879]: sun_mount: parse(sun): mounting root /mnt/misc, mountpoint mkynfs, what 192.168.90.12:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=3 Dec 27 15:17:17 ofire automount[3879]: mount_mount: mount(nfs): root=/mnt/misc name=mkynfs what=192.168.90.12:/home/dennis, fstype=nfs, options=ro,soft,intr,nfsvers=3 Dec 27 15:17:17 ofire automount[3879]: mount_mount: mount(nfs): nfs options="ro,soft,intr,nfsvers=3", nobind=0, nosymlink=0, ro=1 Dec 27 15:17:17 ofire automount[3879]: get_nfs_info: called with host 192.168.90.12(192.168.90.12) proto 6 version 0x20 Dec 27 15:17:17 ofire automount[3879]: get_nfs_info: called with host 192.168.90.12(192.168.90.12) proto 17 version 0x20 Dec 27 15:17:20 ofire automount[3879]: mount(nfs): no hosts available Dec 27 15:17:20 ofire automount[3879]: dev_ioctl_send_fail: token = 120 Dec 27 15:17:20 ofire automount[3879]: failed to mount /mnt/misc/mkynfs Dec 27 15:17:20 ofire automount[3879]: handle_packet: type = 3 Dec 27 15:17:20 ofire automount[3879]: handle_packet_missing_indirect: token 121, name mkynfs, request pid 3918 Dec 27 15:17:20 ofire automount[3879]: dev_ioctl_send_fail: token = 121 Dec 27 15:17:24 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:17:24 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:17:24 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:17:24 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:17:24 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net Dec 27 15:17:32 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:17:32 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:17:32 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:17:32 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:17:32 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net Dec 27 15:17:40 ofire automount[3879]: st_expire: state 1 path /net Dec 27 15:17:40 ofire automount[3879]: expire_proc: exp_proc = 139809608951552 path /net Dec 27 15:17:40 ofire automount[3879]: expire_cleanup: got thid 139809608951552 path /net stat 0 Dec 27 15:17:40 ofire automount[3879]: expire_cleanup: sigchld: exp 139809608951552 finished, switching from 2 to 1 Dec 27 15:17:40 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-27 7:30 ` Dennis Lan (dlan) @ 2013-12-27 8:56 ` Ian Kent 2013-12-28 2:41 ` Ian Kent 2013-12-29 11:36 ` Ian Kent 1 sibling, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-27 8:56 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Fri, 2013-12-27 at 15:30 +0800, Dennis Lan (dlan) wrote: > sorry, I was not accurate about the failure cases. > > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 > > snip from file /etc/autofs/auto.misc > mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > > with libtirpc enabled (all other features disabled),[1] > "ls /mnt/misc/mkynfs" lead to automount segfault > "ls /mnt/misc/mkydns" automount fail (no crash), but report "no hosts available" Right, I think I've worked out the issue with this second case. I'll push my recent changes to autofs-5.0.public once I've had a look at the segfault issue. > > with libtirpc disabled (all other features disabled)[2] > "ls /mnt/misc/mkynfs" automount fail (no crash), report "no hosts available" > "ls /mnt/misc/mkydns" works fine Mmmm .. I'll need to duplicate this and have a look. The libtirpc disabled case shouldn't really have changed .... Let me work through these logs and see if I can spot anything obvious. > > [1] > Dec 27 15:08:19 ofire automount[32570]: handle_packet: type = 3 > Dec 27 15:08:19 ofire automount[32570]: > handle_packet_missing_indirect: token 106, name mkydns, request pid > 32583 > Dec 27 15:08:19 ofire automount[32570]: attempting to mount entry > /mnt/misc/mkydns > Dec 27 15:08:19 ofire automount[32570]: lookup_mount: lookup(file): > looking up mkydns > Dec 27 15:08:19 ofire automount[32570]: lookup_mount: lookup(file): > mkydns -> -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): > expanded entry: -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): > gathered options: ro,soft,intr,nfsvers=4 > Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): > dequote("mickeycn:/home/dennis") -> mickeycn:/home/dennis > Dec 27 15:08:19 ofire automount[32570]: parse_mount: parse(sun): core > of entry: options=ro,soft,intr,nfsvers=4, loc=mickeycn:/home/dennis > Dec 27 15:08:19 ofire automount[32570]: sun_mount: parse(sun): > mounting root /mnt/misc, mountpoint mkydns, what > mickeycn:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=4 > Dec 27 15:08:19 ofire automount[32570]: mount_mount: mount(nfs): > root=/mnt/misc name=mkydns what=mickeycn:/home/dennis, fstype=nfs, > options=ro,soft,intr,nfsvers=4 > Dec 27 15:08:19 ofire automount[32570]: mount_mount: mount(nfs): nfs > options="ro,soft,intr,nfsvers=4", nobind=0, nosymlink=0, ro=1 > Dec 27 15:08:19 ofire automount[32570]: get_nfs_info: called with host > mickeycn(192.168.90.12) proto 6 version 0x40 > Dec 27 15:08:19 ofire automount[32570]: mount(nfs): no hosts available > Dec 27 15:08:19 ofire automount[32570]: dev_ioctl_send_fail: token = 106 > Dec 27 15:08:19 ofire automount[32570]: failed to mount /mnt/misc/mkydns > Dec 27 15:08:19 ofire automount[32570]: handle_packet: type = 3 > Dec 27 15:08:19 ofire automount[32570]: > handle_packet_missing_indirect: token 107, name mkydns, request pid > 32583 > Dec 27 15:08:19 ofire automount[32570]: dev_ioctl_send_fail: token = 107 > Dec 27 15:08:26 ofire automount[32570]: st_expire: state 1 path /net > Dec 27 15:08:26 ofire automount[32570]: expire_proc: exp_proc = > 140502330578688 path /net > Dec 27 15:08:26 ofire automount[32570]: expire_cleanup: got thid > 140502330578688 path /net stat 0 > Dec 27 15:08:26 ofire automount[32570]: expire_cleanup: sigchld: exp > 140502330578688 finished, switching from 2 to 1 > Dec 27 15:08:26 ofire automount[32570]: st_ready: st_ready(): state = > 2 path /net > Dec 27 15:08:26 ofire automount[32570]: handle_packet: type = 3 > Dec 27 15:08:26 ofire automount[32570]: > handle_packet_missing_indirect: token 108, name mkynfs, request pid > 32586 > Dec 27 15:08:26 ofire automount[32570]: attempting to mount entry > /mnt/misc/mkynfs > Dec 27 15:08:26 ofire automount[32570]: lookup_mount: lookup(file): > looking up mkynfs > Dec 27 15:08:26 ofire automount[32570]: lookup_mount: lookup(file): > mkynfs -> -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): > expanded entry: -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): > gathered options: ro,soft,intr,nfsvers=3 > Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): > dequote("192.168.90.12:/home/dennis") -> 192.168.90.12:/home/dennis > Dec 27 15:08:26 ofire automount[32570]: parse_mount: parse(sun): core > of entry: options=ro,soft,intr,nfsvers=3, > loc=192.168.90.12:/home/dennis > Dec 27 15:08:26 ofire automount[32570]: sun_mount: parse(sun): > mounting root /mnt/misc, mountpoint mkynfs, what > 192.168.90.12:/home/dennis, fstype nfs, options ro,soft,intr,nfsvers=3 > Dec 27 15:08:26 ofire automount[32570]: mount_mount: mount(nfs): > root=/mnt/misc name=mkynfs what=192.168.90.12:/home/dennis, > fstype=nfs, options=ro,soft,intr,nfsvers=3 > Dec 27 15:08:26 ofire automount[32570]: mount_mount: mount(nfs): nfs > options="ro,soft,intr,nfsvers=3", nobind=0, nosymlink=0, ro=1 > Dec 27 15:08:26 ofire automount[32570]: get_nfs_info: called with host > 192.168.90.12(192.168.90.12) proto 6 version 0x20 > Dec 27 15:08:26 ofire automount[32570]: get_nfs_info: called with host > 192.168.90.12(192.168.90.12) proto 17 version 0x20 > Dec 27 15:08:26 ofire kernel: [20427.317530] automount[32587]: > segfault at 0 ip (null) sp 00007fc93f808c88 error 14 > > > [2] log > Dec 27 15:16:52 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:16:52 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:16:52 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:16:52 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:16:52 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net > Dec 27 15:16:53 ofire automount[3879]: handle_packet: type = 3 > Dec 27 15:16:53 ofire automount[3879]: handle_packet_missing_indirect: > token 119, name mkydns, request pid 3898 > Dec 27 15:16:53 ofire automount[3879]: attempting to mount entry > /mnt/misc/mkydns > Dec 27 15:16:53 ofire automount[3879]: lookup_mount: lookup(file): > looking up mkydns > Dec 27 15:16:53 ofire automount[3879]: lookup_mount: lookup(file): > mkydns -> -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): > expanded entry: -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): > gathered options: ro,soft,intr,nfsvers=4 > Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): > dequote("mickeycn:/home/dennis") -> mickeycn:/home/dennis > Dec 27 15:16:53 ofire automount[3879]: parse_mount: parse(sun): core > of entry: options=ro,soft,intr,nfsvers=4, loc=mickeycn:/home/dennis > Dec 27 15:16:53 ofire automount[3879]: sun_mount: parse(sun): mounting > root /mnt/misc, mountpoint mkydns, what mickeycn:/home/dennis, fstype > nfs, options ro,soft,intr,nfsvers=4 > Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): > root=/mnt/misc name=mkydns what=mickeycn:/home/dennis, fstype=nfs, > options=ro,soft,intr,nfsvers=4 > Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): nfs > options="ro,soft,intr,nfsvers=4", nobind=0, nosymlink=0, ro=1 > Dec 27 15:16:53 ofire automount[3879]: get_nfs_info: called with host > mickeycn(192.168.90.12) proto 6 version 0x40 > Dec 27 15:16:53 ofire automount[3879]: get_nfs_info: nfs v4 rpc ping > time: 0.000599 > Dec 27 15:16:53 ofire automount[3879]: get_nfs_info: host mickeycn > cost 598 weight 0 > Dec 27 15:16:53 ofire automount[3879]: prune_host_list: selected > subset of hosts that support NFS4 over TCP > Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): > calling mkdir_path /mnt/misc/mkydns > Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): > calling mount -t nfs -s -o ro,soft,intr,nfsvers=4 > mickeycn:/home/dennis /mnt/misc/mkydns > Dec 27 15:16:53 ofire automount[3879]: mount_mount: mount(nfs): > mounted mickeycn:/home/dennis on /mnt/misc/mkydns > Dec 27 15:16:53 ofire automount[3879]: dev_ioctl_send_ready: token = 119 > Dec 27 15:16:53 ofire automount[3879]: mounted /mnt/misc/mkydns > Dec 27 15:17:00 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:17:00 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:17:00 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:17:00 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:17:00 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net > Dec 27 15:17:08 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:17:08 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:17:08 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:17:08 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:17:08 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net > Dec 27 15:17:16 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:17:16 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:17:16 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:17:16 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:17:16 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net > Dec 27 15:17:17 ofire automount[3879]: handle_packet: type = 3 > Dec 27 15:17:17 ofire automount[3879]: handle_packet_missing_indirect: > token 120, name mkynfs, request pid 3918 > Dec 27 15:17:17 ofire automount[3879]: attempting to mount entry > /mnt/misc/mkynfs > Dec 27 15:17:17 ofire automount[3879]: lookup_mount: lookup(file): > looking up mkynfs > Dec 27 15:17:17 ofire automount[3879]: lookup_mount: lookup(file): > mkynfs -> -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): > expanded entry: -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): > gathered options: ro,soft,intr,nfsvers=3 > Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): > dequote("192.168.90.12:/home/dennis") -> 192.168.90.12:/home/dennis > Dec 27 15:17:17 ofire automount[3879]: parse_mount: parse(sun): core > of entry: options=ro,soft,intr,nfsvers=3, > loc=192.168.90.12:/home/dennis > Dec 27 15:17:17 ofire automount[3879]: sun_mount: parse(sun): mounting > root /mnt/misc, mountpoint mkynfs, what 192.168.90.12:/home/dennis, > fstype nfs, options ro,soft,intr,nfsvers=3 > Dec 27 15:17:17 ofire automount[3879]: mount_mount: mount(nfs): > root=/mnt/misc name=mkynfs what=192.168.90.12:/home/dennis, > fstype=nfs, options=ro,soft,intr,nfsvers=3 > Dec 27 15:17:17 ofire automount[3879]: mount_mount: mount(nfs): nfs > options="ro,soft,intr,nfsvers=3", nobind=0, nosymlink=0, ro=1 > Dec 27 15:17:17 ofire automount[3879]: get_nfs_info: called with host > 192.168.90.12(192.168.90.12) proto 6 version 0x20 > Dec 27 15:17:17 ofire automount[3879]: get_nfs_info: called with host > 192.168.90.12(192.168.90.12) proto 17 version 0x20 > Dec 27 15:17:20 ofire automount[3879]: mount(nfs): no hosts available > Dec 27 15:17:20 ofire automount[3879]: dev_ioctl_send_fail: token = 120 > Dec 27 15:17:20 ofire automount[3879]: failed to mount /mnt/misc/mkynfs > Dec 27 15:17:20 ofire automount[3879]: handle_packet: type = 3 > Dec 27 15:17:20 ofire automount[3879]: handle_packet_missing_indirect: > token 121, name mkynfs, request pid 3918 > Dec 27 15:17:20 ofire automount[3879]: dev_ioctl_send_fail: token = 121 > Dec 27 15:17:24 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:17:24 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:17:24 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:17:24 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:17:24 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net > Dec 27 15:17:32 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:17:32 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:17:32 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:17:32 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:17:32 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net > Dec 27 15:17:40 ofire automount[3879]: st_expire: state 1 path /net > Dec 27 15:17:40 ofire automount[3879]: expire_proc: exp_proc = > 139809608951552 path /net > Dec 27 15:17:40 ofire automount[3879]: expire_cleanup: got thid > 139809608951552 path /net stat 0 > Dec 27 15:17:40 ofire automount[3879]: expire_cleanup: sigchld: exp > 139809608951552 finished, switching from 2 to 1 > Dec 27 15:17:40 ofire automount[3879]: st_ready: st_ready(): state = 2 path /net ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-27 8:56 ` Ian Kent @ 2013-12-28 2:41 ` Ian Kent 2013-12-28 12:09 ` Dennis Lan (dlan) 0 siblings, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-28 2:41 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Fri, 2013-12-27 at 16:56 +0800, Ian Kent wrote: > On Fri, 2013-12-27 at 15:30 +0800, Dennis Lan (dlan) wrote: > > sorry, I was not accurate about the failure cases. > > > > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 > > > > snip from file /etc/autofs/auto.misc > > mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > > mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > > > > with libtirpc enabled (all other features disabled),[1] > > "ls /mnt/misc/mkynfs" lead to automount segfault > > "ls /mnt/misc/mkydns" automount fail (no crash), but report "no hosts available" > > Right, I think I've worked out the issue with this second case. > I'll push my recent changes to autofs-5.0.public once I've had a look at > the segfault issue. > > > > > with libtirpc disabled (all other features disabled)[2] > > "ls /mnt/misc/mkynfs" automount fail (no crash), report "no hosts available" > > "ls /mnt/misc/mkydns" works fine > > Mmmm .. I'll need to duplicate this and have a look. > The libtirpc disabled case shouldn't really have changed .... > > Let me work through these logs and see if I can spot anything obvious. I've updated the autofs-5.0.public branch. Can you test it please. Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-28 2:41 ` Ian Kent @ 2013-12-28 12:09 ` Dennis Lan (dlan) 2013-12-29 11:14 ` Ian Kent 0 siblings, 1 reply; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-28 12:09 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list On Sat, Dec 28, 2013 at 10:41 AM, Ian Kent <raven@themaw.net> wrote: >> > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 > I've updated the autofs-5.0.public branch. > Can you test it please. > > Ian > Hi Ian: Did you only fix the problem while libtirpc is disabled, as I looking at your commits? I've tested the case with libtirpc disabled, all works fine (test both nfs mount with nfsvers=3,4) but with libtirpc enabled, fail as same previous error Lan ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-28 12:09 ` Dennis Lan (dlan) @ 2013-12-29 11:14 ` Ian Kent 2013-12-29 11:26 ` Ian Kent 0 siblings, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-29 11:14 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Sat, 2013-12-28 at 20:09 +0800, Dennis Lan (dlan) wrote: > On Sat, Dec 28, 2013 at 10:41 AM, Ian Kent <raven@themaw.net> wrote: > > >> > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 > > I've updated the autofs-5.0.public branch. > > Can you test it please. > > > > Ian > > > Hi Ian: > Did you only fix the problem while libtirpc is disabled, as I looking > at your commits? > I've tested the case with libtirpc disabled, all works fine (test both > nfs mount with nfsvers=3,4) > > but with libtirpc enabled, fail as same previous error I'm not able to reproduce those problems with the current source. Tell me more (maybe again) about the server side. Commit ec267c2c deals with a libtirpc failure that would result in the "no hosts found" message and I'm not sure you had commit 7f7b730e either which also caused failures. Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-29 11:14 ` Ian Kent @ 2013-12-29 11:26 ` Ian Kent 2013-12-30 7:38 ` Dennis Lan (dlan) 0 siblings, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-29 11:26 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Sun, 2013-12-29 at 19:14 +0800, Ian Kent wrote: > On Sat, 2013-12-28 at 20:09 +0800, Dennis Lan (dlan) wrote: > > On Sat, Dec 28, 2013 at 10:41 AM, Ian Kent <raven@themaw.net> wrote: > > > > >> > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 > > > I've updated the autofs-5.0.public branch. > > > Can you test it please. > > > > > > Ian > > > > > Hi Ian: > > Did you only fix the problem while libtirpc is disabled, as I looking > > at your commits? > > I've tested the case with libtirpc disabled, all works fine (test both > > nfs mount with nfsvers=3,4) > > > > but with libtirpc enabled, fail as same previous error > > I'm not able to reproduce those problems with the current source. > Tell me more (maybe again) about the server side. Perhaps you could send a gdb backtrace, that might give ne a clue. Run gdb on the core and capture the output of "thr a a bt". > > Commit ec267c2c deals with a libtirpc failure that would result in the > "no hosts found" message and I'm not sure you had commit 7f7b730e either > which also caused failures. > > Ian > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-29 11:26 ` Ian Kent @ 2013-12-30 7:38 ` Dennis Lan (dlan) 0 siblings, 0 replies; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-30 7:38 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list On Sun, Dec 29, 2013 at 7:26 PM, Ian Kent <raven@themaw.net> wrote: > On Sun, 2013-12-29 at 19:14 +0800, Ian Kent wrote: >> On Sat, 2013-12-28 at 20:09 +0800, Dennis Lan (dlan) wrote: >> > On Sat, Dec 28, 2013 at 10:41 AM, Ian Kent <raven@themaw.net> wrote: >> > >> > >> > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 >> > > I've updated the autofs-5.0.public branch. >> > > Can you test it please. >> > > >> > > Ian >> > > >> > Hi Ian: >> > Did you only fix the problem while libtirpc is disabled, as I looking >> > at your commits? >> > I've tested the case with libtirpc disabled, all works fine (test both >> > nfs mount with nfsvers=3,4) >> > >> > but with libtirpc enabled, fail as same previous error >> >> I'm not able to reproduce those problems with the current source. >> Tell me more (maybe again) about the server side. > what more do you want to know? it's also a gentoo system, using kernel 3.10.9-gentoo, server nfs-utils-1.2.9 > Perhaps you could send a gdb backtrace, that might give ne a clue. > Run gdb on the core and capture the output of "thr a a bt". > yes, here it is Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ff0baf78700 (LWP 23483)] 0x0000000000000000 in ?? () (gdb) backtrace #0 0x0000000000000000 in ?? () #1 0x00007ff0b7898d16 in clnt_vc_call (cl=0x7ff0bafed200, proc=3, xdr_args=0x7ff0b78a1974 <xdr_rpcb>, args_ptr=0x7ff0baf6fe50, xdr_results=0x7ff0ba0c6a10 <xdr_wrapstring>, results_ptr=0x7ff0baf6fdd8, timeout=...) at clnt_vc.c:372 #2 0x00007ff0b67f4952 in rpc_rpcb_getport (client=0x7ff0bafed200, parms=0x7ff0baf6fe50, timeout=..., port=0x7ff0baf700f8) at rpc_subs.c:505 #3 0x00007ff0b67f4b7e in rpc_getport (info=0x7ff0baf6fef0, parms=0x7ff0baf70020, client=0x7ff0bafed200, port=0x7ff0baf700f8) at rpc_subs.c:579 #4 0x00007ff0b67f562d in rpc_portmap_getport (info=0x7ff0baf70140, parms=0x7ff0baf70020, port=0x7ff0baf700f8) at rpc_subs.c:927 #5 0x00007ff0b67f1c13 in get_nfs_info (logopt=1, host=0x7ff0bafdd600, pm_info=0x7ff0baf70140, rpc_info=0x7ff0baf700e0, proto=6, version=32, port=0) at replicated.c:535 #6 0x00007ff0b67f2303 in get_vers_and_cost (logopt=1, host=0x7ff0bafdd600, version=35, port=-1) at replicated.c:686 #7 0x00007ff0b67f2ba0 in prune_host_list (logopt=1, list=0x7ff0baf70348, vers=35, port=-1) at replicated.c:910 #8 0x00007ff0b67f0319 in mount_mount (ap=0x7ff0bafd9600, root=0x7ff0bafeaeb0 "/mnt/misc", name=0x7ff0baf71500 "mkynfs1", name_len=7, what=0x7ff0baf714d0 "192.168.90.12:/home/dennis", fstype=0x7ff0b6a3ff8e "nfs", options=0x7ff0baf71520 "ro,soft,intr,nfsvers=3", context=0x7ff0bafe2e00) at mount_nfs.c:233 #9 0x00007ff0b6a26029 in sun_mount (ap=0x7ff0bafd9600, root=0x7ff0bafeaeb0 "/mnt/misc", name=0x7ff0baf75940 "mkynfs1", namelen=7, loc=0x7ff0bafe2780 "192.168.90.12:/home/dennis", loclen=26, options=0x7ff0baf71520 "ro,soft,intr,nfsvers=3", ctxt=0x7ff0bafe2de0) at parse_sun.c:657 #10 0x00007ff0b6a291c8 in parse_mount (ap=0x7ff0bafd9600, name=0x7ff0baf75940 "mkynfs1", name_len=7, mapent=0x7ff0baf71930 "-ro,soft,intr,nfsvers=3\t\t192.168.90.12:/home/dennis", context=0x7ff0bafe2de0) at parse_sun.c:1595 #11 0x00007ff0b6c5619b in lookup_mount (ap=0x7ff0bafd9600, name=0x7ff0baf76eb0 "mkynfs1", name_len=7, context=0x7ff0bafe2e20) at lookup_file.c:1142 #12 0x00007ff0bb011d52 in do_lookup_mount (ap=0x7ff0bafd9600, map=0x7ff0bafddd80, name=0x7ff0baf76eb0 "mkynfs1", name_len=7) at lookup.c:688 #13 0x00007ff0bb011f09 in lookup_name_file_source_instance (ap=0x7ff0bafd9600, map=0x7ff0bafdda80, name=0x7ff0baf76eb0 "mkynfs1", name_len=7) at lookup.c:728 #14 0x00007ff0bb01269c in lookup_nss_mount (ap=0x7ff0bafd9600, source=0x0, name=0x7ff0baf76eb0 "mkynfs1", name_len=7) at lookup.c:920 #15 0x00007ff0bb007c2e in do_mount_indirect (arg=0x7ff0bae75000) at indirect.c:776 #16 0x00007ff0babbd013 in start_thread () from /lib64/libpthread.so.0 #17 0x00007ff0ba0989dd in clone () from /lib64/libc.so.6 >> >> Commit ec267c2c deals with a libtirpc failure that would result in the >> "no hosts found" message and I'm not sure you had commit 7f7b730e either >> which also caused failures. >> I'm testing autofs-5.0.public branch (commit: 3d4c9d156c065afd0b38491cec4367b1ecbae24a) previous report based on (e7ada505a83871922a588d50da06d02000325f1a) so, yes, they all include ec267c2c and 7f7b730e 0 >> Ian >> > > On Sun, Dec 29, 2013 at 7:36 PM, Ian Kent <raven@themaw.net> wrote: > On Fri, 2013-12-27 at 15:30 +0800, Dennis Lan (dlan) wrote: >> sorry, I was not accurate about the failure cases. >> >> using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 >> >> snip from file /etc/autofs/auto.misc >> mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis >> mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis >> >> with libtirpc enabled (all other features disabled),[1] >> "ls /mnt/misc/mkynfs" lead to automount segfault >> "ls /mnt/misc/mkydns" automount fail (no crash), but report "no hosts available" >> >> with libtirpc disabled (all other features disabled)[2] >> "ls /mnt/misc/mkynfs" automount fail (no crash), report "no hosts available" >> "ls /mnt/misc/mkydns" works fine > > What exactly does "all other features disabled" mean from a configure > POV. I always use --disable-mount-locking and --enable-ignore-busy, > always. > > Maybe that's something to do with the problem your seeing ..... > > Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-27 7:30 ` Dennis Lan (dlan) 2013-12-27 8:56 ` Ian Kent @ 2013-12-29 11:36 ` Ian Kent 2013-12-30 7:44 ` Dennis Lan (dlan) 1 sibling, 1 reply; 22+ messages in thread From: Ian Kent @ 2013-12-29 11:36 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Fri, 2013-12-27 at 15:30 +0800, Dennis Lan (dlan) wrote: > sorry, I was not accurate about the failure cases. > > using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 > > snip from file /etc/autofs/auto.misc > mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis > mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis > > with libtirpc enabled (all other features disabled),[1] > "ls /mnt/misc/mkynfs" lead to automount segfault > "ls /mnt/misc/mkydns" automount fail (no crash), but report "no hosts available" > > with libtirpc disabled (all other features disabled)[2] > "ls /mnt/misc/mkynfs" automount fail (no crash), report "no hosts available" > "ls /mnt/misc/mkydns" works fine What exactly does "all other features disabled" mean from a configure POV. I always use --disable-mount-locking and --enable-ignore-busy, always. Maybe that's something to do with the problem your seeing ..... Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-29 11:36 ` Ian Kent @ 2013-12-30 7:44 ` Dennis Lan (dlan) 0 siblings, 0 replies; 22+ messages in thread From: Dennis Lan (dlan) @ 2013-12-30 7:44 UTC (permalink / raw) To: Ian Kent; +Cc: autofs mailing list On Sun, Dec 29, 2013 at 7:36 PM, Ian Kent <raven@themaw.net> wrote: > On Fri, 2013-12-27 at 15:30 +0800, Dennis Lan (dlan) wrote: >> sorry, I was not accurate about the failure cases. >> >> using commit ec267c2c406256e401540e5bc890b2e0c2ff6c35 >> >> snip from file /etc/autofs/auto.misc >> mkynfs -ro,soft,intr,nfsvers=3 192.168.90.12:/home/dennis >> mkydns -ro,soft,intr,nfsvers=4 mickeycn:/home/dennis >> >> with libtirpc enabled (all other features disabled),[1] >> "ls /mnt/misc/mkynfs" lead to automount segfault >> "ls /mnt/misc/mkydns" automount fail (no crash), but report "no hosts available" >> >> with libtirpc disabled (all other features disabled)[2] >> "ls /mnt/misc/mkynfs" automount fail (no crash), report "no hosts available" >> "ls /mnt/misc/mkydns" works fine > > What exactly does "all other features disabled" mean from a configure > POV. I always use --disable-mount-locking and --enable-ignore-busy, > always. > $ /var/tmp/portage/net-fs/autofs-9999/work/autofs-9999/configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --docdir=/usr/share/doc/autofs-9999 --with-confdir=/etc/conf.d --with-mapdir=/etc/autofs --with-dmalloc --with-openldap --with-libtirpc --with-sasl --with-hesiod --disable-mount-locking --disable-ext-env --enable-sloppy-mount --enable-force-shutdown --enable-ignore-busy --with-systemd=/usr/lib/systemd/system RANLIB=/usr/bin/x86_64-pc-linux-gnu-ranlib # automount --version Linux automount version 5.0.8 Directories: config dir: /etc/conf.d maps dir: /etc/autofs modules dir: /usr/lib64/autofs Compile options: DISABLE_MOUNT_LOCKING ENABLE_FORCED_SHUTDOWN ENABLE_IGNORE_BUSY_MOUNTS WITH_HESIOD WITH_LDAP WITH_SASL WITH_DMALLOC LIBXML2_WORKAROUND WITH_LIBTIRPC > Maybe that's something to do with the problem your seeing ..... > > Ian > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/5] fyi, here are the patches that I haven't yet committed 2013-12-27 6:36 ` Dennis Lan (dlan) 2013-12-27 7:30 ` Dennis Lan (dlan) @ 2013-12-27 8:50 ` Ian Kent 1 sibling, 0 replies; 22+ messages in thread From: Ian Kent @ 2013-12-27 8:50 UTC (permalink / raw) To: Dennis Lan (dlan); +Cc: autofs mailing list On Fri, 2013-12-27 at 14:36 +0800, Dennis Lan (dlan) wrote: > Hi Ian > I've tested with various USE combinations, still got segfault err. > wi all USE="-dmalloc -hesiod -ldap -libtirpc -mount-locking -sasl" > disabled, with libtirpc en/disabled. > > Next, I may need a few more time to setup gdb to investigate this.. > > also this patch needed to fix compile error while with libtirpc disabled, Umm .. libtirpc disabled! That's going to need work I think. All of what's going on atm. is specifically for libtirpc so let me fix that and then we can address side effects of the case when libtirpc is disabled. > > diff --git a/lib/rpc_subs.c b/lib/rpc_subs.c > index aeece1e..a003074 100644 > --- a/lib/rpc_subs.c > +++ b/lib/rpc_subs.c > @@ -235,7 +235,8 @@ static int rpc_do_create_client(struct sockaddr > *addr, struct conn_info *info, i > return 0; > } > static int rpc_getport(struct conn_info *info, > - struct pmap *parms, CLIENT *client) > + struct pmap *parms, CLIENT *client, > + unsigned short *port) > { > > > [1] commit 076adfb0718e4b8a15ec11bf62597371ceb92399 > Author: Ian Kent <ikent@redhat.com> > Date: Mon Nov 18 12:15:52 2013 +0800 > > autofs-5.0.8 - fix ipv6 libtirpc getport I'll check this anyway .... Ian ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2013-12-30 7:44 UTC | newest] Thread overview: 22+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-12-24 8:02 [PATCH 0/5] fyi, here are the patches that I haven't yet committed Ian Kent 2013-12-24 8:02 ` [PATCH 1/5] autofs-5.0.8 - fix ipv6 link local address handling Ian Kent 2013-12-24 8:02 ` [PATCH 2/5] autofs-5.0.8 - fix fix ipv6 libtirpc getport Ian Kent 2013-12-24 8:02 ` [PATCH 3/5] autofs-5.0.8 - get_nfs_info() should query portmapper if port is not given Ian Kent 2013-12-24 8:02 ` [PATCH 4/5] autofs-5.0.8 - fix rpc_portmap_getport() proto not set Ian Kent 2013-12-24 8:02 ` [PATCH 5/5] autofs-5.0.8 - fix options compare Ian Kent 2013-12-24 8:38 ` [PATCH 0/5] fyi, here are the patches that I haven't yet committed Dennis Lan (dlan) 2013-12-24 9:04 ` Ian Kent 2013-12-24 9:42 ` Dennis Lan (dlan) 2013-12-24 10:34 ` Ian Kent 2013-12-27 6:11 ` Dennis Lan (dlan) 2013-12-27 6:36 ` Dennis Lan (dlan) 2013-12-27 7:30 ` Dennis Lan (dlan) 2013-12-27 8:56 ` Ian Kent 2013-12-28 2:41 ` Ian Kent 2013-12-28 12:09 ` Dennis Lan (dlan) 2013-12-29 11:14 ` Ian Kent 2013-12-29 11:26 ` Ian Kent 2013-12-30 7:38 ` Dennis Lan (dlan) 2013-12-29 11:36 ` Ian Kent 2013-12-30 7:44 ` Dennis Lan (dlan) 2013-12-27 8:50 ` Ian Kent
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.