* [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent
@ 2014-01-06 22:56 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2014-01-06 22:56 UTC (permalink / raw)
To: linux-arm-kernel
Set the CLOCK_EVT_FEAT_DYNIRQ flag on the memory mapped
clockevent so that we save power by waking up the CPU with the
next event when this timer is used in broadcast mode.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/clocksource/arm_arch_timer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 95fb944e15ee..57e823c44d2a 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -277,6 +277,7 @@ static void __arch_timer_setup(unsigned type,
clk->set_next_event = arch_timer_set_next_event_phys;
}
} else {
+ clk->features |= CLOCK_EVT_FEAT_DYNIRQ;
clk->name = "arch_mem_timer";
clk->rating = 400;
clk->cpumask = cpu_all_mask;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent
@ 2014-01-06 22:56 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2014-01-06 22:56 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: linux-kernel, linux-arm-kernel, Thomas Gleixner
Set the CLOCK_EVT_FEAT_DYNIRQ flag on the memory mapped
clockevent so that we save power by waking up the CPU with the
next event when this timer is used in broadcast mode.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/clocksource/arm_arch_timer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 95fb944e15ee..57e823c44d2a 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -277,6 +277,7 @@ static void __arch_timer_setup(unsigned type,
clk->set_next_event = arch_timer_set_next_event_phys;
}
} else {
+ clk->features |= CLOCK_EVT_FEAT_DYNIRQ;
clk->name = "arch_mem_timer";
clk->rating = 400;
clk->cpumask = cpu_all_mask;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent
2014-01-06 22:56 ` Stephen Boyd
@ 2014-01-14 8:40 ` Daniel Lezcano
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2014-01-14 8:40 UTC (permalink / raw)
To: linux-arm-kernel
On 01/06/2014 11:56 PM, Stephen Boyd wrote:
> Set the CLOCK_EVT_FEAT_DYNIRQ flag on the memory mapped
> clockevent so that we save power by waking up the CPU with the
> next event when this timer is used in broadcast mode.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/clocksource/arm_arch_timer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 95fb944e15ee..57e823c44d2a 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -277,6 +277,7 @@ static void __arch_timer_setup(unsigned type,
> clk->set_next_event = arch_timer_set_next_event_phys;
> }
> } else {
> + clk->features |= CLOCK_EVT_FEAT_DYNIRQ;
> clk->name = "arch_mem_timer";
> clk->rating = 400;
> clk->cpumask = cpu_all_mask;
>
Applied in my tree for 3.15.
I am curious how much you saved in your current scenario. Did you had
time to do some rough measurements ?
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent
@ 2014-01-14 8:40 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2014-01-14 8:40 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, linux-arm-kernel, Thomas Gleixner
On 01/06/2014 11:56 PM, Stephen Boyd wrote:
> Set the CLOCK_EVT_FEAT_DYNIRQ flag on the memory mapped
> clockevent so that we save power by waking up the CPU with the
> next event when this timer is used in broadcast mode.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/clocksource/arm_arch_timer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 95fb944e15ee..57e823c44d2a 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -277,6 +277,7 @@ static void __arch_timer_setup(unsigned type,
> clk->set_next_event = arch_timer_set_next_event_phys;
> }
> } else {
> + clk->features |= CLOCK_EVT_FEAT_DYNIRQ;
> clk->name = "arch_mem_timer";
> clk->rating = 400;
> clk->cpumask = cpu_all_mask;
>
Applied in my tree for 3.15.
I am curious how much you saved in your current scenario. Did you had
time to do some rough measurements ?
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-14 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-06 22:56 [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent Stephen Boyd
2014-01-06 22:56 ` Stephen Boyd
2014-01-14 8:40 ` Daniel Lezcano
2014-01-14 8:40 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.