From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: Michael Ellerman <michael@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anton Blanchard <anton@samba.org>,
chzigotzky@xenosoft.de
Subject: Re: [PATCH] powerpc: Fix alignment of secondary cpu spin vars
Date: Thu, 09 Jan 2014 12:36:27 +1100 [thread overview]
Message-ID: <1389231387.4672.50.camel@pasglop> (raw)
In-Reply-To: <20140108174828.GA16830@quad.lixom.net>
On Wed, 2014-01-08 at 09:48 -0800, Olof Johansson wrote:
> > /* If it's a display, note it */
> > - memset(type, 0, sizeof(type));
> > - prom_getprop(stdout_node, "device_type", type, sizeof(type));
> > - if (strcmp(type, "display") == 0)
> > - prom_setprop(stdout_node, path, "linux,boot-display", NULL, 0);
> > + stdout_node = call_prom("instance-to-package", 1, 1, prom.stdout);
> > + if (stdout_node != PROM_ERROR) {
> > + val = cpu_to_be32(stdout_node);
> > + memset(type, 0, sizeof(type));
> > + prom_getprop(stdout_node, "device_type", type, sizeof(type));
> > + if (strcmp(type, "display") == 0)
> > + prom_setprop(stdout_node, path, "linux,boot-display", NU
>
> Line is cut off, this needs "NULL, 0);" at the end.
Right, copy/paste failure :-)
Thanks, I'll try to get that to Linus before he cuts .13, otherwise it
will be -stable.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: Michael Ellerman <michael@ellerman.id.au>,
chzigotzky@xenosoft.de,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH] powerpc: Fix alignment of secondary cpu spin vars
Date: Thu, 09 Jan 2014 12:36:27 +1100 [thread overview]
Message-ID: <1389231387.4672.50.camel@pasglop> (raw)
In-Reply-To: <20140108174828.GA16830@quad.lixom.net>
On Wed, 2014-01-08 at 09:48 -0800, Olof Johansson wrote:
> > /* If it's a display, note it */
> > - memset(type, 0, sizeof(type));
> > - prom_getprop(stdout_node, "device_type", type, sizeof(type));
> > - if (strcmp(type, "display") == 0)
> > - prom_setprop(stdout_node, path, "linux,boot-display", NULL, 0);
> > + stdout_node = call_prom("instance-to-package", 1, 1, prom.stdout);
> > + if (stdout_node != PROM_ERROR) {
> > + val = cpu_to_be32(stdout_node);
> > + memset(type, 0, sizeof(type));
> > + prom_getprop(stdout_node, "device_type", type, sizeof(type));
> > + if (strcmp(type, "display") == 0)
> > + prom_setprop(stdout_node, path, "linux,boot-display", NU
>
> Line is cut off, this needs "NULL, 0);" at the end.
Right, copy/paste failure :-)
Thanks, I'll try to get that to Linus before he cuts .13, otherwise it
will be -stable.
Cheers,
Ben.
next prev parent reply other threads:[~2014-01-09 1:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 21:01 [PATCH] powerpc: Fix alignment of secondary cpu spin vars Olof Johansson
2013-12-28 21:01 ` Olof Johansson
2013-12-28 21:05 ` Olof Johansson
2013-12-28 21:05 ` Olof Johansson
2014-01-03 7:56 ` Olof Johansson
2014-01-03 7:56 ` Olof Johansson
2014-01-03 8:12 ` Olof Johansson
2014-01-03 8:12 ` Olof Johansson
2014-01-08 4:09 ` Michael Ellerman
2014-01-08 4:09 ` Michael Ellerman
2014-01-08 4:18 ` Benjamin Herrenschmidt
2014-01-08 4:18 ` Benjamin Herrenschmidt
2014-01-08 17:48 ` Olof Johansson
2014-01-08 17:48 ` Olof Johansson
2014-01-09 1:36 ` Benjamin Herrenschmidt [this message]
2014-01-09 1:36 ` Benjamin Herrenschmidt
[not found] ` <52CDC12F.5030407@xenosoft.de>
[not found] ` <52D6E829.1050504@xenosoft.de>
[not found] ` <52D6E89C.7010407@xenosoft.de>
[not found] ` <52D6E928.7050307@xenosoft.de>
2014-01-22 10:18 ` [Bug 67811] PASEMI: Kernel 3.13.0 doesn't boot with a PA6T cpu Christian Zigotzky
2014-05-23 21:29 ` PASEMI: Kernel 3.15.0-rc6 " Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389231387.4672.50.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=chzigotzky@xenosoft.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.