From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/18] charger: max14577: Add support for MAX77836 charger
Date: Wed, 05 Feb 2014 13:49:34 +0100 [thread overview]
Message-ID: <1391604574.3726.20.camel@AMDC1943> (raw)
In-Reply-To: <20140203113031.GA8848@jenny-desktop>
Hi,
On Mon, 2014-02-03 at 17:00 +0530, Jenny Tc wrote:
> On Tue, Jan 28, 2014 at 01:18:40PM +0100, Krzysztof Kozlowski wrote:
> > - /* Battery-Charger Constant Voltage (CV) Mode, from SM-V700: 4.35V */
> > + /* Battery-Charger Constant Voltage (CV) Mode, set to: 4.35V */
>
> Does this charger chip support only 4.35V batteries? If the CV is hard coded
> to 4.35V, it's not safe for 4.2V batteries.
>
> > + /* End-of-Charge Current, set to 50mA (max14577) / 7.5mA (max77836) */
> The End of charge current basically depend on battery and not on charger chip.
>
> > - /* Overvoltage-Protection Threshold, from SM-V700: 6.5V */
> > + /* Overvoltage-Protection Threshold, set to 6.5V */
> 6.5V as over voltage for battery? A 4.35V battery would have exploded by
> that time!
Currently the max14577 driver has all these values hard-coded. This
patch doesn't change this, it only adds support for max77836. I agree
with you that hard-coding these values is not a proper way of doing
this.
I'll add another patch for parsing these values from DTS.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Jenny Tc <jenny.tc@intel.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Anton Vorontsov <anton@enomsg.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 16/18] charger: max14577: Add support for MAX77836 charger
Date: Wed, 05 Feb 2014 13:49:34 +0100 [thread overview]
Message-ID: <1391604574.3726.20.camel@AMDC1943> (raw)
In-Reply-To: <20140203113031.GA8848@jenny-desktop>
Hi,
On Mon, 2014-02-03 at 17:00 +0530, Jenny Tc wrote:
> On Tue, Jan 28, 2014 at 01:18:40PM +0100, Krzysztof Kozlowski wrote:
> > - /* Battery-Charger Constant Voltage (CV) Mode, from SM-V700: 4.35V */
> > + /* Battery-Charger Constant Voltage (CV) Mode, set to: 4.35V */
>
> Does this charger chip support only 4.35V batteries? If the CV is hard coded
> to 4.35V, it's not safe for 4.2V batteries.
>
> > + /* End-of-Charge Current, set to 50mA (max14577) / 7.5mA (max77836) */
> The End of charge current basically depend on battery and not on charger chip.
>
> > - /* Overvoltage-Protection Threshold, from SM-V700: 6.5V */
> > + /* Overvoltage-Protection Threshold, set to 6.5V */
> 6.5V as over voltage for battery? A 4.35V battery would have exploded by
> that time!
Currently the max14577 driver has all these values hard-coded. This
patch doesn't change this, it only adds support for max77836. I agree
with you that hard-coding these values is not a proper way of doing
this.
I'll add another patch for parsing these values from DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-02-05 12:49 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 12:18 [PATCH 00/18] mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 01/18] regulator: max14577: Remove unused state container definition Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-01-28 16:19 ` Mark Brown
2014-01-28 16:19 ` Mark Brown
2014-01-28 12:18 ` [PATCH 02/18] mfd: max14577: Remove unused enum max14577_irq_source Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:25 ` Lee Jones
2014-02-03 9:25 ` Lee Jones
2014-01-28 12:18 ` [PATCH 03/18] mfd: max14577: Remove not needed header inclusion Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:26 ` Lee Jones
2014-02-03 9:26 ` Lee Jones
2014-01-28 12:18 ` [PATCH 04/18] mfd: max14577: Add of_compatible to extcon mfd_cell Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:27 ` Lee Jones
2014-02-03 9:27 ` Lee Jones
2014-01-28 12:18 ` [PATCH 05/18] mfd: max14577: Use of_match_ptr() in i2c_driver Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-01-29 10:08 ` Krzysztof Kozlowski
2014-01-29 10:08 ` Krzysztof Kozlowski
2014-02-03 9:30 ` Lee Jones
2014-02-03 9:30 ` Lee Jones
2014-02-05 10:41 ` Krzysztof Kozlowski
2014-02-05 10:41 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 06/18] extcon: max14577: Change extcon name instead of static name according to device type Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-05 0:43 ` Chanwoo Choi
2014-02-05 0:43 ` Chanwoo Choi
2014-01-28 12:18 ` [PATCH 07/18] mfd: max14577: Rename and add MAX14577 symbols to prepare for max77836 Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:38 ` Lee Jones
2014-02-03 9:38 ` Lee Jones
2014-02-05 10:45 ` Krzysztof Kozlowski
2014-02-05 10:45 ` Krzysztof Kozlowski
2014-02-06 1:53 ` Chanwoo Choi
2014-02-06 1:53 ` Chanwoo Choi
2014-01-28 12:18 ` [PATCH 08/18] mfd: max14577: Rename state container to maxim_core Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:42 ` Lee Jones
2014-02-03 9:42 ` Lee Jones
2014-02-05 10:48 ` Krzysztof Kozlowski
2014-02-05 10:48 ` Krzysztof Kozlowski
2014-02-06 1:55 ` Chanwoo Choi
2014-02-06 1:55 ` Chanwoo Choi
2014-01-28 12:18 ` [PATCH 09/18] mfd: max14577: Add "muic" suffix to regmap and irq_chip Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:45 ` Lee Jones
2014-02-03 9:45 ` Lee Jones
2014-02-05 10:48 ` Krzysztof Kozlowski
2014-02-05 10:48 ` Krzysztof Kozlowski
2014-02-06 1:56 ` Chanwoo Choi
2014-02-06 1:56 ` Chanwoo Choi
2014-01-28 12:18 ` [PATCH 10/18] mfd: max14577: Add detection of device type Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 9:55 ` Lee Jones
2014-02-03 9:55 ` Lee Jones
2014-02-05 13:38 ` Krzysztof Kozlowski
2014-02-05 13:38 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 11/18] extcon: max14577: Add max14577 prefix to muic_irqs Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-05 0:47 ` Chanwoo Choi
2014-02-05 0:47 ` Chanwoo Choi
2014-02-05 10:40 ` Krzysztof Kozlowski
2014-02-05 10:40 ` Krzysztof Kozlowski
2014-02-05 14:04 ` Lee Jones
2014-02-05 14:04 ` Lee Jones
2014-02-06 2:24 ` Chanwoo Choi
2014-02-06 2:24 ` Chanwoo Choi
2014-01-28 12:18 ` [PATCH 12/18] extcon: max14577: Choose muic_irqs according to device type Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 13/18] mfd: max77836: Add max77836 support to max14577 driver Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 10:22 ` Lee Jones
2014-02-03 10:22 ` Lee Jones
2014-02-05 14:57 ` Krzysztof Kozlowski
2014-02-05 14:57 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 14/18] extcon: max14577: Add support for max77836 Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 10:23 ` Lee Jones
2014-02-03 10:23 ` Lee Jones
2014-01-28 12:18 ` [PATCH 15/18] regulator: max14577: Add support for max77836 regulators Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-01-28 16:25 ` Mark Brown
2014-01-28 16:25 ` Mark Brown
2014-02-03 10:24 ` Lee Jones
2014-02-03 10:24 ` Lee Jones
2014-01-28 12:18 ` [PATCH 16/18] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-02-03 10:26 ` Lee Jones
2014-02-03 10:26 ` Lee Jones
2014-02-03 11:30 ` Jenny Tc
2014-02-03 11:30 ` Jenny Tc
2014-02-05 12:49 ` Krzysztof Kozlowski [this message]
2014-02-05 12:49 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 17/18] power: max17040: Add ID for max77836 Fuel Gauge block Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
2014-01-28 12:18 ` [PATCH 18/18] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2014-01-28 12:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391604574.3726.20.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.