All of lore.kernel.org
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 14/15] charger: max14577: Configure battery-dependent settings from DTS
Date: Fri, 07 Feb 2014 11:46:14 +0100	[thread overview]
Message-ID: <1391769974.12119.1.camel@AMDC1943> (raw)
In-Reply-To: <20140207104238.GH14727@lee--X1>

On Fri, 2014-02-07 at 10:42 +0000, Lee Jones wrote:
> > Remove hard-coded values for:
> >  - Fast Charge current,
> >  - End Of Charge current,
> >  - Fast Charge timer,
> >  - Overvoltage Protection Threshold,
> >  - Battery Constant Voltage,
> > and use DTS to configure them. This allows using the max14577 charger
> > driver with different batteries.
> > 
> > Now the charger driver requires valid configuration data from DTS. In
> > case of wrong configuration data it fails during probe. Patch adds
> > of_compatible to the charger mfd cell in MFD driver core.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> I already acked the MFD parts of this. Or has the patch changed?

Hi,

This patch is new in v2 so you haven't acked it yet. I need your ACK
here and in 13/15 (regulator/mfd: max14577: Export symbols for
calculating charger current).

Best regards,
Krzysztof


> > Cc: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Jenny Tc <jenny.tc@intel.com>
> > ---
> >  drivers/mfd/max14577.c               |    5 +-
> >  drivers/power/max14577_charger.c     |  234 +++++++++++++++++++++++++++++-----
> >  include/linux/mfd/max14577-private.h |   10 ++
> >  include/linux/mfd/max14577.h         |    8 ++
> >  4 files changed, 227 insertions(+), 30 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Jenny Tc <jenny.tc@intel.com>
Subject: Re: [PATCH v2 14/15] charger: max14577: Configure battery-dependent settings from DTS
Date: Fri, 07 Feb 2014 11:46:14 +0100	[thread overview]
Message-ID: <1391769974.12119.1.camel@AMDC1943> (raw)
In-Reply-To: <20140207104238.GH14727@lee--X1>

On Fri, 2014-02-07 at 10:42 +0000, Lee Jones wrote:
> > Remove hard-coded values for:
> >  - Fast Charge current,
> >  - End Of Charge current,
> >  - Fast Charge timer,
> >  - Overvoltage Protection Threshold,
> >  - Battery Constant Voltage,
> > and use DTS to configure them. This allows using the max14577 charger
> > driver with different batteries.
> > 
> > Now the charger driver requires valid configuration data from DTS. In
> > case of wrong configuration data it fails during probe. Patch adds
> > of_compatible to the charger mfd cell in MFD driver core.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> I already acked the MFD parts of this. Or has the patch changed?

Hi,

This patch is new in v2 so you haven't acked it yet. I need your ACK
here and in 13/15 (regulator/mfd: max14577: Export symbols for
calculating charger current).

Best regards,
Krzysztof


> > Cc: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Jenny Tc <jenny.tc@intel.com>
> > ---
> >  drivers/mfd/max14577.c               |    5 +-
> >  drivers/power/max14577_charger.c     |  234 +++++++++++++++++++++++++++++-----
> >  include/linux/mfd/max14577-private.h |   10 ++
> >  include/linux/mfd/max14577.h         |    8 ++
> >  4 files changed, 227 insertions(+), 30 deletions(-)
> 


  reply	other threads:[~2014-02-07 10:46 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 10:04 [PATCH v2 00/15] mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 01/15] extcon: max14577: Change extcon name instead of static name according to device type Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 02/15] mfd: max14577: Rename and add MAX14577 symbols to prepare for max77836 Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 03/15] mfd: max14577: Rename state container to maxim_core Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 04/15] mfd: max14577: Add "muic" suffix to regmap and irq_chip Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 05/15] mfd: max14577: Add detection of device type Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:53   ` Lee Jones
2014-02-07 10:53     ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 06/15] extcon: max14577: Add max14577 prefix to muic_irqs Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 07/15] extcon: max14577: Choose muic_irqs according to device type Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:48   ` Lee Jones
2014-02-07 10:48     ` Lee Jones
2014-02-07 10:49   ` Lee Jones
2014-02-07 10:49     ` Lee Jones
2014-02-07 10:54     ` Krzysztof Kozlowski
2014-02-07 10:54       ` Krzysztof Kozlowski
2014-02-10 12:02   ` Lee Jones
2014-02-10 12:02     ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 09/15] extcon: max14577: Add support for max77836 Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 10/15] regulator: max14577: Add support for max77836 regulators Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 11/15] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 12/15] power: max17040: Add ID for max77836 Fuel Gauge block Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 13/15] regulator/mfd: max14577: Export symbols for calculating charger current Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 16:34   ` Mark Brown
2014-02-07 16:34     ` Mark Brown
2014-02-10 11:59   ` Lee Jones
2014-02-10 11:59     ` Lee Jones
2014-02-10 14:24     ` Lee Jones
2014-02-10 14:24       ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 14/15] charger: max14577: Configure battery-dependent settings from DTS Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski
2014-02-07 10:42   ` Lee Jones
2014-02-07 10:42     ` Lee Jones
2014-02-07 10:46     ` Krzysztof Kozlowski [this message]
2014-02-07 10:46       ` Krzysztof Kozlowski
2014-02-10 12:14   ` Lee Jones
2014-02-10 12:14     ` Lee Jones
2014-02-10 15:06     ` Krzysztof Kozlowski
2014-02-10 15:06       ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 15/15] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2014-02-07 10:04   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391769974.12119.1.camel@AMDC1943 \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.