From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver
Date: Mon, 10 Feb 2014 12:02:32 +0000 [thread overview]
Message-ID: <20140210120232.GG22773@lee--X1> (raw)
In-Reply-To: <1391767487-10017-9-git-send-email-k.kozlowski@samsung.com>
> Add Maxim 77836 support to max14577 driver. The chipsets have same MUIC
> component so the extcon, charger and regulators are almost the same. The
> max77836 however has also PMIC and Fuel Gauge.
>
> The MAX77836 uses three I2C slave addresses and has additional interrupts
> (related to PMIC and Fuel Gauge). It has also Interrupt Source register,
> just like MAX77686 and MAX77693.
>
> The MAX77836 PMIC's TOPSYS and INTSRC interrupts are reported in the
> PMIC block. The PMIC block has different I2C slave address and uses own
> regmap so another regmap_irq_chip is needed.
>
> Since we have two regmap_irq_chip, use shared interrupts on MAX77836.
>
> This patch adds additional defines and functions to the max14577 MFD core
> driver so the driver will handle both chipsets. Also this patch replaces
> "0x1 << N" with BIT(N) in defines for register masks.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/mfd/max14577.c | 217 ++++++++++++++++++++++++++++++++--
> include/linux/mfd/max14577-private.h | 175 +++++++++++++++++++--------
> include/linux/mfd/max14577.h | 7 +-
> 3 files changed, 341 insertions(+), 58 deletions(-)
Much better, thanks.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver
Date: Mon, 10 Feb 2014 12:02:32 +0000 [thread overview]
Message-ID: <20140210120232.GG22773@lee--X1> (raw)
In-Reply-To: <1391767487-10017-9-git-send-email-k.kozlowski@samsung.com>
> Add Maxim 77836 support to max14577 driver. The chipsets have same MUIC
> component so the extcon, charger and regulators are almost the same. The
> max77836 however has also PMIC and Fuel Gauge.
>
> The MAX77836 uses three I2C slave addresses and has additional interrupts
> (related to PMIC and Fuel Gauge). It has also Interrupt Source register,
> just like MAX77686 and MAX77693.
>
> The MAX77836 PMIC's TOPSYS and INTSRC interrupts are reported in the
> PMIC block. The PMIC block has different I2C slave address and uses own
> regmap so another regmap_irq_chip is needed.
>
> Since we have two regmap_irq_chip, use shared interrupts on MAX77836.
>
> This patch adds additional defines and functions to the max14577 MFD core
> driver so the driver will handle both chipsets. Also this patch replaces
> "0x1 << N" with BIT(N) in defines for register masks.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/mfd/max14577.c | 217 ++++++++++++++++++++++++++++++++--
> include/linux/mfd/max14577-private.h | 175 +++++++++++++++++++--------
> include/linux/mfd/max14577.h | 7 +-
> 3 files changed, 341 insertions(+), 58 deletions(-)
Much better, thanks.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-10 12:02 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 10:04 [PATCH v2 00/15] mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 01/15] extcon: max14577: Change extcon name instead of static name according to device type Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 02/15] mfd: max14577: Rename and add MAX14577 symbols to prepare for max77836 Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 03/15] mfd: max14577: Rename state container to maxim_core Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 04/15] mfd: max14577: Add "muic" suffix to regmap and irq_chip Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 05/15] mfd: max14577: Add detection of device type Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:53 ` Lee Jones
2014-02-07 10:53 ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 06/15] extcon: max14577: Add max14577 prefix to muic_irqs Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 07/15] extcon: max14577: Choose muic_irqs according to device type Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:48 ` Lee Jones
2014-02-07 10:48 ` Lee Jones
2014-02-07 10:49 ` Lee Jones
2014-02-07 10:49 ` Lee Jones
2014-02-07 10:54 ` Krzysztof Kozlowski
2014-02-07 10:54 ` Krzysztof Kozlowski
2014-02-10 12:02 ` Lee Jones [this message]
2014-02-10 12:02 ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 09/15] extcon: max14577: Add support for max77836 Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 10/15] regulator: max14577: Add support for max77836 regulators Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 11/15] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 12/15] power: max17040: Add ID for max77836 Fuel Gauge block Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 13/15] regulator/mfd: max14577: Export symbols for calculating charger current Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 16:34 ` Mark Brown
2014-02-07 16:34 ` Mark Brown
2014-02-10 11:59 ` Lee Jones
2014-02-10 11:59 ` Lee Jones
2014-02-10 14:24 ` Lee Jones
2014-02-10 14:24 ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 14/15] charger: max14577: Configure battery-dependent settings from DTS Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
2014-02-07 10:42 ` Lee Jones
2014-02-07 10:42 ` Lee Jones
2014-02-07 10:46 ` Krzysztof Kozlowski
2014-02-07 10:46 ` Krzysztof Kozlowski
2014-02-10 12:14 ` Lee Jones
2014-02-10 12:14 ` Lee Jones
2014-02-10 15:06 ` Krzysztof Kozlowski
2014-02-10 15:06 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 15/15] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2014-02-07 10:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210120232.GG22773@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.