From: Paul Bolle <pebolle@tiscali.nl>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
Date: Mon, 17 Feb 2014 13:48:13 +0100 [thread overview]
Message-ID: <1392641293.13000.9.camel@x220> (raw)
In-Reply-To: <5302017F.40900@compulab.co.il>
Hi Igor,
On Mon, 2014-02-17 at 14:33 +0200, Igor Grinberg wrote:
> On 02/16/14 19:26, Paul Bolle wrote:
> > The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
> > used. Setting it has no effect. There are no calls for
> > machine_is_cm_t3730(). This symbol can safely be removed.
>
> Indeed...
Please note that I now doubt my reasoning was correct here. I'm going to
revisit my recent batch of patches regarding, in short, arm Kconfig
symbols used in mach-types.h. (lkml.org is sort of down, so I can't
provide a link.)
> Is it such a burden to keep it just until we switch OMAP3 to DT?
> Because, it makes a bit harder to hack on the kernel.
> Well, not too much as it can be reverted, but still one needs
> to remember to do this...
No, not really. The worst that could happen, from your perspective, is
that if it turns out this was the right thing to do, I might send a
reminder in a few months.
> I'd like to keep it just until we remove the board files, please.
Thanks,
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
Date: Mon, 17 Feb 2014 13:48:13 +0100 [thread overview]
Message-ID: <1392641293.13000.9.camel@x220> (raw)
In-Reply-To: <5302017F.40900@compulab.co.il>
Hi Igor,
On Mon, 2014-02-17 at 14:33 +0200, Igor Grinberg wrote:
> On 02/16/14 19:26, Paul Bolle wrote:
> > The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
> > used. Setting it has no effect. There are no calls for
> > machine_is_cm_t3730(). This symbol can safely be removed.
>
> Indeed...
Please note that I now doubt my reasoning was correct here. I'm going to
revisit my recent batch of patches regarding, in short, arm Kconfig
symbols used in mach-types.h. (lkml.org is sort of down, so I can't
provide a link.)
> Is it such a burden to keep it just until we switch OMAP3 to DT?
> Because, it makes a bit harder to hack on the kernel.
> Well, not too much as it can be reverted, but still one needs
> to remember to do this...
No, not really. The worst that could happen, from your perspective, is
that if it turns out this was the right thing to do, I might send a
reminder in a few months.
> I'd like to keep it just until we remove the board files, please.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2014-02-17 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 17:26 [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730 Paul Bolle
2014-02-16 17:26 ` Paul Bolle
2014-02-17 12:33 ` Igor Grinberg
2014-02-17 12:33 ` Igor Grinberg
2014-02-17 12:48 ` Paul Bolle [this message]
2014-02-17 12:48 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392641293.13000.9.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=richard@nod.at \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.