From: Igor Grinberg <grinberg@compulab.co.il>
To: Paul Bolle <pebolle@tiscali.nl>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>
Cc: Richard Weinberger <richard@nod.at>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
Date: Mon, 17 Feb 2014 14:33:03 +0200 [thread overview]
Message-ID: <5302017F.40900@compulab.co.il> (raw)
In-Reply-To: <1392571560.28866.16.camel@x220>
Hi Paul,
On 02/16/14 19:26, Paul Bolle wrote:
> The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
> used. Setting it has no effect. There are no calls for
> machine_is_cm_t3730(). This symbol can safely be removed.
Indeed...
Is it such a burden to keep it just until we switch OMAP3 to DT?
Because, it makes a bit harder to hack on the kernel.
Well, not too much as it can be reverted, but still one needs
to remember to do this...
I'd like to keep it just until we remove the board files, please.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested only with "git grep".
>
> arch/arm/mach-omap2/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 66da3f5..7d4934e 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -292,7 +292,6 @@ config MACH_CM_T35
> bool "CompuLab CM-T35/CM-T3730 modules"
> depends on ARCH_OMAP3
> default y
> - select MACH_CM_T3730
> select OMAP_PACKAGE_CUS
>
> config MACH_CM_T3517
> @@ -301,9 +300,6 @@ config MACH_CM_T3517
> default y
> select OMAP_PACKAGE_CBB
>
> -config MACH_CM_T3730
> - bool
> -
> config MACH_SBC3530
> bool "OMAP3 SBC STALKER board"
> depends on ARCH_OMAP3
>
--
Regards,
Igor.
WARNING: multiple messages have this Message-ID (diff)
From: grinberg@compulab.co.il (Igor Grinberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730
Date: Mon, 17 Feb 2014 14:33:03 +0200 [thread overview]
Message-ID: <5302017F.40900@compulab.co.il> (raw)
In-Reply-To: <1392571560.28866.16.camel@x220>
Hi Paul,
On 02/16/14 19:26, Paul Bolle wrote:
> The Kconfig symbol MACH_CM_T3730 was added in v3.1. It has never been
> used. Setting it has no effect. There are no calls for
> machine_is_cm_t3730(). This symbol can safely be removed.
Indeed...
Is it such a burden to keep it just until we switch OMAP3 to DT?
Because, it makes a bit harder to hack on the kernel.
Well, not too much as it can be reverted, but still one needs
to remember to do this...
I'd like to keep it just until we remove the board files, please.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested only with "git grep".
>
> arch/arm/mach-omap2/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 66da3f5..7d4934e 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -292,7 +292,6 @@ config MACH_CM_T35
> bool "CompuLab CM-T35/CM-T3730 modules"
> depends on ARCH_OMAP3
> default y
> - select MACH_CM_T3730
> select OMAP_PACKAGE_CUS
>
> config MACH_CM_T3517
> @@ -301,9 +300,6 @@ config MACH_CM_T3517
> default y
> select OMAP_PACKAGE_CBB
>
> -config MACH_CM_T3730
> - bool
> -
> config MACH_SBC3530
> bool "OMAP3 SBC STALKER board"
> depends on ARCH_OMAP3
>
--
Regards,
Igor.
next prev parent reply other threads:[~2014-02-17 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 17:26 [PATCH] arm: omap3: cm-t35: remove MACH_CM_T3730 Paul Bolle
2014-02-16 17:26 ` Paul Bolle
2014-02-17 12:33 ` Igor Grinberg [this message]
2014-02-17 12:33 ` Igor Grinberg
2014-02-17 12:48 ` Paul Bolle
2014-02-17 12:48 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5302017F.40900@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pebolle@tiscali.nl \
--cc=richard@nod.at \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.