RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property

From: "Shradha Todi" <shradha.t@samsung.com>
To: "'Rob Herring'" <robh@kernel.org>
Cc: <pankaj.dubey@samsung.com>, <linux-pci@vger.kernel.org>,
	<jingoohan1@gmail.com>, <jh80.chung@samsung.co>,
	<linux-arm-kernel@lists.infradead.org>, <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>, <hongxing.zhu@nxp.com>,
	<alim.akhtar@samsung.com>, <bhelgaas@google.com>,
	<krzysztof.kozlowski+dt@linaro.org>, <m.szyprowski@samsung.com>,
	<kw@linux.com>, <devicetree@vger.kernel.org>,
	<Sergey.Semin@baikalelectronics.ru>,
	<linux-samsung-soc@vger.kernel.org>, <lukas.bulwahn@gmail.com>,
	<lpieralisi@kernel.org>
Subject: RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property
Date: Thu, 2 Mar 2023 18:18:19 +0530	[thread overview]
Message-ID: <139301d94d05$45d1c190$d17544b0$@samsung.com> (raw)
In-Reply-To: <167638945319.3745.5262086066044660323.robh@kernel.org>

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 14 February 2023 21:43
> To: Shradha Todi <shradha.t@samsung.com>
> Cc: pankaj.dubey@samsung.com; linux-pci@vger.kernel.org;
> jingoohan1@gmail.com; jh80.chung@samsung.co; linux-arm-
> kernel@lists.infradead.org; tglx@linutronix.de; linux-
> kernel@vger.kernel.org; hongxing.zhu@nxp.com;
> alim.akhtar@samsung.com; bhelgaas@google.com;
> krzysztof.kozlowski+dt@linaro.org; m.szyprowski@samsung.com;
> kw@linux.com; devicetree@vger.kernel.org;
> Sergey.Semin@baikalelectronics.ru; linux-samsung-soc@vger.kernel.org;
> lukas.bulwahn@gmail.com; lpieralisi@kernel.org
> Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required
> property
> 
> 
> On Tue, 14 Feb 2023 17:43:27 +0530, Shradha Todi wrote:
> > To replace devm_of_phy_get with devm_phy_get to get the PHY pointer
> > using non DT version, we need to add phy-names property in DT and make
> > it a required property with const value.
> >
> > Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> > ---
> >  Documentation/devicetree/bindings/pci/samsung,pcie.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/samsung,exynos-
> pcie.example.dtb: pcie@15700000: 'phy-names' is a required property
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See https://protect2.fireeye.com/v1/url?k=788bbab7-19f652f0-788a31f8-
> 74fe485fff30-c0e59906b0eee0e1&q=1&e=33c2cefb-9526-43d7-9446-
> b159854d2369&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev
> icetree-bindings%2Fpatch%2F20230214121333.1837-11-
> shradha.t%40samsung.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.

Thanks for review. Sorry, I missed to update the example. Anyway I will get rid of this patch all together!