From: Rob Herring <robh@kernel.org>
To: Shradha Todi <shradha.t@samsung.com>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com,
jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru,
lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com,
tglx@linutronix.de, m.szyprowski@samsung.com,
jh80.chung@samsung.co, pankaj.dubey@samsung.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property
Date: Tue, 14 Feb 2023 13:17:34 -0600 [thread overview]
Message-ID: <20230214191734.GA23567-robh@kernel.org> (raw)
In-Reply-To: <20230214121333.1837-11-shradha.t@samsung.com>
On Tue, Feb 14, 2023 at 05:43:27PM +0530, Shradha Todi wrote:
> To replace devm_of_phy_get with devm_phy_get to get the
> PHY pointer using non DT version, we need to add phy-names
> property in DT and make it a required property with const
> value.
Also an ABI break.
And unnecessary. You don't need a name with a single entry. Pretty sure
I fixed that for phy_get at some point.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Shradha Todi <shradha.t@samsung.com>
Cc: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com,
krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com,
jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru,
lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com,
tglx@linutronix.de, m.szyprowski@samsung.com,
jh80.chung@samsung.co, pankaj.dubey@samsung.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property
Date: Tue, 14 Feb 2023 13:17:34 -0600 [thread overview]
Message-ID: <20230214191734.GA23567-robh@kernel.org> (raw)
In-Reply-To: <20230214121333.1837-11-shradha.t@samsung.com>
On Tue, Feb 14, 2023 at 05:43:27PM +0530, Shradha Todi wrote:
> To replace devm_of_phy_get with devm_phy_get to get the
> PHY pointer using non DT version, we need to add phy-names
> property in DT and make it a required property with const
> value.
Also an ABI break.
And unnecessary. You don't need a name with a single entry. Pretty sure
I fixed that for phy_get at some point.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-14 19:17 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230214121348epcas5p48a3b2b225f616d748cc20622d01edb97@epcas5p4.samsung.com>
2023-02-14 12:13 ` [PATCH 00/16] Refactor Exynos PCIe driver to make it generic Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to Samsung PCIe Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 10:54 ` Krzysztof Kozlowski
2023-02-16 10:54 ` Krzysztof Kozlowski
2023-02-18 1:54 ` Han Jingoo
2023-02-18 1:54 ` Han Jingoo
2023-03-02 12:54 ` Shradha Todi
2023-03-02 12:54 ` Shradha Todi
2023-03-03 10:12 ` Krzysztof Kozlowski
2023-03-03 10:12 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 02/16] PCI: exynos: Rename Exynos PCIe driver " Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 10:55 ` Krzysztof Kozlowski
2023-02-16 10:55 ` Krzysztof Kozlowski
2023-02-16 10:59 ` Krzysztof Kozlowski
2023-02-16 10:59 ` Krzysztof Kozlowski
2023-03-02 12:57 ` Shradha Todi
2023-03-02 12:57 ` Shradha Todi
2023-03-03 10:35 ` Krzysztof Kozlowski
2023-03-03 10:35 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 03/16] PCI: samsung: Change macro names to exynos specific Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 10:58 ` Krzysztof Kozlowski
2023-02-16 10:58 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 04/16] PCI: samsung: Use clock bulk API to get clocks Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 11:02 ` Krzysztof Kozlowski
2023-02-16 11:02 ` Krzysztof Kozlowski
2023-03-02 12:59 ` Shradha Todi
2023-03-02 12:59 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 05/16] dt-bindings: PCI: Rename the term elbi to appl Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-14 16:12 ` Rob Herring
2023-02-14 16:12 ` Rob Herring
2023-03-02 12:47 ` Shradha Todi
2023-03-02 12:47 ` Shradha Todi
2023-02-14 19:15 ` Rob Herring
2023-02-14 19:15 ` Rob Herring
2023-02-16 11:04 ` Krzysztof Kozlowski
2023-02-16 11:04 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 06/16] arm64: dts: exynos: " Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 11:03 ` Krzysztof Kozlowski
2023-02-16 11:03 ` Krzysztof Kozlowski
2023-03-02 13:07 ` Shradha Todi
2023-03-02 13:07 ` Shradha Todi
2023-03-03 10:37 ` Krzysztof Kozlowski
2023-03-03 10:37 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 07/16] PCI: samsung: " Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 08/16] PCI: samsung: Rename exynos_pcie to samsung_pcie Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 11:07 ` Krzysztof Kozlowski
2023-02-16 11:07 ` Krzysztof Kozlowski
2023-03-02 12:32 ` Pankaj Dubey
2023-03-02 12:32 ` Pankaj Dubey
2023-03-03 10:06 ` Krzysztof Kozlowski
2023-03-03 10:06 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 09/16] PCI: samsung: Make common appl readl/writel functions Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 11:07 ` Krzysztof Kozlowski
2023-02-16 11:07 ` Krzysztof Kozlowski
2023-03-02 12:33 ` Pankaj Dubey
2023-03-02 12:33 ` Pankaj Dubey
2023-02-14 12:13 ` [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-14 16:12 ` Rob Herring
2023-02-14 16:12 ` Rob Herring
2023-03-02 12:48 ` Shradha Todi
2023-03-02 12:48 ` Shradha Todi
2023-02-14 19:17 ` Rob Herring [this message]
2023-02-14 19:17 ` Rob Herring
2023-03-02 12:51 ` Shradha Todi
2023-03-02 12:51 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 11/16] arm64: dts: exynos: Add phy-names as DT property Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 12/16] PCI: samsung: Get PHY using non-DT version Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 13/16] PCI: samsung: Rename common functions to samsung Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 11:09 ` Krzysztof Kozlowski
2023-02-16 11:09 ` Krzysztof Kozlowski
2023-02-14 12:13 ` [PATCH 15/16] PCI: samsung: Add structure to hold resource operations Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 11:11 ` Krzysztof Kozlowski
2023-02-16 11:11 ` Krzysztof Kozlowski
2023-03-02 13:10 ` Shradha Todi
2023-03-02 13:10 ` Shradha Todi
2023-02-14 12:13 ` [PATCH 16/16] PCI: samsung: Make handling of regulators generic Shradha Todi
2023-02-14 12:13 ` Shradha Todi
2023-02-16 10:57 ` [PATCH 00/16] Refactor Exynos PCIe driver to make it generic Krzysztof Kozlowski
2023-02-16 10:57 ` Krzysztof Kozlowski
2023-03-03 12:38 ` Serge Semin
2023-03-03 12:38 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214191734.GA23567-robh@kernel.org \
--to=robh@kernel.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=jh80.chung@samsung.co \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=shradha.t@samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.