From: Roger Quadros <rogerq@ti.com>
To: kishon@ti.com, tony@atomide.com, balbi@ti.com
Cc: george.cherian@ti.com, balajitk@ti.com, hdegoede@redhat.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-ide@vger.kernel.org,
rogerq@ti.com
Subject: [PATCH v2 08/13] phy: ti-pipe3: Fix suspend/resume and module reload
Date: Thu, 6 Mar 2014 16:38:44 +0200 [thread overview]
Message-ID: <1394116729-28811-9-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1394116729-28811-1-git-send-email-rogerq@ti.com>
Due to Errata i783, SATA breaks if its DPLL is idled. The recommeded
workaround to issue a softreset to the SATA controller doesn't seem to
work. Here we just prevent SATA DPLL from Idling and hence avoid
the issue altogether.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/phy/phy-ti-pipe3.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
index 12cc900..5913676 100644
--- a/drivers/phy/phy-ti-pipe3.c
+++ b/drivers/phy/phy-ti-pipe3.c
@@ -238,6 +238,10 @@ static int ti_pipe3_exit(struct phy *x)
u32 val;
unsigned long timeout;
+ /* SATA DPLL can't be powered down due to Errata i783 */
+ if (of_device_is_compatible(phy->dev->of_node, "ti,phy-pipe3-sata"))
+ return 0;
+
/* Put DPLL in IDLE mode */
val = ti_pipe3_readl(phy->pll_ctrl_base, PLL_CONFIGURATION2);
val |= PLL_IDLE;
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/13] phy: ti-pipe3: Fix suspend/resume and module reload
Date: Thu, 6 Mar 2014 16:38:44 +0200 [thread overview]
Message-ID: <1394116729-28811-9-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1394116729-28811-1-git-send-email-rogerq@ti.com>
Due to Errata i783, SATA breaks if its DPLL is idled. The recommeded
workaround to issue a softreset to the SATA controller doesn't seem to
work. Here we just prevent SATA DPLL from Idling and hence avoid
the issue altogether.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/phy/phy-ti-pipe3.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
index 12cc900..5913676 100644
--- a/drivers/phy/phy-ti-pipe3.c
+++ b/drivers/phy/phy-ti-pipe3.c
@@ -238,6 +238,10 @@ static int ti_pipe3_exit(struct phy *x)
u32 val;
unsigned long timeout;
+ /* SATA DPLL can't be powered down due to Errata i783 */
+ if (of_device_is_compatible(phy->dev->of_node, "ti,phy-pipe3-sata"))
+ return 0;
+
/* Put DPLL in IDLE mode */
val = ti_pipe3_readl(phy->pll_ctrl_base, PLL_CONFIGURATION2);
val |= PLL_IDLE;
--
1.8.3.2
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: <kishon@ti.com>, <tony@atomide.com>, <balbi@ti.com>
Cc: <george.cherian@ti.com>, <balajitk@ti.com>, <hdegoede@redhat.com>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-ide@vger.kernel.org>,
<rogerq@ti.com>
Subject: [PATCH v2 08/13] phy: ti-pipe3: Fix suspend/resume and module reload
Date: Thu, 6 Mar 2014 16:38:44 +0200 [thread overview]
Message-ID: <1394116729-28811-9-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1394116729-28811-1-git-send-email-rogerq@ti.com>
Due to Errata i783, SATA breaks if its DPLL is idled. The recommeded
workaround to issue a softreset to the SATA controller doesn't seem to
work. Here we just prevent SATA DPLL from Idling and hence avoid
the issue altogether.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/phy/phy-ti-pipe3.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
index 12cc900..5913676 100644
--- a/drivers/phy/phy-ti-pipe3.c
+++ b/drivers/phy/phy-ti-pipe3.c
@@ -238,6 +238,10 @@ static int ti_pipe3_exit(struct phy *x)
u32 val;
unsigned long timeout;
+ /* SATA DPLL can't be powered down due to Errata i783 */
+ if (of_device_is_compatible(phy->dev->of_node, "ti,phy-pipe3-sata"))
+ return 0;
+
/* Put DPLL in IDLE mode */
val = ti_pipe3_readl(phy->pll_ctrl_base, PLL_CONFIGURATION2);
val |= PLL_IDLE;
--
1.8.3.2
next prev parent reply other threads:[~2014-03-06 14:38 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:38 [PATCH v2 00/13][RESEND] ARM: OMAP: SATA support for OMAP5 & DRA7 Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 01/13] phy: rename struct omap_control_usb to struct omap_control_phy Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 15:37 ` Kishon Vijay Abraham I
2014-03-06 15:37 ` Kishon Vijay Abraham I
2014-03-06 15:37 ` Kishon Vijay Abraham I
2014-03-06 15:56 ` Felipe Balbi
2014-03-06 15:56 ` Felipe Balbi
2014-03-06 15:56 ` Felipe Balbi
2014-03-06 14:38 ` [PATCH v2 02/13] phy: omap-control: Update DT binding information Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 15:40 ` Kishon Vijay Abraham I
2014-03-06 15:40 ` Kishon Vijay Abraham I
2014-03-06 15:40 ` Kishon Vijay Abraham I
2014-03-06 15:58 ` Felipe Balbi
2014-03-06 15:58 ` Felipe Balbi
2014-03-06 15:58 ` Felipe Balbi
2014-03-06 14:38 ` [PATCH v2 03/13] phy: omap-control: update dra7 and am437 usb2 bindings Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 15:41 ` Kishon Vijay Abraham I
2014-03-06 15:41 ` Kishon Vijay Abraham I
2014-03-06 15:41 ` Kishon Vijay Abraham I
2014-03-07 8:25 ` [PATCH v4] phy: omap-control: update dra7 and am437 usb2 Documentation bindings Kishon Vijay Abraham I
2014-03-07 8:26 ` Kishon Vijay Abraham I
2014-03-07 8:26 ` Kishon Vijay Abraham I
2014-03-07 8:26 ` Kishon Vijay Abraham I
2014-03-07 8:25 ` Kishon Vijay Abraham I
2014-03-06 16:00 ` [PATCH v2 03/13] phy: omap-control: update dra7 and am437 usb2 bindings Felipe Balbi
2014-03-06 16:00 ` Felipe Balbi
2014-03-06 16:00 ` Felipe Balbi
2014-03-06 14:38 ` [PATCH v2 04/13] phy: ti-pipe3: cleanup clock handling Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 15:45 ` Kishon Vijay Abraham I
2014-03-06 15:45 ` Kishon Vijay Abraham I
2014-03-06 15:45 ` Kishon Vijay Abraham I
2014-03-06 14:38 ` [PATCH v2 05/13] phy: ti-pipe3: Add SATA DPLL support Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 15:45 ` Kishon Vijay Abraham I
2014-03-06 15:45 ` Kishon Vijay Abraham I
2014-03-06 15:45 ` Kishon Vijay Abraham I
[not found] ` <1394116729-28811-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-03-06 14:38 ` [PATCH v2 06/13] phy: ti-pipe3: Don't get 'wkupclk' and 'refclk' for SATA PHY Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 15:31 ` [PATCH v3 " Roger Quadros
2014-03-06 15:31 ` Roger Quadros
2014-03-06 15:31 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 07/13] phy: ti-pipe3: streamline PHY operations Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros [this message]
2014-03-06 14:38 ` [PATCH v2 08/13] phy: ti-pipe3: Fix suspend/resume and module reload Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 09/13] phy: omap: Depend on OMAP_OCP2SCP bus driver Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 10/13] ARM: OMAP5: hwmod: Add ocp2scp3 and sata hwmods Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 11/13] ARM: dts: omap5: add sata node Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 12/13] ARM: DRA7: hwmod: Add ocp2scp3 and sata hwmods Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` [PATCH v2 13/13] ARM: dts: dra7: add OCP2SCP3 and SATA nodes Roger Quadros
2014-03-06 14:38 ` Roger Quadros
2014-03-06 14:38 ` Roger Quadros
-- strict thread matches above, loose matches on Subject: below --
2014-03-06 14:22 [PATCH v2 00/13] ARM: OMAP: SATA support for OMAP5 & DRA7 Roger Quadros
2014-03-06 14:23 ` [PATCH v2 08/13] phy: ti-pipe3: Fix suspend/resume and module reload Roger Quadros
2014-03-06 14:23 ` Roger Quadros
2014-03-06 14:23 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394116729-28811-9-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=george.cherian@ti.com \
--cc=hdegoede@redhat.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.