All of lore.kernel.org
 help / color / mirror / Atom feed
From: greearb@candelatech.com
To: ath10k@lists.infradead.org
Cc: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Subject: [PATCH 3/3] ath10k:  add otp and firmware boot error messages.
Date: Fri, 21 Mar 2014 11:55:50 -0700	[thread overview]
Message-ID: <1395428150-31996-3-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1395428150-31996-1-git-send-email-greearb@candelatech.com>

From: Ben Greear <greearb@candelatech.com>

If OTP or firmware fails to load properly, print out some
extra info in the kernel logs.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 drivers/net/wireless/ath/ath10k/core.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index bf5119f..6b61aa7 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -255,7 +255,8 @@ static int ath10k_download_and_run_otp(struct ath10k *ar)
 	/* OTP is optional */
 
 	if (!ar->otp_data || !ar->otp_len) {
-		ath10k_warn("Not running otp, calibration will be incorrect!\n");
+		ath10k_warn("Not running otp, calibration will be incorrect (otp-data %p otp_len %zd)!\n",
+			    ar->otp_data, ar->otp_len);
 		return 0;
 	}
 
@@ -597,12 +598,16 @@ static int ath10k_init_download_firmware(struct ath10k *ar)
 		return ret;
 
 	ret = ath10k_download_and_run_otp(ar);
-	if (ret)
+	if (ret) {
+		ath10k_err("boot otp execute result %d\n", ret);
 		return ret;
+	}
 
 	ret = ath10k_download_fw(ar);
-	if (ret)
+	if (ret) {
+		ath10k_err("boot download firmware result %d\n", ret);
 		return ret;
+	}
 
 	return ret;
 }
-- 
1.7.11.7


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: greearb@candelatech.com
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Ben Greear <greearb@candelatech.com>
Subject: [PATCH 3/3] ath10k:  add otp and firmware boot error messages.
Date: Fri, 21 Mar 2014 11:55:50 -0700	[thread overview]
Message-ID: <1395428150-31996-3-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1395428150-31996-1-git-send-email-greearb@candelatech.com>

From: Ben Greear <greearb@candelatech.com>

If OTP or firmware fails to load properly, print out some
extra info in the kernel logs.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 drivers/net/wireless/ath/ath10k/core.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index bf5119f..6b61aa7 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -255,7 +255,8 @@ static int ath10k_download_and_run_otp(struct ath10k *ar)
 	/* OTP is optional */
 
 	if (!ar->otp_data || !ar->otp_len) {
-		ath10k_warn("Not running otp, calibration will be incorrect!\n");
+		ath10k_warn("Not running otp, calibration will be incorrect (otp-data %p otp_len %zd)!\n",
+			    ar->otp_data, ar->otp_len);
 		return 0;
 	}
 
@@ -597,12 +598,16 @@ static int ath10k_init_download_firmware(struct ath10k *ar)
 		return ret;
 
 	ret = ath10k_download_and_run_otp(ar);
-	if (ret)
+	if (ret) {
+		ath10k_err("boot otp execute result %d\n", ret);
 		return ret;
+	}
 
 	ret = ath10k_download_fw(ar);
-	if (ret)
+	if (ret) {
+		ath10k_err("boot download firmware result %d\n", ret);
 		return ret;
+	}
 
 	return ret;
 }
-- 
1.7.11.7


  parent reply	other threads:[~2014-03-21 18:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 18:55 [PATCH 1/3] ath10k: Add debugging for tx-credits usage greearb
2014-03-21 18:55 ` greearb
2014-03-21 18:55 ` [PATCH 2/3] ath10k: Better firmware loading error messages greearb
2014-03-21 18:55   ` greearb
2014-03-24 11:21   ` Kalle Valo
2014-03-24 11:21     ` Kalle Valo
2014-03-21 18:55 ` greearb [this message]
2014-03-21 18:55   ` [PATCH 3/3] ath10k: add otp and firmware boot " greearb
2014-03-24 11:25   ` Kalle Valo
2014-03-24 11:25     ` Kalle Valo
2014-03-24 11:12 ` [PATCH 1/3] ath10k: Add debugging for tx-credits usage Kalle Valo
2014-03-24 11:12   ` Kalle Valo
2014-03-24 11:21   ` Michal Kazior
2014-03-24 11:21     ` Michal Kazior
2014-03-24 16:50     ` Ben Greear
2014-03-24 16:50       ` Ben Greear
2014-03-25  7:27       ` Michal Kazior
2014-03-25  7:27         ` Michal Kazior
2014-03-25 15:14         ` Ben Greear
2014-03-25 15:14           ` Ben Greear
2014-03-26  7:18           ` Michal Kazior
2014-03-26  7:18             ` Michal Kazior
2014-03-26 14:40             ` Ben Greear
2014-03-26 14:40               ` Ben Greear
2014-03-26 19:41               ` Janusz Dziedzic
2014-03-26 19:41                 ` Janusz Dziedzic
2014-03-24 16:58   ` Ben Greear
2014-03-24 16:58     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395428150-31996-3-git-send-email-greearb@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.