From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 3/3] ath10k: add otp and firmware boot error messages.
Date: Mon, 24 Mar 2014 13:25:09 +0200 [thread overview]
Message-ID: <87siq76dpm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395428150-31996-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Fri, 21 Mar 2014 11:55:50 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> If OTP or firmware fails to load properly, print out some
> extra info in the kernel logs.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
[...]
> @@ -597,12 +598,16 @@ static int ath10k_init_download_firmware(struct ath10k *ar)
> return ret;
>
> ret = ath10k_download_and_run_otp(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("boot otp execute result %d\n", ret);
> return ret;
> + }
"failed to run otp: %d\n"
> ret = ath10k_download_fw(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("boot download firmware result %d\n", ret);
> return ret;
> + }
"failed to download firmware: %d\n"
And I think you should add the same for ath10k_download_board_data()
call before these two, it neither prints anything when an error happens.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] ath10k: add otp and firmware boot error messages.
Date: Mon, 24 Mar 2014 13:25:09 +0200 [thread overview]
Message-ID: <87siq76dpm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395428150-31996-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Fri, 21 Mar 2014 11:55:50 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> If OTP or firmware fails to load properly, print out some
> extra info in the kernel logs.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
[...]
> @@ -597,12 +598,16 @@ static int ath10k_init_download_firmware(struct ath10k *ar)
> return ret;
>
> ret = ath10k_download_and_run_otp(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("boot otp execute result %d\n", ret);
> return ret;
> + }
"failed to run otp: %d\n"
> ret = ath10k_download_fw(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("boot download firmware result %d\n", ret);
> return ret;
> + }
"failed to download firmware: %d\n"
And I think you should add the same for ath10k_download_board_data()
call before these two, it neither prints anything when an error happens.
--
Kalle Valo
next prev parent reply other threads:[~2014-03-24 11:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 18:55 [PATCH 1/3] ath10k: Add debugging for tx-credits usage greearb
2014-03-21 18:55 ` greearb
2014-03-21 18:55 ` [PATCH 2/3] ath10k: Better firmware loading error messages greearb
2014-03-21 18:55 ` greearb
2014-03-24 11:21 ` Kalle Valo
2014-03-24 11:21 ` Kalle Valo
2014-03-21 18:55 ` [PATCH 3/3] ath10k: add otp and firmware boot " greearb
2014-03-21 18:55 ` greearb
2014-03-24 11:25 ` Kalle Valo [this message]
2014-03-24 11:25 ` Kalle Valo
2014-03-24 11:12 ` [PATCH 1/3] ath10k: Add debugging for tx-credits usage Kalle Valo
2014-03-24 11:12 ` Kalle Valo
2014-03-24 11:21 ` Michal Kazior
2014-03-24 11:21 ` Michal Kazior
2014-03-24 16:50 ` Ben Greear
2014-03-24 16:50 ` Ben Greear
2014-03-25 7:27 ` Michal Kazior
2014-03-25 7:27 ` Michal Kazior
2014-03-25 15:14 ` Ben Greear
2014-03-25 15:14 ` Ben Greear
2014-03-26 7:18 ` Michal Kazior
2014-03-26 7:18 ` Michal Kazior
2014-03-26 14:40 ` Ben Greear
2014-03-26 14:40 ` Ben Greear
2014-03-26 19:41 ` Janusz Dziedzic
2014-03-26 19:41 ` Janusz Dziedzic
2014-03-24 16:58 ` Ben Greear
2014-03-24 16:58 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siq76dpm.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.