All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Lee Jones <lee.jones@linaro.org>
Cc: Angus.Clark@st.com, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
	dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 01/36] mtd: st_spi_fsm: Allocate resources and register with MTD framework
Date: Mon, 07 Apr 2014 10:12:31 +0200	[thread overview]
Message-ID: <1396858351.8506.8.camel@x220> (raw)
In-Reply-To: <1395307268-12721-2-git-send-email-lee.jones@linaro.org>

On Thu, 2014-03-20 at 09:20 +0000, Lee Jones wrote:
> This is a new driver. It's used to communicate with a special type of
> optimised Serial Flash Controller called the FSM. The FSM uses a subset
> of the SPI protocol to communicate with supported NOR-Flash devices.
> 
> Acked-by Angus Clark <angus.clark@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

This patch seems to be commit d90db4a07429 ("mtd: st_spi_fsm: Allocate
resources and register with MTD framework") in current linux-next. 

> ---
>  drivers/mtd/devices/Kconfig      |   8 +++
>  drivers/mtd/devices/Makefile     |   1 +
>  drivers/mtd/devices/st_spi_fsm.c | 106 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 115 insertions(+)
>  create mode 100644 drivers/mtd/devices/st_spi_fsm.c
> 
> diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> index 0128138..1210bc2 100644
> --- a/drivers/mtd/devices/Kconfig
> +++ b/drivers/mtd/devices/Kconfig
> @@ -210,6 +210,14 @@ config MTD_DOCG3
>  	  M-Systems and now Sandisk. The support is very experimental,
>  	  and doesn't give access to any write operations.
>  
> +config MTD_ST_SPI_FSM
> +	tristate "ST Microelectronics SPI FSM Serial Flash Controller"
> +	depends on ARM || SH

That should probably be
          depends on ARM || SUPERH

> +	help
> +	  This provides an MTD device driver for the ST Microelectronics
> +	  SPI Fast Sequence Mode (FSM) Serial Flash Controller and support
> +	  for a subset of connected Serial Flash devices.
> +
>  if MTD_DOCG3
>  config BCH_CONST_M
>  	default 14

Can this still be fixed in a future version of this series or should I
send a trivial patch?


Paul Bolle

WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 01/36] mtd: st_spi_fsm: Allocate resources and register with MTD framework
Date: Mon, 07 Apr 2014 10:12:31 +0200	[thread overview]
Message-ID: <1396858351.8506.8.camel@x220> (raw)
In-Reply-To: <1395307268-12721-2-git-send-email-lee.jones@linaro.org>

On Thu, 2014-03-20 at 09:20 +0000, Lee Jones wrote:
> This is a new driver. It's used to communicate with a special type of
> optimised Serial Flash Controller called the FSM. The FSM uses a subset
> of the SPI protocol to communicate with supported NOR-Flash devices.
> 
> Acked-by Angus Clark <angus.clark@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

This patch seems to be commit d90db4a07429 ("mtd: st_spi_fsm: Allocate
resources and register with MTD framework") in current linux-next. 

> ---
>  drivers/mtd/devices/Kconfig      |   8 +++
>  drivers/mtd/devices/Makefile     |   1 +
>  drivers/mtd/devices/st_spi_fsm.c | 106 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 115 insertions(+)
>  create mode 100644 drivers/mtd/devices/st_spi_fsm.c
> 
> diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> index 0128138..1210bc2 100644
> --- a/drivers/mtd/devices/Kconfig
> +++ b/drivers/mtd/devices/Kconfig
> @@ -210,6 +210,14 @@ config MTD_DOCG3
>  	  M-Systems and now Sandisk. The support is very experimental,
>  	  and doesn't give access to any write operations.
>  
> +config MTD_ST_SPI_FSM
> +	tristate "ST Microelectronics SPI FSM Serial Flash Controller"
> +	depends on ARM || SH

That should probably be
          depends on ARM || SUPERH

> +	help
> +	  This provides an MTD device driver for the ST Microelectronics
> +	  SPI Fast Sequence Mode (FSM) Serial Flash Controller and support
> +	  for a subset of connected Serial Flash devices.
> +
>  if MTD_DOCG3
>  config BCH_CONST_M
>  	default 14

Can this still be fixed in a future version of this series or should I
send a trivial patch?


Paul Bolle

WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, computersforpeace@gmail.com,
	linux-mtd@lists.infradead.org, dwmw2@infradead.org,
	Angus.Clark@st.com
Subject: Re: [PATCH v6 01/36] mtd: st_spi_fsm: Allocate resources and register with MTD framework
Date: Mon, 07 Apr 2014 10:12:31 +0200	[thread overview]
Message-ID: <1396858351.8506.8.camel@x220> (raw)
In-Reply-To: <1395307268-12721-2-git-send-email-lee.jones@linaro.org>

On Thu, 2014-03-20 at 09:20 +0000, Lee Jones wrote:
> This is a new driver. It's used to communicate with a special type of
> optimised Serial Flash Controller called the FSM. The FSM uses a subset
> of the SPI protocol to communicate with supported NOR-Flash devices.
> 
> Acked-by Angus Clark <angus.clark@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

This patch seems to be commit d90db4a07429 ("mtd: st_spi_fsm: Allocate
resources and register with MTD framework") in current linux-next. 

> ---
>  drivers/mtd/devices/Kconfig      |   8 +++
>  drivers/mtd/devices/Makefile     |   1 +
>  drivers/mtd/devices/st_spi_fsm.c | 106 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 115 insertions(+)
>  create mode 100644 drivers/mtd/devices/st_spi_fsm.c
> 
> diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> index 0128138..1210bc2 100644
> --- a/drivers/mtd/devices/Kconfig
> +++ b/drivers/mtd/devices/Kconfig
> @@ -210,6 +210,14 @@ config MTD_DOCG3
>  	  M-Systems and now Sandisk. The support is very experimental,
>  	  and doesn't give access to any write operations.
>  
> +config MTD_ST_SPI_FSM
> +	tristate "ST Microelectronics SPI FSM Serial Flash Controller"
> +	depends on ARM || SH

That should probably be
          depends on ARM || SUPERH

> +	help
> +	  This provides an MTD device driver for the ST Microelectronics
> +	  SPI Fast Sequence Mode (FSM) Serial Flash Controller and support
> +	  for a subset of connected Serial Flash devices.
> +
>  if MTD_DOCG3
>  config BCH_CONST_M
>  	default 14

Can this still be fixed in a future version of this series or should I
send a trivial patch?


Paul Bolle


  reply	other threads:[~2014-04-07  8:12 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  9:20 [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver Lee Jones
2014-03-20  9:20 ` Lee Jones
2014-03-20  9:20 ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 01/36] mtd: st_spi_fsm: Allocate resources and register with MTD framework Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-04-07  8:12   ` Paul Bolle [this message]
2014-04-07  8:12     ` Paul Bolle
2014-04-07  8:12     ` Paul Bolle
2014-04-07  9:11     ` Lee Jones
2014-04-07  9:11       ` Lee Jones
2014-04-07  9:11       ` Lee Jones
2014-04-07  9:41       ` Paul Bolle
2014-04-07  9:41         ` Paul Bolle
2014-04-07  9:41         ` Paul Bolle
2014-04-07 11:08         ` Lee Jones
2014-04-07 11:08           ` Lee Jones
2014-04-07 11:08           ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 02/36] mtd: st_spi_fsm: Supply all register address and bit logic defines Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 03/36] mtd: st_spi_fsm: Initialise and configure the FSM for normal working conditions Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 04/36] mtd: st_spi_fsm: Supply framework for device requests Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 05/36] mtd: st_spi_fsm: Supply a method to read from the FSM's FIFO Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 06/36] mtd: st_spi_fsm: Add support for JEDEC ID extraction Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 07/36] mtd: devices: Provide header for shared OPCODEs and SFDP commands Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 08/36] mtd: st_spi_fsm: Provide device look-up table Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 09/36] mtd: st_spi_fsm: Dynamically setup flash device based on JEDEC ID Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 10/36] mtd: st_spi_fsm: Search for preferred FSM message sequence configurations Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 11/36] mtd: st_spi_fsm: Use device size to determine address width Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 12/36] mtd: st_spi_fsm: Prepare the read/write FSM message sequence(s) Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 13/36] mtd: st_spi_fsm: Add device-tree binding documentation Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 14/36] mtd: st_spi_fsm: Fetch boot-device from mode pins Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 15/36] mtd: st_spi_fsm: Provide the erase one sector sequence Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 16/36] mtd: st_spi_fsm: Provide the sequence for enabling 32bit addressing mode Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 17/36] mtd: st_spi_fsm: Prepare read/write sequences according to configuration Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 18/36] mtd: st_spi_fsm: Add a check to if the chip can handle an SoC reset Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 19/36] mtd: st_spi_fsm: Provide a method to put the chip into 32bit addressing mode Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 20/36] mtd: st_spi_fsm: Update the flash Volatile Configuration Register Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 21/36] mtd: st_spi_fsm: Provide the default read/write configurations Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 22/36] mtd: st_spi_fsm: Supply the N25Qxxx specific read configurations Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 23/36] mtd: st_spi_fsm: Supply the N25Qxxx chip specific configuration call-back Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 24/36] mtd: st_spi_fsm: Prepare default sequences for read/write/erase Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 25/36] mtd: st_spi_fsm: Add the ability to read from a Serial Flash device Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 26/36] mtd: st_spi_fsm: Write to Flash via the FSM FIFO Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20 ` [PATCH v6 27/36] mtd: st_spi_fsm: Supply a busy wait for post-write status Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:20   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 28/36] mtd: st_spi_fsm: Erase partly or as a whole a Serial Flash device Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 29/36] mtd: st_spi_fsm: Add the ability to read the FSM's status Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 30/36] mtd: st_spi_fsm: Add the ability to write to FSM's status register Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 31/36] mtd: st_spi_fsm: Supply the MX25xxx chip specific configuration call-back Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 32/36] mtd: st_spi_fsm: Supply the S25FLxxx " Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 33/36] mtd: st_spi_fsm: Supply the W25Qxxx " Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 34/36] mtd: st_spi_fsm: Move runtime configurable msg sequences into device's struct Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 35/36] mtd: st_spi_fsm: Convert ST SPI FSM (NOR) Flash driver to new DT partitions Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21 ` [PATCH v6 36/36] ARM: STi: Add support for the FSM Serial Flash Controller Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20  9:21   ` Lee Jones
2014-03-20 11:27   ` Brian Norris
2014-03-20 11:27     ` Brian Norris
2014-03-20 11:27     ` Brian Norris
2014-03-20 15:51     ` Lee Jones
2014-03-20 15:51       ` Lee Jones
2014-03-20 15:51       ` Lee Jones
2014-03-20  9:48 ` [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver Brian Norris
2014-03-20  9:48   ` Brian Norris
2014-03-20  9:48   ` Brian Norris
2014-03-20 11:19 ` Brian Norris
2014-03-20 11:19   ` Brian Norris
2014-03-20 11:19   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396858351.8506.8.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=Angus.Clark@st.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.