All of lore.kernel.org
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Michal Michalik <michal.michalik@intel.com>,
	netdev@vger.kernel.org,
	Richard Cochran <richardcochran@gmail.com>,
	linux-kernel@vger.kernel.org,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Milena Olech <milena.olech@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors
Date: Thu, 21 Sep 2023 10:52:48 +0200	[thread overview]
Message-ID: <13c19c01-65ee-44ae-e11a-d3b108c5a97c@intel.com> (raw)
In-Reply-To: <20230920180745.1607563-1-aleksander.lobakin@intel.com>

On 9/20/23 20:07, Alexander Lobakin wrote:
> Recently, several link-time issues were spotted in the ethernet/intel/
> folder thanks to Kbuild bots and linux-next.
> The fixes are pretty straightforward, just some stubs and CONFIG_*
> guards, so resolve all of them in one shot and unbreak randconfig
> builds.
> 
> Alexander Lobakin (3):
>    ice: fix undefined references to ice_is_*() when
>      !CONFIG_PTP_1588_CLOCK
>    ice: fix undefined references from DPLL code when
>      !CONFIG_PTP_1588_CLOCK
>    idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
> 
>   drivers/net/ethernet/intel/ice/Makefile     |  5 ++---
>   drivers/net/ethernet/intel/ice/ice_main.c   |  8 ++++---
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++-
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c |  3 +++
>   4 files changed, 34 insertions(+), 7 deletions(-)
> 
> ---
> Directly to netdev/net-next, build bots are not happy and the next
> linux-next is approaching :s

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

I like the `if (IS_ENABLED(xxx))` approach more than stubs :)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Michal Michalik <michal.michalik@intel.com>,
	<netdev@vger.kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	<intel-wired-lan@lists.osuosl.org>,
	"Milena Olech" <milena.olech@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors
Date: Thu, 21 Sep 2023 10:52:48 +0200	[thread overview]
Message-ID: <13c19c01-65ee-44ae-e11a-d3b108c5a97c@intel.com> (raw)
In-Reply-To: <20230920180745.1607563-1-aleksander.lobakin@intel.com>

On 9/20/23 20:07, Alexander Lobakin wrote:
> Recently, several link-time issues were spotted in the ethernet/intel/
> folder thanks to Kbuild bots and linux-next.
> The fixes are pretty straightforward, just some stubs and CONFIG_*
> guards, so resolve all of them in one shot and unbreak randconfig
> builds.
> 
> Alexander Lobakin (3):
>    ice: fix undefined references to ice_is_*() when
>      !CONFIG_PTP_1588_CLOCK
>    ice: fix undefined references from DPLL code when
>      !CONFIG_PTP_1588_CLOCK
>    idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
> 
>   drivers/net/ethernet/intel/ice/Makefile     |  5 ++---
>   drivers/net/ethernet/intel/ice/ice_main.c   |  8 ++++---
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++-
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c |  3 +++
>   4 files changed, 34 insertions(+), 7 deletions(-)
> 
> ---
> Directly to netdev/net-next, build bots are not happy and the next
> linux-next is approaching :s

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

I like the `if (IS_ENABLED(xxx))` approach more than stubs :)

  parent reply	other threads:[~2023-09-21  8:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 18:07 [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Alexander Lobakin
2023-09-20 18:07 ` Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 1/3] ice: fix undefined references to ice_is_*() when !CONFIG_PTP_1588_CLOCK Alexander Lobakin
2023-09-20 18:07   ` Alexander Lobakin
2023-09-20 23:20   ` [Intel-wired-lan] " Jacob Keller
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code " Alexander Lobakin
2023-09-20 18:07   ` Alexander Lobakin
2023-09-20 23:22   ` [Intel-wired-lan] " Jacob Keller
2023-09-21 23:58   ` Vadim Fedorenko
2023-09-21 23:58     ` Vadim Fedorenko
2023-09-22 13:58     ` [Intel-wired-lan] " Alexander Lobakin
2023-09-22 13:58       ` Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET Alexander Lobakin
2023-09-20 18:07   ` Alexander Lobakin
2023-09-20 21:30   ` [Intel-wired-lan] " Randy Dunlap
2023-09-20 21:30     ` Randy Dunlap
2023-09-21  0:04     ` [Intel-wired-lan] " Jacob Keller
2023-09-21  0:04       ` Jacob Keller
2023-09-21  1:30       ` Randy Dunlap
2023-09-21  1:30         ` Randy Dunlap
2023-10-12 15:47         ` Randy Dunlap
2023-10-12 15:47           ` Randy Dunlap
2023-10-12 16:13           ` Alexander Lobakin
2023-10-12 16:13             ` Alexander Lobakin
2023-10-12 18:34           ` Keller, Jacob E
2023-10-12 18:34             ` Keller, Jacob E
2023-10-12 23:31             ` Jakub Kicinski
2023-10-12 23:31               ` Jakub Kicinski
2023-10-13 17:16               ` Jacob Keller
2023-10-13 17:16                 ` Jacob Keller
2023-09-20 23:24   ` Jacob Keller
2023-09-20 23:31 ` [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Jacob Keller
2023-09-21 12:52   ` Alexander Lobakin
2023-09-21 13:04   ` Alexander Lobakin
2023-09-21 13:04     ` Alexander Lobakin
2023-09-21  8:52 ` Przemek Kitszel [this message]
2023-09-21  8:52   ` Przemek Kitszel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13c19c01-65ee-44ae-e11a-d3b108c5a97c@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.michalik@intel.com \
    --cc=milena.olech@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.