From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Michalik, Michal" <michal.michalik@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>,
"Lobakin, Aleksander" <aleksander.lobakin@intel.com>,
Eric Dumazet <edumazet@google.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Olech, Milena" <milena.olech@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
Date: Thu, 12 Oct 2023 16:31:53 -0700 [thread overview]
Message-ID: <20231012163153.7fe61b40@kernel.org> (raw)
In-Reply-To: <CO1PR11MB508965D49B6144B0CC7E5221D6D3A@CO1PR11MB5089.namprd11.prod.outlook.com>
On Thu, 12 Oct 2023 18:34:00 +0000 Keller, Jacob E wrote:
> > Even if this is just > v6.6 kernels (i.e., linux-next),
> > it would be very good to get a fix merged for these build errors.
> > I keep getting build errors in linux-next....
>
> A standalone version for the idpf driver fix was posted at [1], and
> another alternative fix was posted at [2]
>
> Fixes for the ice driver have already merged.
>
> [1]:
> https://lore.kernel.org/netdev/20230921125936.1621191-1-aleksander.lobakin@intel.com/
> [2]:
> https://lore.kernel.org/netdev/20230925155858.651425-1-arnd@kernel.org/
>
> The fix from Arnd got approval from Olek, but it seems like it
> stalled out after asking about stubs. I'm fine with either approach
> but would also like to see a fix merge soon.
The suggestion of making NET == INET is quite tempting but requires
extra consideration. Since nobody seems to have the cycles, let's
go with the stubs?
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
"Lobakin, Aleksander" <aleksander.lobakin@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Michalik, Michal" <michal.michalik@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Olech, Milena" <milena.olech@intel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
Date: Thu, 12 Oct 2023 16:31:53 -0700 [thread overview]
Message-ID: <20231012163153.7fe61b40@kernel.org> (raw)
In-Reply-To: <CO1PR11MB508965D49B6144B0CC7E5221D6D3A@CO1PR11MB5089.namprd11.prod.outlook.com>
On Thu, 12 Oct 2023 18:34:00 +0000 Keller, Jacob E wrote:
> > Even if this is just > v6.6 kernels (i.e., linux-next),
> > it would be very good to get a fix merged for these build errors.
> > I keep getting build errors in linux-next....
>
> A standalone version for the idpf driver fix was posted at [1], and
> another alternative fix was posted at [2]
>
> Fixes for the ice driver have already merged.
>
> [1]:
> https://lore.kernel.org/netdev/20230921125936.1621191-1-aleksander.lobakin@intel.com/
> [2]:
> https://lore.kernel.org/netdev/20230925155858.651425-1-arnd@kernel.org/
>
> The fix from Arnd got approval from Olek, but it seems like it
> stalled out after asking about stubs. I'm fine with either approach
> but would also like to see a fix merge soon.
The suggestion of making NET == INET is quite tempting but requires
extra consideration. Since nobody seems to have the cycles, let's
go with the stubs?
next prev parent reply other threads:[~2023-10-12 23:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:07 [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Alexander Lobakin
2023-09-20 18:07 ` Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 1/3] ice: fix undefined references to ice_is_*() when !CONFIG_PTP_1588_CLOCK Alexander Lobakin
2023-09-20 18:07 ` Alexander Lobakin
2023-09-20 23:20 ` [Intel-wired-lan] " Jacob Keller
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 2/3] ice: fix undefined references from DPLL code " Alexander Lobakin
2023-09-20 18:07 ` Alexander Lobakin
2023-09-20 23:22 ` [Intel-wired-lan] " Jacob Keller
2023-09-21 23:58 ` Vadim Fedorenko
2023-09-21 23:58 ` Vadim Fedorenko
2023-09-22 13:58 ` [Intel-wired-lan] " Alexander Lobakin
2023-09-22 13:58 ` Alexander Lobakin
2023-09-20 18:07 ` [Intel-wired-lan] [PATCH net-next 3/3] idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET Alexander Lobakin
2023-09-20 18:07 ` Alexander Lobakin
2023-09-20 21:30 ` [Intel-wired-lan] " Randy Dunlap
2023-09-20 21:30 ` Randy Dunlap
2023-09-21 0:04 ` [Intel-wired-lan] " Jacob Keller
2023-09-21 0:04 ` Jacob Keller
2023-09-21 1:30 ` Randy Dunlap
2023-09-21 1:30 ` Randy Dunlap
2023-10-12 15:47 ` Randy Dunlap
2023-10-12 15:47 ` Randy Dunlap
2023-10-12 16:13 ` Alexander Lobakin
2023-10-12 16:13 ` Alexander Lobakin
2023-10-12 18:34 ` Keller, Jacob E
2023-10-12 18:34 ` Keller, Jacob E
2023-10-12 23:31 ` Jakub Kicinski [this message]
2023-10-12 23:31 ` Jakub Kicinski
2023-10-13 17:16 ` Jacob Keller
2023-10-13 17:16 ` Jacob Keller
2023-09-20 23:24 ` Jacob Keller
2023-09-20 23:31 ` [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors Jacob Keller
2023-09-21 12:52 ` Alexander Lobakin
2023-09-21 13:04 ` Alexander Lobakin
2023-09-21 13:04 ` Alexander Lobakin
2023-09-21 8:52 ` Przemek Kitszel
2023-09-21 8:52 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012163153.7fe61b40@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.michalik@intel.com \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.