All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	Deepak Saxena <dsaxena@linaro.org>,
	Will Deacon <Will.Deacon@arm.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/8] arm64 kexec kernel patches
Date: Tue, 13 May 2014 15:26:55 -0700	[thread overview]
Message-ID: <1400020015.11178.70.camel@smoke> (raw)
In-Reply-To: <20140509162240.GC16418@e106331-lin.cambridge.arm.com>

Hi Mark,

Thanks for taking the time to review the patches in such detail.

On Fri, 2014-05-09 at 17:22 +0100, Mark Rutland wrote:

> As I've covered in my reply to patch 7 [1] I don't think this is a good
> approach. I think a vastly better approach is to make kexec depend on
> cpu hotplug support in SMP, and enable a simple hotplug-capable boot
> protocol (e.g. extend spin-table with a cpu-return-addr).
> 
> That way the in-kernel portions of kexec can use the existing
> infrastructure without tonnes of point hacks, and we enable a generic
> hotplug capable mechanism for those systems which cannot implement PSCI.

I think this is a sound approach.  As I was working on the kexec code I
felt the same, that the core SMP CPU management should be doing more and
kexec should just use that existing support.

I'll look into splitting off what spin-table handling I have in kexec
into a patch to update the hotplug support.
 
> >   https://git.linaro.org/people/geoff.levand/kexec-tools.git
> 
> Is the master branch up-to-date?  The commit dates on all branches I can
> see imply they haven't been updated in a while, and the code looks like
> it needs some cleanup (there are some unused functions, hard-coded
> values, etc).

I'm working on the cleanup of kexec-tools now.  I pushed out a version
that should boot vanilla 2nd stage kernels and the branches in my repo.

-Geoff



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: geoff@infradead.org (Geoff Levand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] arm64 kexec kernel patches
Date: Tue, 13 May 2014 15:26:55 -0700	[thread overview]
Message-ID: <1400020015.11178.70.camel@smoke> (raw)
In-Reply-To: <20140509162240.GC16418@e106331-lin.cambridge.arm.com>

Hi Mark,

Thanks for taking the time to review the patches in such detail.

On Fri, 2014-05-09 at 17:22 +0100, Mark Rutland wrote:

> As I've covered in my reply to patch 7 [1] I don't think this is a good
> approach. I think a vastly better approach is to make kexec depend on
> cpu hotplug support in SMP, and enable a simple hotplug-capable boot
> protocol (e.g. extend spin-table with a cpu-return-addr).
> 
> That way the in-kernel portions of kexec can use the existing
> infrastructure without tonnes of point hacks, and we enable a generic
> hotplug capable mechanism for those systems which cannot implement PSCI.

I think this is a sound approach.  As I was working on the kexec code I
felt the same, that the core SMP CPU management should be doing more and
kexec should just use that existing support.

I'll look into splitting off what spin-table handling I have in kexec
into a patch to update the hotplug support.
 
> >   https://git.linaro.org/people/geoff.levand/kexec-tools.git
> 
> Is the master branch up-to-date?  The commit dates on all branches I can
> see imply they haven't been updated in a while, and the code looks like
> it needs some cleanup (there are some unused functions, hard-coded
> values, etc).

I'm working on the cleanup of kexec-tools now.  I pushed out a version
that should boot vanilla 2nd stage kernels and the branches in my repo.

-Geoff

  reply	other threads:[~2014-05-13 22:26 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09  0:48 [PATCH 0/8] arm64 kexec kernel patches Geoff Levand
2014-05-09  0:48 ` Geoff Levand
2014-05-09  0:48 ` [PATCH 6/8] arm64/kexec: kexec needs cpu_die Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09  8:24   ` Mark Rutland
2014-05-09  8:24     ` Mark Rutland
2014-05-13 22:27     ` Geoff Levand
2014-05-13 22:27       ` Geoff Levand
2014-05-09  0:48 ` [PATCH 3/8] arm64: Add spin-table cpu_die Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09  8:54   ` Mark Rutland
2014-05-09  8:54     ` Mark Rutland
2014-05-09  0:48 ` [PATCH 4/8] arm64: Add smp_spin_table_set_die Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09  0:48 ` [PATCH 2/8] arm64: Make cpu_read_ops generic Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09  0:48 ` [PATCH 7/8] arm64/kexec: Add core kexec support Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09 15:36   ` Mark Rutland
2014-05-09 15:36     ` Mark Rutland
2014-05-13 22:27     ` Geoff Levand
2014-05-13 22:27       ` Geoff Levand
2014-05-16 10:26       ` Mark Rutland
2014-05-16 10:26         ` Mark Rutland
2014-05-14 10:54   ` Catalin Marinas
2014-05-14 10:54     ` Catalin Marinas
2014-05-14 23:20     ` Geoff Levand
2014-05-14 23:20       ` Geoff Levand
2014-07-07  7:33   ` Dave Young
2014-07-07  7:33     ` Dave Young
2014-07-11  9:47     ` Dave Young
2014-07-11  9:47       ` Dave Young
2014-05-09  0:48 ` [PATCH 1/8] arm64: Use cpu_ops for smp_stop Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09  8:44   ` Mark Rutland
2014-05-09  8:44     ` Mark Rutland
2014-05-13 22:27     ` Geoff Levand
2014-05-13 22:27       ` Geoff Levand
2014-05-09  0:48 ` [PATCH 5/8] arm64: Split soft_restart into two stages Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09  0:48 ` [PATCH 8/8] arm64: Enable kexec in defconfig Geoff Levand
2014-05-09  0:48   ` Geoff Levand
2014-05-09 16:22 ` [PATCH 0/8] arm64 kexec kernel patches Mark Rutland
2014-05-09 16:22   ` Mark Rutland
2014-05-13 22:26   ` Geoff Levand [this message]
2014-05-13 22:26     ` Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400020015.11178.70.camel@smoke \
    --to=geoff@infradead.org \
    --cc=Catalin.Marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=dsaxena@linaro.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.