From: Geoff Levand <geoff@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
Deepak Saxena <dsaxena@linaro.org>,
Will Deacon <Will.Deacon@arm.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/8] arm64/kexec: kexec needs cpu_die
Date: Tue, 13 May 2014 15:27:23 -0700 [thread overview]
Message-ID: <1400020043.11178.72.camel@smoke> (raw)
In-Reply-To: <20140509082439.GC4757@e106331-lin.cambridge.arm.com>
On Fri, 2014-05-09 at 09:24 +0100, Mark Rutland wrote:
> Hi Geoff,
>
> On Fri, May 09, 2014 at 01:48:17AM +0100, Geoff Levand wrote:
> > Kexec uses the cpu_die method of struct cpu_operations, so add
> > defined(CONFIG_KEXEC) to the preprocessor conditional that enables cpu_die.
>
> Why not make kexec depend on !CONFIG_SMP || CONFIG_HOTPLUG_CPU instead?
>
> From the POV of the PSCI code in the kernel, it's hotplugging a CPU. Why
> it's performing the hotplug operation shouldn't matter.
Sure.
> > @@ -284,7 +284,7 @@ const struct cpu_operations cpu_psci_ops = {
> > .cpu_init = cpu_psci_cpu_init,
> > .cpu_prepare = cpu_psci_cpu_prepare,
> > .cpu_boot = cpu_psci_cpu_boot,
> > -#ifdef CONFIG_HOTPLUG_CPU
> > +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_KEXEC)
> > .cpu_disable = cpu_psci_cpu_disable,
> > .cpu_die = cpu_psci_cpu_die,
> > #endif
>
> Doesn't his cause the build to fail when KEXEC && !HOTPLUG_CPU? I didn't
> see cpu_ops.h updated similarly.
Sorry, that part got lost when rebasing patches. I added back in on my
for-arm-kexec-2 and master branches.
-Geoff
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: geoff@infradead.org (Geoff Levand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] arm64/kexec: kexec needs cpu_die
Date: Tue, 13 May 2014 15:27:23 -0700 [thread overview]
Message-ID: <1400020043.11178.72.camel@smoke> (raw)
In-Reply-To: <20140509082439.GC4757@e106331-lin.cambridge.arm.com>
On Fri, 2014-05-09 at 09:24 +0100, Mark Rutland wrote:
> Hi Geoff,
>
> On Fri, May 09, 2014 at 01:48:17AM +0100, Geoff Levand wrote:
> > Kexec uses the cpu_die method of struct cpu_operations, so add
> > defined(CONFIG_KEXEC) to the preprocessor conditional that enables cpu_die.
>
> Why not make kexec depend on !CONFIG_SMP || CONFIG_HOTPLUG_CPU instead?
>
> From the POV of the PSCI code in the kernel, it's hotplugging a CPU. Why
> it's performing the hotplug operation shouldn't matter.
Sure.
> > @@ -284,7 +284,7 @@ const struct cpu_operations cpu_psci_ops = {
> > .cpu_init = cpu_psci_cpu_init,
> > .cpu_prepare = cpu_psci_cpu_prepare,
> > .cpu_boot = cpu_psci_cpu_boot,
> > -#ifdef CONFIG_HOTPLUG_CPU
> > +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_KEXEC)
> > .cpu_disable = cpu_psci_cpu_disable,
> > .cpu_die = cpu_psci_cpu_die,
> > #endif
>
> Doesn't his cause the build to fail when KEXEC && !HOTPLUG_CPU? I didn't
> see cpu_ops.h updated similarly.
Sorry, that part got lost when rebasing patches. I added back in on my
for-arm-kexec-2 and master branches.
-Geoff
next prev parent reply other threads:[~2014-05-13 22:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 0:48 [PATCH 0/8] arm64 kexec kernel patches Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 5/8] arm64: Split soft_restart into two stages Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 7/8] arm64/kexec: Add core kexec support Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 15:36 ` Mark Rutland
2014-05-09 15:36 ` Mark Rutland
2014-05-13 22:27 ` Geoff Levand
2014-05-13 22:27 ` Geoff Levand
2014-05-16 10:26 ` Mark Rutland
2014-05-16 10:26 ` Mark Rutland
2014-05-14 10:54 ` Catalin Marinas
2014-05-14 10:54 ` Catalin Marinas
2014-05-14 23:20 ` Geoff Levand
2014-05-14 23:20 ` Geoff Levand
2014-07-07 7:33 ` Dave Young
2014-07-07 7:33 ` Dave Young
2014-07-11 9:47 ` Dave Young
2014-07-11 9:47 ` Dave Young
2014-05-09 0:48 ` [PATCH 1/8] arm64: Use cpu_ops for smp_stop Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 8:44 ` Mark Rutland
2014-05-09 8:44 ` Mark Rutland
2014-05-13 22:27 ` Geoff Levand
2014-05-13 22:27 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 8/8] arm64: Enable kexec in defconfig Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 6/8] arm64/kexec: kexec needs cpu_die Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 8:24 ` Mark Rutland
2014-05-09 8:24 ` Mark Rutland
2014-05-13 22:27 ` Geoff Levand [this message]
2014-05-13 22:27 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 3/8] arm64: Add spin-table cpu_die Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 8:54 ` Mark Rutland
2014-05-09 8:54 ` Mark Rutland
2014-05-09 0:48 ` [PATCH 4/8] arm64: Add smp_spin_table_set_die Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 2/8] arm64: Make cpu_read_ops generic Geoff Levand
2014-05-09 0:48 ` Geoff Levand
2014-05-09 16:22 ` [PATCH 0/8] arm64 kexec kernel patches Mark Rutland
2014-05-09 16:22 ` Mark Rutland
2014-05-13 22:26 ` Geoff Levand
2014-05-13 22:26 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400020043.11178.72.camel@smoke \
--to=geoff@infradead.org \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=dsaxena@linaro.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.