From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config
Date: Fri, 06 Jun 2014 21:03:19 +1000 [thread overview]
Message-ID: <1402052599.3247.225.camel@pasglop> (raw)
In-Reply-To: <539152B3.5070702@linux.vnet.ibm.com>
On Fri, 2014-06-06 at 11:03 +0530, Anshuman Khandual wrote:
> On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote:
> > Build throws following errors when CONFIG_SMP=n
> > arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’:
> > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’
> > rc = opal_query_cpu_status(get_hard_smp_processor_id(i),
> >
> > The usage of get_hard_smp_processor_id() needs the declaration from
> > <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn
> > includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h>
> > only on SMP configs and hence UP builds fail.
> >
> > Fix this by directly including <asm/smp.h> in setup.c unconditionally.
>
> Can you please clean up the description in the commit message ? and also
> the first line in the commit message should mention that the patch is
> trying to fix a UP specific build failure.
I don't understand your comment ... the description and subject line
are perfectly fine...
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config
Date: Fri, 06 Jun 2014 21:03:19 +1000 [thread overview]
Message-ID: <1402052599.3247.225.camel@pasglop> (raw)
In-Reply-To: <539152B3.5070702@linux.vnet.ibm.com>
On Fri, 2014-06-06 at 11:03 +0530, Anshuman Khandual wrote:
> On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote:
> > Build throws following errors when CONFIG_SMP=n
> > arch/powerpc/platforms/powernv/setup.c: In function ‘pnv_kexec_wait_secondaries_down’:
> > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of function ‘get_hard_smp_processor_id’
> > rc = opal_query_cpu_status(get_hard_smp_processor_id(i),
> >
> > The usage of get_hard_smp_processor_id() needs the declaration from
> > <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn
> > includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h>
> > only on SMP configs and hence UP builds fail.
> >
> > Fix this by directly including <asm/smp.h> in setup.c unconditionally.
>
> Can you please clean up the description in the commit message ? and also
> the first line in the commit message should mention that the patch is
> trying to fix a UP specific build failure.
I don't understand your comment ... the description and subject line
are perfectly fine...
Ben.
next prev parent reply other threads:[~2014-06-06 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 15:21 [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config Shreyas B. Prabhu
2014-06-05 15:21 ` Shreyas B. Prabhu
2014-06-05 15:24 ` [PATCH 2/2] powerpc/powernv : Disable subcore for UP configs Shreyas B. Prabhu
2014-06-05 15:24 ` Shreyas B. Prabhu
2014-06-06 5:52 ` Anshuman Khandual
2014-06-06 5:52 ` Anshuman Khandual
2014-06-06 5:33 ` [PATCH 1/2] powerpc/powernv: include asm/smp.h to handle UP config Anshuman Khandual
2014-06-06 5:33 ` Anshuman Khandual
2014-06-06 6:30 ` Geert Uytterhoeven
2014-06-06 6:30 ` Geert Uytterhoeven
2014-06-06 11:03 ` Benjamin Herrenschmidt [this message]
2014-06-06 11:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402052599.3247.225.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.